Nyaaori/rockbox
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
29232 commits 17 branches 142 tags 291 MiB
Commit graph

996 commits

Author SHA1 Message Date
Jens Arnold
1d6df54df2 Convert a number of places in core and plugins to use the BIT_N() macro instead of 1<<n. Speeds up things on SH1, and also reduces core binsize. Most notable speedups: 1 bit lcd driver: drawpixel +20%, drawline + 27%, hline +5%; jpeg viewer: +8% for 1/8 scaling. Other targets are unaffected. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21205 a1c6a512-1295-4272-9138-f99709370657
 2009-06-07 21:27:05 +00:00
Andrew Mahone
2bedde17b6 Don't perform YUV->RGB conversion before row output for unscaled loads of greyscale JPEG, as store_row_jpeg already does this. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21174 a1c6a512-1295-4272-9138-f99709370657
 2009-06-03 06:35:10 +00:00
Andrew Mahone
b41208fffd Don't recheck for track art when checking track art first. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21127 a1c6a512-1295-4272-9138-f99709370657
 2009-05-29 10:58:23 +00:00
Andrew Mahone
84106fd917 Change the search_albumart_files "ignore track art" option to check track art last. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21126 a1c6a512-1295-4272-9138-f99709370657
 2009-05-29 10:31:56 +00:00
Alexander Levin
a484054d55 Describe the magic of search_albumart_files (still not complete) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21120 a1c6a512-1295-4272-9138-f99709370657
 2009-05-28 20:05:31 +00:00
Andrew Mahone
f51189cd5e Suggested by Thomas Martitz, don't check for track-specific files when searching for covers in PictureFlow. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21111 a1c6a512-1295-4272-9138-f99709370657
 2009-05-28 04:34:07 +00:00
Andrew Mahone
00d6cfd389 Fix yellow when building with HAVE_ALBUMART, without HAVE_JPEG/HAVE_BMP_SCALING. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21092 a1c6a512-1295-4272-9138-f99709370657
 2009-05-26 20:26:05 +00:00
Andrew Mahone
92785b8f2f Use pre-multiplication in scaler to save one multiply per color component on ARM and Coldfire, at the cost of an extra add/shift in the horizontal scaler to reduce values to a workable range. SH-1 retains the same basic math, as 
the use of 16x16->32 hardware multiplication in the earlier scaler stages saves more than removing the 32x32->40 multiply to descale output.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21091 a1c6a512-1295-4272-9138-f99709370657
 2009-05-26 20:00:47 +00:00
Maurus Cuelenaere
d2ea7db6f5 Should fix red 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21082 a1c6a512-1295-4272-9138-f99709370657
 2009-05-25 20:15:02 +00:00
Maurus Cuelenaere
0bddb7eb65 Fix FORMAT_RETURN_SIZE in read_bmp_*() when scaling (thanks to Andrew Mahone) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21078 a1c6a512-1295-4272-9138-f99709370657
 2009-05-25 15:19:34 +00:00
Maurus Cuelenaere
aec37aa5fe * read_bmp_*(): add FORMAT_RETURN_SIZE 
* Lua: add luaL_checkboolean() & luaL_optboolean()
* Lua: add read_bmp_file


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21074 a1c6a512-1295-4272-9138-f99709370657
 2009-05-25 11:12:27 +00:00
Marc Guay
814b3dbfbc FS#10230 - Remove 'start new file if not recording' functionality from ACTION_REC_NEWFILE 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21034 a1c6a512-1295-4272-9138-f99709370657
 2009-05-22 13:51:56 +00:00
Bertrik Sikken
0023943439 Fix duplicate #includes 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20977 a1c6a512-1295-4272-9138-f99709370657
 2009-05-17 14:50:19 +00:00
Bertrik Sikken
8d5dbf4c14 Clean up some unused #includes 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20975 a1c6a512-1295-4272-9138-f99709370657
 2009-05-17 11:56:06 +00:00
Andrew Mahone
f7ec9c0fad Clean up albumart.c a bit, reducing use of USE_JPEG_COVER inside search_albumart_files to only around the folder.jpg test and a strlen call. 0 delta vs previous code for #undef HAVE_JPEG. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20958 a1c6a512-1295-4272-9138-f99709370657
 2009-05-16 08:20:47 +00:00
Alexander Levin
98bcb0a8a8 Define a symbol and use it instead of repeating the condition 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20956 a1c6a512-1295-4272-9138-f99709370657
 2009-05-16 07:34:36 +00:00
Alexander Levin
e7ab26535a Make variables static where possible 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20955 a1c6a512-1295-4272-9138-f99709370657
 2009-05-16 06:59:29 +00:00
Andrew Mahone
d59bff092d FS#10201, skip folder.jpg in search_albumart_files if size_string is not empty. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20951 a1c6a512-1295-4272-9138-f99709370657
 2009-05-15 23:26:37 +00:00
Alexander Levin
3eb6da3c1d Remove unneeded function call (radio_load_presets does clear the memory) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20941 a1c6a512-1295-4272-9138-f99709370657
 2009-05-15 07:56:15 +00:00
Andrew Mahone
c8b67c3ca0 Flag EOF and empty buffer conditions as UNLIKELY in JPEG decoder. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20907 a1c6a512-1295-4272-9138-f99709370657
 2009-05-11 00:16:57 +00:00
Andrew Mahone
b5c356be85 Fix a bug reading JPEG when the output data is smaller than sizeof(struct jpeg), and add more optional debugging output in the decoder. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20906 a1c6a512-1295-4272-9138-f99709370657
 2009-05-11 00:16:48 +00:00
Bertrik Sikken
09085a30f6 Remove unneeded #include "backdrop.h" 
Remove unneeded #include "statusbar.h"


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20891 a1c6a512-1295-4272-9138-f99709370657
 2009-05-09 18:09:14 +00:00
Andrew Mahone
74e4d17910 Don't build 16-point IDCT on greyscale targets, since it's only used for chroma components. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20887 a1c6a512-1295-4272-9138-f99709370657
 2009-05-09 10:32:13 +00:00
Andrew Mahone
59e70b50d8 Inline output_row_8_native when building bmp.c in core without HAVE_JPEG or HAVE_BMP_SCALING. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20886 a1c6a512-1295-4272-9138-f99709370657
 2009-05-09 10:32:07 +00:00
Andrew Mahone
e3b1d78dfc Fix test for direct JPEG output, bump plugin API as r20884 changed struct custom_format. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20885 a1c6a512-1295-4272-9138-f99709370657
 2009-05-09 10:10:26 +00:00
Andrew Mahone
91efc16256 Split 8-bit-to-native conversion in bmp.c into a function, add support for plugging unscaled output in BMP and JPEG loaders, use output_row_8_native in JPEG decoder when possible. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20884 a1c6a512-1295-4272-9138-f99709370657
 2009-05-09 07:31:27 +00:00
Andrew Mahone
7b81cd0caf Convert Huffman decode from inline function to macro, for small code size saving on ARM and on Coldfire color, only finish DC decode on greyscale targets if decoding luma channel. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20874 a1c6a512-1295-4272-9138-f99709370657
 2009-05-08 07:21:35 +00:00
Andrew Mahone
0af7494b37 Small size improvement for JPEG on ARM/Coldfire. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20873 a1c6a512-1295-4272-9138-f99709370657
 2009-05-08 04:19:10 +00:00
Andrew Mahone
cda907435b Fix red. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20872 a1c6a512-1295-4272-9138-f99709370657
 2009-05-08 03:59:51 +00:00
Andrew Mahone
a75c72c169 Plugin JPEG decoder for data in memory, along with test_mem_jpeg.c and bench_mem_jpeg.c plugins to test and benchmark it, and a line-length clean up in jpeg_load.c. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20871 a1c6a512-1295-4272-9138-f99709370657
 2009-05-08 03:46:48 +00:00
Andrew Mahone
d2c1298e19 Never use upscaling IDCT for luma (to reduce blockiness), plus some small size optimizations by not calculating or storing scale factors or k_need/zero_need for chroma on greyscale. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20866 a1c6a512-1295-4272-9138-f99709370657
 2009-05-07 08:32:17 +00:00
Andrew Mahone
5621fd393a Build pictureflow using overlay on lowmem targets, support JPEG AA in PF on all targets. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20864 a1c6a512-1295-4272-9138-f99709370657
 2009-05-07 01:23:13 +00:00
Andrew Mahone
eef7945a97 Move YUV->RGB in JPEG load from before scaler to after scaler. Required change to struct custom_format, so sorted the plugin API as well. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20856 a1c6a512-1295-4272-9138-f99709370657
 2009-05-06 04:53:56 +00:00
Andrew Mahone
20f76d61ae Make JPEG and BMP scaler optional with HAVE_JPEG and HAVE_BMP_SCALING, both defined for all targets that have HAVE_ALBUMART. Disable JPEG in PictureFlow and pluginlib album art search with 32KiB plugin buffer until PictureFlow 
gets overlay support.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20851 a1c6a512-1295-4272-9138-f99709370657
 2009-05-04 15:46:41 +00:00
Bertrik Sikken
ad031e903c Make local function static in jpeg_load.c, add missing header file in read_image.c 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20848 a1c6a512-1295-4272-9138-f99709370657
 2009-05-03 07:02:09 +00:00
Andrew Mahone
b40878043c Fix AA search for file with same basename to test all extensions. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20838 a1c6a512-1295-4272-9138-f99709370657
 2009-05-01 23:46:51 +00:00
Andrew Mahone
54e6eb3bda Search for, and load, JPEG album art files. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20837 a1c6a512-1295-4272-9138-f99709370657
 2009-05-01 23:31:43 +00:00
Andrew Mahone
60d4209383 Add core JPEG reader, adapted from the JPEG plugin's decoder, with some changes to prevent include conflicts between the two decoders. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20836 a1c6a512-1295-4272-9138-f99709370657
 2009-05-01 23:24:23 +00:00
Andrew Mahone
1541c313a0 Improve scaler reciprocal precision by 1 bit, and remove unused SC_NUM, SC_FIX, and SC_SHIFT. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20654 a1c6a512-1295-4272-9138-f99709370657
 2009-04-08 06:25:06 +00:00
Thomas Martitz
842d2bc1c3 Some Sansa Fuze keymap work, enable line editing for the keyboard, copy from the e200 keymap mostly, but use the home key for some jobs (stopping playback, exiting some screens,i.e. what REC+POWER do on the e200 is only home on the fuze) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20578 a1c6a512-1295-4272-9138-f99709370657
 2009-03-30 15:45:15 +00:00
Nicolas Pennequin
396aeafa6c Correct Björn's name in various file headers. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20491 a1c6a512-1295-4272-9138-f99709370657
 2009-03-23 17:08:46 +00:00
Rob Purchase
1a6bcfa2c1 D2: Enable FM radio (based on FS#10035 by Michael Burtin with some changes by myself). Also updates the LV24020 driver to add optional logf debugging. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20420 a1c6a512-1295-4272-9138-f99709370657
 2009-03-21 00:13:20 +00:00
Jonas Häggqvist
cd34de693c Invert albumart when LCD Mode is set to inverse. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20357 a1c6a512-1295-4272-9138-f99709370657
 2009-03-19 17:43:53 +00:00
Andrew Mahone
f8877bf42d small speedup for scaler on sh-1, via use of hardware multiply instruction where possible 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20322 a1c6a512-1295-4272-9138-f99709370657
 2009-03-14 01:41:02 +00:00
Bertrik Sikken
4a70a076ed Fix red. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20250 a1c6a512-1295-4272-9138-f99709370657
 2009-03-08 20:57:37 +00:00
Jens Arnold
d8ff94121f Get rid of a useless copy instruction in the SH1 32*32->64bit multiply routines (signed and unsigned). 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20013 a1c6a512-1295-4272-9138-f99709370657
 2009-02-15 23:13:26 +00:00
Jens Arnold
789b0a2eb9 Add an unsigned 32*32->top32 bit multiply for resizing on SH1, and switch to 32 bit precision using that. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20012 a1c6a512-1295-4272-9138-f99709370657
 2009-02-15 17:07:18 +00:00
Jens Arnold
11ad7b4bc8 Move screendump from apps to firmware, solving two nasty firmware-to-apps calls. This required to move the filename creation functions as well. * Fix bug in the BMP header of Clip screendumps. * Add remote screendump for targets with an LCD remote. * Simplify some ifdefs and rename a macro in the sim. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19967 a1c6a512-1295-4272-9138-f99709370657
 2009-02-10 23:43:37 +00:00
Michael Sevakis
94537f954e Gigabeat S: Implement an SDMA API and use it in the PCM driver. Some other miscellaneous adjustments to recording and PCM buffer to accomodate use of physical addresses and cache coherency. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19949 a1c6a512-1295-4272-9138-f99709370657
 2009-02-08 22:32:41 +00:00
Jonathan Gordon
701a593c5d continuation of last nights statusbar cleanup. 
accept FS#9858 and FS#9859
make the rec and fm screens force the statusbar the correct way now which doesnt need extra status variables


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19904 a1c6a512-1295-4272-9138-f99709370657
 2009-02-02 03:14:51 +00:00
Jonathan Gordon
036fb05dfd Accept a quick patch from Alexander Levin to neaten up the #defines and comments from my earlier commit 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19897 a1c6a512-1295-4272-9138-f99709370657
 2009-02-01 13:43:08 +00:00
Jonathan Gordon
80cb3551eb Statusbar handling fixes. 
Fixes FS#9845 - %we/%wd wasnt working
WPS no longer resets the viewportmanger more than needed (was doing it twice/draw before)
screens can now enable/disable the statusbar easily ignoring the setting instead of needing special handling (fix for the radio screen coming soon)

minor glitch introduced in this commit... the statusbar in the WPS might disappear for a fraction of a second when it is entered, I need to track this down...


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19894 a1c6a512-1295-4272-9138-f99709370657
 2009-02-01 11:34:16 +00:00
Bertrik Sikken
8e2ff63a7e Various files: make function implementations consistent with their declaration in the header file or static if 
they're local.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19892 a1c6a512-1295-4272-9138-f99709370657
 2009-01-31 23:51:11 +00:00
Maurus Cuelenaere
36c71a60ca Get checkwps working again 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19880 a1c6a512-1295-4272-9138-f99709370657
 2009-01-29 20:49:43 +00:00
Jens Arnold
21a0504d16 Hopefully fix wrong colours on coldfire targets for certain scaling factors. EMAC needs to be in unsigned integer mode. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19853 a1c6a512-1295-4272-9138-f99709370657
 2009-01-25 15:59:43 +00:00
Andrew Mahone
6fc558b2db plugins/lib/feature_wrappers.h to provide easy access to some feature that may be in either API or pluginlib depending on target 
pictureflow modified to use feature wrappers, and built on all targets that have tagcache and are swcodec


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19837 a1c6a512-1295-4272-9138-f99709370657
 2009-01-24 09:29:22 +00:00
Andrew Mahone
7215a67e64 albumart search in pluginlib when building without HAVE_ALBUMART (for later use by pictureflow) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19835 a1c6a512-1295-4272-9138-f99709370657
 2009-01-24 04:09:29 +00:00
Andrew Mahone
9f08068ecf fix test for SH in resize.h 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19804 a1c6a512-1295-4272-9138-f99709370657
 2009-01-20 18:23:50 +00:00
Andrew Mahone
1b13299769 scaler optimizations: 
on sh, use 8.24 fixed-point C math for final division in scaler

on coldfire, use 8.32 fixed-point via emac

on other architectures, use 8.32 fixed-point C math

use shift-and-add to divide when adjusting scale factors in pictureflow

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19802 a1c6a512-1295-4272-9138-f99709370657
 2009-01-20 17:24:49 +00:00
Andrew Mahone
738a5643ad support pixel aspect ratio compensation in recalc_dimension, with PAR defined as 1:1 by default, and set to 4:5 for archos bitmap targets 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19759 a1c6a512-1295-4272-9138-f99709370657
 2009-01-13 14:41:29 +00:00
Andrew Mahone
2fbf09752d remove align_buffer from firmare/general.c, replacing with ALIGN_BUFFER macro, and replace all uses of it (only resize.c in core, and pictureflow and mpegplayer plugins), remove it from plugin_api, 
and remove wrapper for it from plugin.h


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19758 a1c6a512-1295-4272-9138-f99709370657
 2009-01-13 13:48:26 +00:00
Andrew Mahone
07e982df8a cleanup for core-file-in-pluginlib compilation: 
wrapper C files in pluginlib renamed to the same name as the core files they
wrap

pluginlib-only init functions for resize and bmp moved into the wrapper files,
and declared in the associated header files

API() macro removed entirely, in favor of a core-only header file that
redefines core function names to use a plugin_api pointer

some unnecessary uses of PLUGIN in apps/recorder/bmp.c removed


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19712 a1c6a512-1295-4272-9138-f99709370657
 2009-01-08 02:49:23 +00:00
Jonathan Gordon
45aa9a22f9 temporarilty disable the statusbar in the keyboard because it doesnt use viewports and this is the easier fix than reworking the screen 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19683 a1c6a512-1295-4272-9138-f99709370657
 2009-01-05 10:25:41 +00:00
Andrew Mahone
4eedc93357 build a scaling-enabled bitmap loader in pluginlib for mono bitmap targets, and use it in the test greylib scaler plugin 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19671 a1c6a512-1295-4272-9138-f99709370657
 2009-01-04 21:22:05 +00:00
Bertrik Sikken
32c2f455d1 static/const/#include/tab police on various files 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19643 a1c6a512-1295-4272-9138-f99709370657
 2009-01-02 21:43:52 +00:00
Jonathan Gordon
e385ee18ce Decouple the statusbar drawing from the rest of the screen drawing. it is not drawn roughly 4x per second automatically. 
viewport_Set_defaults() will setup the given viewport with the correct "full screen" dimensions (so start at 0,0 if statusbars are disabled or 0,8 if they are enabled.)
All screens should keep the statusbar enabled, but if you really want to ignore the user setting you can disbaled it with viewportmanager_set_statusbar(false).

This commit also includes some menu/list viewport cleanups from kugel in FS#9603


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19622 a1c6a512-1295-4272-9138-f99709370657
 2008-12-31 05:59:26 +00:00
Michael Sevakis
2e99b3d931 Gigabeat S: Allow recording from FM. Give FM the same volume range as playback. NOTE: This bumps the si4700 output volume to -0dB so other players with that may need a minor adjustment. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19619 a1c6a512-1295-4272-9138-f99709370657
 2008-12-31 01:38:44 +00:00
Andrew Mahone
9058620849 Make scaler output truly pluggable, add an 8-bit greyscale output to 
pluginlib for use with greylib, and add source for a test scaled bmp
viewer using greylib.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19593 a1c6a512-1295-4272-9138-f99709370657
 2008-12-26 07:05:13 +00:00
Andrew Mahone
f7fa7e5ad5 Latest work on the bmp on-load scaler: 
Macros for calculating size needed for bitmap load and scaling, so that
these can be compile-time constant when their inputs are.

Reduce size of bayer dither by chopping all but first row of dither
matrix, and replacing 2D lookup with 1D lookup and small calculation.

Move some functions not related to actual bmp file loading out of bmp.c.

A smaller brightness() for mono targets, and a higher-quality one for
greyscale targets, both replacing the division by 10 with a shift.

Port of the linear and area scalers to greyscale targets, this costs
some binsize but produces better output even when dithered to 2bpp.

Move duplicated row output code from inside vertical scalers to a
separate row output function.

Move some multiplies out of the line scaler, for a small speedup and
code size reduction, as well as a small improvement in accuracy for the
upscaling case.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19592 a1c6a512-1295-4272-9138-f99709370657
 2008-12-26 07:03:22 +00:00
Jonathan Gordon
f6251e4256 Accept FS#9646 by Christopher Williams which fixes a few radio preset bugs: 
* presets list does not scroll horizontally properly (due to the list_do_action() repeatedly timing out after 1 second)
* when returning from the presets list to the main radio screen, the highlighted item in the list scrolls on main radio screen (if it's too wide for the screen, that is)
* when adding a preset while in the presets list (with ACTION_FM_PRESET) the list is not updated with the new preset
* when clearing presets (or deleting the last preset), the main screen still shows the same preset number
* when deleting a preset, the current preset number doesn't change if it's past the end of the list (this is partially related to the previous issue)
* the find_closest_preset() routine could be improved to actually find the closest frequency that is saved as a preset
* inputting a preset name could be optimized in both time and space (especially in radio_add_preset()); also the length parameter to kbd_input() includes the null terminator, so I added one to those arguments


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19457 a1c6a512-1295-4272-9138-f99709370657
 2008-12-16 12:05:16 +00:00
Andrew Mahone
676fd32c96 fix yellow 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19440 a1c6a512-1295-4272-9138-f99709370657
 2008-12-14 18:42:05 +00:00
Andrew Mahone
524c5409c3 remove unneeded test 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19439 a1c6a512-1295-4272-9138-f99709370657
 2008-12-14 17:58:04 +00:00
Michael Sevakis
93572e2a9e Keyclick fixup take two. It is only 88 samples (2msec) long so keep a small static buffer around for beeps less than or equal to keyclick duration. This way it operates no matter the buffer state and still won't interfere with alternate PCM operations like recording or plugin playback. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19415 a1c6a512-1295-4272-9138-f99709370657
 2008-12-13 06:01:08 +00:00
Michael Sevakis
826688e699 PCM buffer beeping needs the audio buffer reset in order to work after operations that trash the buffer or keyclick won't be audible until playback is restarted. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19413 a1c6a512-1295-4272-9138-f99709370657
 2008-12-13 02:48:36 +00:00
Andrew Mahone
ea5d0bd7ec fix yellow 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19394 a1c6a512-1295-4272-9138-f99709370657
 2008-12-12 03:16:06 +00:00
Andrew Mahone
66b0d8198e fix broken greyscale upscaling 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19393 a1c6a512-1295-4272-9138-f99709370657
 2008-12-12 02:44:13 +00:00
Michael Sevakis
441fca176a Fix a wrong comment in thread.c and mention an alternative approach to inits. Fix a couple headers' Id fields while at it. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19386 a1c6a512-1295-4272-9138-f99709370657
 2008-12-10 21:10:34 +00:00
Andrew Mahone
72f150139e fix get_totalsize to return the correct size in some cases where it failed 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19385 a1c6a512-1295-4272-9138-f99709370657
 2008-12-10 20:41:53 +00:00
Andrew Mahone
995c89cb6f code cleanup, more descriptive variable names, and algorithm docs for color scalers 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19381 a1c6a512-1295-4272-9138-f99709370657
 2008-12-10 12:09:03 +00:00
Andrew Mahone
eb04315b19 small binsize improvement for color scalers 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19380 a1c6a512-1295-4272-9138-f99709370657
 2008-12-10 09:45:49 +00:00
Michael Sevakis
f2f394793c Fix red and a couple other things I somehow missed. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19378 a1c6a512-1295-4272-9138-f99709370657
 2008-12-10 09:11:43 +00:00
Michael Sevakis
8cfbd3604f Use cookies for thread identification instead of pointers directly which gives a buffer against wrongly identifying a thread when the slot is recycled (which has been nagging me for awhile). A slot gets 255 uses before it repeats. Everything gets incompatible so a full update is required. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19377 a1c6a512-1295-4272-9138-f99709370657
 2008-12-10 08:57:10 +00:00
Andrew Mahone
40ff47c7ee fix yellow - bogus unitialized use warnings 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19376 a1c6a512-1295-4272-9138-f99709370657
 2008-12-09 23:48:34 +00:00
Andrew Mahone
781421afa2 resize-on-load for bitmap files on 2bpp and color targets 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19374 a1c6a512-1295-4272-9138-f99709370657
 2008-12-09 23:07:59 +00:00
Nils Wallménius
65f61d6cce FS#9609 FM radio support for the Gigabeat S, seeking/scanning is not yet 
implemented but manual tuning works nicely. Thanks to Rafaël Carré,
Bertrik Sikken and Robert Menes for suggestions and debugging help.



git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19372 a1c6a512-1295-4272-9138-f99709370657
 2008-12-09 20:48:04 +00:00
Frank Gevaerts
059fff29ec Since *set_led_enabled() is actually an ata-specific feature, move it back to ata_* only 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19006 a1c6a512-1295-4272-9138-f99709370657
 2008-11-04 19:57:36 +00:00
Björn Stenberg
ac488f8cb7 Makefile overhaul. All generated bitmaps are now explicitly in OBJDIR/bitmaps and OBJDIR/pluginbitmaps, and plugins properly depend on their respective bitmap files. Fixes #6847. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18987 a1c6a512-1295-4272-9138-f99709370657
 2008-11-03 14:37:50 +00:00
Frank Gevaerts
2f8a0081c6 Apply FS#9500. This adds a storage_*() abstraction to replace ata_*(). To do that, it also introduces sd_*, nand_*, and mmc_*. 
This should be a good first step to allow multi-driver targets, like the Elio (ATA/SD), or the D2 (NAND/SD).


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18960 a1c6a512-1295-4272-9138-f99709370657
 2008-11-01 16:14:28 +00:00
Björn Stenberg
51b45d5602 Split id3.c/h into metadata.c/h and metadata/mp3.c. Updated all references. Moved mp3data.c/h from firmware to apps. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18814 a1c6a512-1295-4272-9138-f99709370657
 2008-10-15 06:38:51 +00:00
Magnus Holmgren
9c52c39528 Make some dependencies on id3.h explicit. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18810 a1c6a512-1295-4272-9138-f99709370657
 2008-10-14 18:40:52 +00:00
Björn Stenberg
9cf024c5a8 Red build fix: Moved PCM #defines from pcm_record.h to pcm.h. Added necessary #includes to statusbar.c and s1a0903x01.c. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18808 a1c6a512-1295-4272-9138-f99709370657
 2008-10-14 11:43:32 +00:00
Björn Stenberg
9558c4956d Moved pcm_record from firmware to apps. Cleaned up some. Now all code using struct mp3entry is in apps. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18807 a1c6a512-1295-4272-9138-f99709370657
 2008-10-14 11:12:20 +00:00
Peter D'Hoye
528fe442fc New recording setting to configure how mono recordings are made. Previously, this was always L+R, which was kinda silly if your signal was on L only. This setting allows for L, R or L+R. SWCODEC only for now, to be added for HWCODEC (although that will only be L and L+R probably) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18745 a1c6a512-1295-4272-9138-f99709370657
 2008-10-08 22:18:16 +00:00
Marcoen Hirschberg
88c60e6b07 add morse input support to the Olympus m:robe 100, patch by Roy Wallace, FS#9450 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18741 a1c6a512-1295-4272-9138-f99709370657
 2008-10-08 11:02:51 +00:00
Peter D'Hoye
216b7d4247 Fix broken h1x0 sim build by providing a stub for pcm_sample_rate() 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18326 a1c6a512-1295-4272-9138-f99709370657
 2008-08-20 22:57:02 +00:00
Peter D'Hoye
b4483f05af Recording screen: show spdif samplerate on SWCODEC targets (with spdif of course). To be adapted so this also works for HWCODEC. And to be tested as I have no cable around and a broken disk in my h120.... 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18325 a1c6a512-1295-4272-9138-f99709370657
 2008-08-20 22:33:38 +00:00
Peter D'Hoye
44d4fcd7d2 Recording screen: do not show L/R gain settings when recording mono; do not show gain (and AGC) at all when recording via spdif. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18324 a1c6a512-1295-4272-9138-f99709370657
 2008-08-20 21:38:47 +00:00
Peter D'Hoye
551886ce27 Accept FS #9301 by Christopher Williams: fix radio preset list after removing a preset 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18318 a1c6a512-1295-4272-9138-f99709370657
 2008-08-19 19:39:21 +00:00
Peter D'Hoye
74b01ffbfd Adapt comment to the fact that the splash is removed 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18283 a1c6a512-1295-4272-9138-f99709370657
 2008-08-15 08:40:34 +00:00
Nils Wallménius
01729e7a18 FS#9281 Rename of splash functions. 
* Remove gui_splash()
* Rename gui_syncsplash() to splashf() and remove its voice 
capabilities.
* Rename the internal splash() to splash_internal() and introduce an 
externally visible splash() that handles simple splashing  without 
printf functionality e.g. splash(HZ, ID2P(LANG_FOO)); or splash(HZ, 
"foo"); if a LANG_* id is passed it will be voiced.
* Adjust all places that called gui_syncsplash() to use the correct 
variant from above.
* Export both new functions to plugins and adjust places calling 
rb->splash() to use the correct variant so that we now have naming 
consistency between the core and plugins.
* Fix one latent bug that would cause my sim to crash with the above 
changes and correct P2STR and P2ID macros, thanks to pondlife.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18282 a1c6a512-1295-4272-9138-f99709370657
 2008-08-15 08:27:39 +00:00
Peter D'Hoye
2966c7cc5a Fix a small delay in updating the recording screen. This caused the screen not to update when changing settings fast (key repeat) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18273 a1c6a512-1295-4272-9138-f99709370657
 2008-08-13 21:09:10 +00:00
Peter D'Hoye
76b6262df8 Adapt clip counter to compact view of recording screen 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18246 a1c6a512-1295-4272-9138-f99709370657
 2008-08-11 18:32:10 +00:00
Peter D'Hoye
4396b5b101 Recording screen: show a more compact view if 6 lines do not fit but 4 do. Should help things on small screens or with big fonts. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18239 a1c6a512-1295-4272-9138-f99709370657
 2008-08-10 21:03:07 +00:00
Nils Wallménius
c49438419d Style police, trigStat -> trig_stat 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18209 a1c6a512-1295-4272-9138-f99709370657
 2008-08-07 11:48:56 +00:00
Peter D'Hoye
496e1f7e85 First step of the recording screen redesign. The screen is split into a fixed top part containing essential data and the peakmeters/triggerbar, and a bottom part that is in fact a list. The list contains the items that can be changed, and also some stuff that isn't important enough to be on the top part, like the filename. That filename is now shown completely. If the font is too big to have 6 lines on the display, sysfont is used. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18202 a1c6a512-1295-4272-9138-f99709370657
 2008-08-06 20:12:44 +00:00
Peter D'Hoye
ff5533f3ac A bit of code police, no functional changes 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18191 a1c6a512-1295-4272-9138-f99709370657
 2008-08-03 22:47:33 +00:00
Dominik Riebeling
02103a2fa7 Unify opening of utf-8 files (FS#6203). This also adds ignoring the BOM in several places it has been missing (as FS#6071). 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18185 a1c6a512-1295-4272-9138-f99709370657
 2008-08-02 20:39:03 +00:00
Jonathan Gordon
fad013fcdd fix FS#9200 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18077 a1c6a512-1295-4272-9138-f99709370657
 2008-07-17 02:50:05 +00:00
Jonathan Gordon
92bd97b121 fix FS#9146 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17945 a1c6a512-1295-4272-9138-f99709370657
 2008-07-05 12:47:34 +00:00
Bertrik Sikken
f4d4a6ab60 Implement FS#8947 - Add a stub in the simulator for ata_disk_is_active. This make it possible to clean up some #ifdef SIMULATOR macros. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17927 a1c6a512-1295-4272-9138-f99709370657
 2008-07-03 13:37:57 +00:00
Peter D'Hoye
05cb42164b Fix FS #9128: invalidate the peakmeter scales when switching between playback and recording. This causes them to be recalculated so they show up correctly when playback and recording use different viewport sizes. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17869 a1c6a512-1295-4272-9138-f99709370657
 2008-06-29 08:05:00 +00:00
Peter D'Hoye
4af5dd84a2 fix red 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17859 a1c6a512-1295-4272-9138-f99709370657
 2008-06-28 21:02:43 +00:00
Peter D'Hoye
205f3df781 Remove a viewport ambiguity by changing the screens width/heigth members into lcdwidth/lcdheight. Normal usercode should always use getwidth()/getheigth() as that returns the viewport width/height. Fixes issues that would have appeared in many places when introducing viewports with sizes != lcd sizes. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17857 a1c6a512-1295-4272-9138-f99709370657
 2008-06-28 20:45:21 +00:00
Daniel Stenberg
2acc0ac542 Updated our source code header to explicitly mention that we are GPL v2 or 
later. We still need to hunt down snippets used that are not. 1324 modified
files...
http://www.rockbox.org/mail/archive/rockbox-dev-archive-2008-06/0060.shtml


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17847 a1c6a512-1295-4272-9138-f99709370657
 2008-06-28 18:10:04 +00:00
Peter D'Hoye
90b616913b Peakmeters: use screens[].getwidth() and not screens[].width as the latter one returns the LCD width (which really shouldn't be there) - the former returns the width of the viewport. Do some code police as well. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17841 a1c6a512-1295-4272-9138-f99709370657
 2008-06-28 16:59:56 +00:00
Peter D'Hoye
db00c568c9 Fix broken peakmeters: peakmeter was using viewport drawing code but absolute screen coordinates for display updating. To Do: peakmeter must completely use viewport info for its updates. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17838 a1c6a512-1295-4272-9138-f99709370657
 2008-06-28 16:31:06 +00:00
Jens Arnold
3867cf9181 Use the flash disk icon on all flash sttorage targets instead just on the Ondio. Pointed out by Llorean. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17812 a1c6a512-1295-4272-9138-f99709370657
 2008-06-27 21:40:06 +00:00
Jonathan Gordon
bdbdb97f19 FS#9051 - remove LCD margins... use viewports if you need them... 
NOTE to WPS people....
%m has been removed, but (i think) because of the other %m tags it wont fail if you try loading a wps with %m|..|, it will just be ignored.
Also note that if the statusbar is enabled the default viewport is 8 pixels shorter than when its not, i.e (0,0) is really (0,8) if the statusbar is shown... I dont think this will be a major issue because almost no WPS show the bar and use bitmaps... text only WPS shouldnt be affected.

Please report problem screens in http://forums.rockbox.org/index.php?topic=17358.0


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17763 a1c6a512-1295-4272-9138-f99709370657
 2008-06-23 13:20:35 +00:00
Peter D'Hoye
f76122f0e7 Accept FS #9052 by Alexander Levin with a fix by me. Changes HAS_BUTTONBAR into HAVE_BUTTONBAR to bring it in line with the other defines 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17655 a1c6a512-1295-4272-9138-f99709370657
 2008-05-29 20:32:39 +00:00
Jonathan Gordon
0501fb016c total removal of gui_textarea. The only thing using the text_message struct is the yesno screen so move its definition to yesno.h 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17653 a1c6a512-1295-4272-9138-f99709370657
 2008-05-29 11:13:46 +00:00
Jonathan Gordon
43f0770943 move the HAS_BUTTONBAR define to the config-<target>.h files 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17652 a1c6a512-1295-4272-9138-f99709370657
 2008-05-29 09:14:32 +00:00
Jonathan Gordon
ff469ab573 Updated recording trigger screen (seems to be a feature almost noone uses?) 
problems/complaints in http://forums.rockbox.org/index.php?topic=16837.0
there is a known issue that on this screen the stop icon wont update, I dont know why and noone else wants to look at it, so hopefully this will force another set of eyes on it.. this is only a graphical issue... recordings still work fine


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17643 a1c6a512-1295-4272-9138-f99709370657
 2008-05-28 10:55:39 +00:00
Peter D'Hoye
9098112869 Fix red 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17532 a1c6a512-1295-4272-9138-f99709370657
 2008-05-15 23:00:33 +00:00
Peter D'Hoye
a3524029bf Accept FS #8994: add another recording filesplit option: stop recording and shutdown 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17531 a1c6a512-1295-4272-9138-f99709370657
 2008-05-15 22:47:07 +00:00
Bertrik Sikken
19425909c3 Another round of making local functions static and making sure that source files are in sync with their header files. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17337 a1c6a512-1295-4272-9138-f99709370657
 2008-05-03 21:33:00 +00:00
Bertrik Sikken
e15f8a21a9 Made source files #include the header file that they implement to make sure they are in sync. Made some local functions static. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17312 a1c6a512-1295-4272-9138-f99709370657
 2008-05-03 08:35:14 +00:00
Bertrik Sikken
2843469876 Moved atoi declaration to stdlib.h. Deleted atoi.h 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17280 a1c6a512-1295-4272-9138-f99709370657
 2008-04-28 16:18:04 +00:00
Nils Wallménius
33c44461e1 Const police raid, making a lot of pointers to lang strings const and removing some ugly casting 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17251 a1c6a512-1295-4272-9138-f99709370657
 2008-04-26 09:30:24 +00:00
Bertrik Sikken
db2d61f4ea Killed unnecessary global variables by making them static. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17184 a1c6a512-1295-4272-9138-f99709370657
 2008-04-20 10:24:15 +00:00
Magnus Holmgren
79fb077933 When looking for album art in /.rockbox/albumart/, use album artist rather than artist, if available. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17171 a1c6a512-1295-4272-9138-f99709370657
 2008-04-19 15:21:09 +00:00
Nils Wallménius
a01996436d Use file_exists and dir_exists functions where appropriate, fix one wrong file descriptor check and one possible dir descriptor leak 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17147 a1c6a512-1295-4272-9138-f99709370657
 2008-04-16 19:51:43 +00:00
Nils Wallménius
6848961aa5 Pass the buffer length to the list_get_name callback functions instead of using hardcoded MAX_PATH 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17049 a1c6a512-1295-4272-9138-f99709370657
 2008-04-09 15:25:17 +00:00
Steve Bavin
799e9489ca Remove some more simulator debugging output. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17019 a1c6a512-1295-4272-9138-f99709370657
 2008-04-07 17:19:53 +00:00
Dave Chapman
78d29f535f Major cleanup of checkwps - fix all warnings and add a script to build versions for all supported targets (plus some unsupported ones). You now need to run the version of checkwps that matches the device your WPS is for. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16831 a1c6a512-1295-4272-9138-f99709370657
 2008-03-26 23:35:34 +00:00
Dave Chapman
b9bb723f12 1) Make Rockbox reject any WPSs if there are errors loading any of the required bmps; 2) Make checkwps actually load the images using the Rockbox bmp loader, and reject the WPS in the same was as Rockbox on bmp errors. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16822 a1c6a512-1295-4272-9138-f99709370657
 2008-03-26 18:18:22 +00:00
Jonathan Gordon
5ca1539969 the menu and list now accepts a parent viewport to draw in (and the menu can be told to not show status/button bars). This lays the groundwork to fix colour problems with plugin menus (see star.c for an example.) This hopefully fixes some button bar issues as well as theme problems. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16812 a1c6a512-1295-4272-9138-f99709370657
 2008-03-26 03:35:24 +00:00
Dave Chapman
d02c79c03f Commit viewports-in-WPS patch (FS#8385). This adds the %V tag - see the CustomWPS page for details (shortly...). There is still some work to do - decide how to handle font references, decide how to handle conditionals. Plus checkwps is broken - I'll fix that in a separate commit. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16733 a1c6a512-1295-4272-9138-f99709370657
 2008-03-21 19:38:00 +00:00
Jens Arnold
8113717da9 Fix BMP loader for the iAudio M3 display. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16722 a1c6a512-1295-4272-9138-f99709370657
 2008-03-20 17:40:58 +00:00
Jens Arnold
76614b3687 Make vkeyboard usable on M3. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16709 a1c6a512-1295-4272-9138-f99709370657
 2008-03-18 22:59:39 +00:00
Peter D'Hoye
9c3f6c4079 Simplify that clip indicator reset code a bit 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16559 a1c6a512-1295-4272-9138-f99709370657
 2008-03-08 20:32:37 +00:00
Peter D'Hoye
30ab1a3c0e Reset recording clipping indicators when changing gain. Solves FS #6147 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16557 a1c6a512-1295-4272-9138-f99709370657
 2008-03-08 17:43:04 +00:00
Peter D'Hoye
0ecdb37e99 Fix FS #8514 (remote peakmeter issue) by separating the peak release times for the screens. Thanks to amiconn for pointing in the right direction. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16234 a1c6a512-1295-4272-9138-f99709370657
 2008-02-06 21:53:07 +00:00
Magnus Holmgren
2235081dbc Prevent possible buffer overflow when locating album art. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16231 a1c6a512-1295-4272-9138-f99709370657
 2008-02-06 19:51:19 +00:00
Nicolas Pennequin
cfe51b0cd1 Add a couple safety checks in search_albumart_files(). Should fix the sliding_puzzle crashes. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16225 a1c6a512-1295-4272-9138-f99709370657
 2008-02-05 11:56:21 +00:00
Jonas Häggqvist
2cffb1bf3d Look for albumart in .rockbox/albumart/<artist>-<album><size>.bmp in addition to the current locations. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16110 a1c6a512-1295-4272-9138-f99709370657
 2008-01-19 18:05:06 +00:00
Nicolas Pennequin
536b5a0482 Accept FS#8469 by Bryan Childs with a few adjustments: Remove duplicate strip_extension() function from albumart.c. The other one is moved from tree.c to misc.c. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16103 a1c6a512-1295-4272-9138-f99709370657
 2008-01-18 10:02:03 +00:00
Jonathan Gordon
4d238c14d7 bandaid fix for FS#8168 - statusbar would be enabled if poweroff happened while in fm screen. a proper fix is to not force the statusbar on in the fm screen, but untill that happens this is fine. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16044 a1c6a512-1295-4272-9138-f99709370657
 2008-01-10 06:46:04 +00:00
Peter D'Hoye
db1e12bac0 Quick fix to prevent freezing of H10 (possibly others too) when left at the disk full message. Needs more investigation to find the cause of the freeze. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15938 a1c6a512-1295-4272-9138-f99709370657
 2007-12-15 23:51:13 +00:00
Nicolas Pennequin
90ce826903 Initial commit of the PictureFlow plugin, a nice visualization for album covers. 
Original code by Ariya Hidayat. Rockbox port by Jonas Hurrelmann and a few tweaks by me.
On the first startup the database is scanned and album art is searched for each album. This process will take some time (dircache enabled and/or database in RAM speed it up, and it is possible to abort by pressing MENU), but the results are cached and the next startups will be very quick.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15900 a1c6a512-1295-4272-9138-f99709370657
 2007-12-09 18:48:02 +00:00
Peter D'Hoye
05007e1a79 More code police 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15890 a1c6a512-1295-4272-9138-f99709370657
 2007-12-07 00:31:31 +00:00
Peter D'Hoye
327d78eb6e Code police 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15889 a1c6a512-1295-4272-9138-f99709370657
 2007-12-07 00:28:16 +00:00
Peter D'Hoye
a007b558b3 Fix gradient selection bar in recording screen 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15888 a1c6a512-1295-4272-9138-f99709370657
 2007-12-07 00:07:30 +00:00
Jens Arnold
89bfb66939 BMP loader: Handle top-down BMP files (height is negative). Note that the e200 example pictures still don't work, as they are larger than the screen (not a loader problem). 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15855 a1c6a512-1295-4272-9138-f99709370657
 2007-11-30 08:51:18 +00:00
Michael Sevakis
b0dd9eb5bc Repair the no-spinup on start/split feature of recording. Recording directory selection broke it. Please only look at the disk during encoder loading opportunities in future additions. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15853 a1c6a512-1295-4272-9138-f99709370657
 2007-11-30 05:14:57 +00:00
Linus Nielsen Feltzing
236cdaee03 Make the recording screen handle button repeats correctly when changing gain. Fixes FS#8038. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15811 a1c6a512-1295-4272-9138-f99709370657
 2007-11-26 11:51:39 +00:00
Nils Wallménius
e711de2974 Make the variable for numbers of screens to update const on non-remote-lcd targets. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15806 a1c6a512-1295-4272-9138-f99709370657
 2007-11-25 21:47:16 +00:00
Robert Kukla
ed64a663a0 make check_dir use dir_exists and slightly optimise the latter 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15744 a1c6a512-1295-4272-9138-f99709370657
 2007-11-21 22:42:52 +00:00
Robert Kukla
d87b037efe consolidate the 3 file_exists() functions into one; use the version that explicitly uses dircache; give dir_exists() the same treatment for consistency 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15742 a1c6a512-1295-4272-9138-f99709370657
 2007-11-21 21:28:27 +00:00
Michael Sevakis
fadbf0a6f7 Make threads responsible for explicit cancellation of their own boosted status. Sleeping and timeouts will no longer cancel it. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15709 a1c6a512-1295-4272-9138-f99709370657
 2007-11-20 03:44:25 +00:00
Magnus Holmgren
7aa4ae6e45 Improved use of album name when locating the album art file: replace chars that are invalid in file names; double quotes to single quotes, other invalid chars to underscore (now only very long album names could cause a problem). Also removed some unecessary code and reduced stack usage a bit. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15630 a1c6a512-1295-4272-9138-f99709370657
 2007-11-15 20:22:03 +00:00
Nicolas Pennequin
1480d078e7 Add an error check, just to be safe. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15596 a1c6a512-1295-4272-9138-f99709370657
 2007-11-12 14:26:47 +00:00
Nicolas Pennequin
81dedee7d0 Various album art improvements: 
* Make the album art display tag static instead of dynamic, making it be drawn less often, which is good.
* Add the possibility of clearing the album art bitmap instead of drawing it, and use this abaility when the display tag is inside a conditional construct.
* Add the album art display tag to wps_debug.c.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15592 a1c6a512-1295-4272-9138-f99709370657
 2007-11-12 01:31:42 +00:00
Barry Wardell
c495cdae59 FS#8046: H10 FM tuner support. Thanks to Przemyslaw Holubowski for doing the hard work in figuring out how to communicate with the tuner. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15578 a1c6a512-1295-4272-9138-f99709370657
 2007-11-11 16:00:33 +00:00
Nicolas Pennequin
9d4bed7ff0 Album art support. Based on FS#3045, but heavily modified to adapt to MoB and for cleanness. 
The cover pictures are loaded from external bitmaps. JPEG and embedded art are not supported. The pictures will only be drawn on the main display. There is no resizing but it is possible to specify the WPS bitmap size in the bitmap names (e.g. cover.100x100.bmp).
The bitmaps are stored in the main buffer and read directly from there. Currently, duplicate bitmaps will simply be present several times in the buffer, but this will be improved.
To enable for a target, #define HAVE_ALBUMART in its config file.
For more information, see the wiki page: http://www.rockbox.org/wiki/AlbumArt.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15572 a1c6a512-1295-4272-9138-f99709370657
 2007-11-11 12:29:37 +00:00
Nicolas Pennequin
ec6569ed22 Add read_bmp_fd and make the first parameter of read_bmp_file ("filename") const. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15553 a1c6a512-1295-4272-9138-f99709370657
 2007-11-10 13:26:11 +00:00
Stéphane Doyon
d65f9f15f9 More voice for the radio: accept FS#6331. 
In the radio screen, speak the mode (preset or scan) when switching mode.
When switching stations with the radio paused/muted, speak the current
preset (number, frequency if preset is default, or spell, depending
on talk_file setting). Also says the frequency if in scan mode.

Change the default preset created by autoscan to be an empty string; change
the preset menu callback to substitute the frequency when the preset name
is empty.

Add a voice callback for the preset menu.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15507 a1c6a512-1295-4272-9138-f99709370657
 2007-11-07 02:14:28 +00:00
Steve Bavin
31a2f33eb8 Mop up some yellow. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15207 a1c6a512-1295-4272-9138-f99709370657
 2007-10-19 15:43:43 +00:00
Steve Bavin
32a9575130 FS#7994 - Rename talk.c API, make talk_disable() affect all talking (not just menus), hopefully save some space. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15206 a1c6a512-1295-4272-9138-f99709370657
 2007-10-19 15:31:42 +00:00
Jens Arnold
8b44601a7c Disable highperf mode in the peakmeter for swcodec targets, as it makes no sense. Improves responsiveness a lot with a peakmeter-enabled wps on targets with slow lcd updates (e.g. G5). Added a comment why highperf mode is needed for MAS targets. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15140 a1c6a512-1295-4272-9138-f99709370657
 2007-10-16 08:34:51 +00:00
Jens Arnold
9afdf99212 Add the vkeyboard line end beep to (swcodec) targets with non-modal keyboard. * Select modal keyboard and enable morse mode for iPod 1st/2nd gen. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15066 a1c6a512-1295-4272-9138-f99709370657
 2007-10-10 06:19:54 +00:00
Jens Arnold
064de4ce4d Slight code policing. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15065 a1c6a512-1295-4272-9138-f99709370657
 2007-10-10 06:02:08 +00:00
Jens Arnold
100d343963 Fix red Ondio builds. Hwcodec targets can't beep that way, so disable that beep for them.* Port the other vkeyboard enhancements (fixed character spelling and edit mode announcement) to the charcell vkeyboard (Player). 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15064 a1c6a512-1295-4272-9138-f99709370657
 2007-10-10 05:56:53 +00:00
Stéphane Doyon
1b89d588e1 Accessible keyboard: guard the beep with talk_menus_enabled() 
rather than the beep setting from the playback settings.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15062 a1c6a512-1295-4272-9138-f99709370657
 2007-10-10 03:57:42 +00:00
Stéphane Doyon
d529a3845b Make the virtual keyboard easier to use for blind users. 
From FS#6324

When moving up/down and landing on the edit line, say "edit". Otherwise
it gets quite confusing.

When moving left and right on the edit line, sound a beep when the left
or right end is reached.

Before, it would say nothing either when the cursor is over a blank or
a char it doesn't know how to spell. So if we're on a blank spot, say
"blank".

Pass the whole utf8 char to be spelled.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15060 a1c6a512-1295-4272-9138-f99709370657
 2007-10-10 02:28:58 +00:00
Stéphane Doyon
0279c71a92 Voice the recording trigger settings screen. 
From FS#6325, with a slight coding improvement.
Also take out a duplicated snprintf in there.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15059 a1c6a512-1295-4272-9138-f99709370657
 2007-10-10 01:41:48 +00:00
Stéphane Doyon
5acf091046 Add a voice callback to dynamic menus, along side the text_callback. 
From FS#7563.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15042 a1c6a512-1295-4272-9138-f99709370657
 2007-10-09 03:48:56 +00:00
Michael Sevakis
6077e5b7c8 Unify PCM interface just above the hardware driver level for all targets including the sims. Perform lockout of audio callback when changing states. Weird new playback or recording trouble? Check before and after this revision first though things seem quite sound. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15006 a1c6a512-1295-4272-9138-f99709370657
 2007-10-06 22:27:27 +00:00
Marianne Arnold
af97e9369a Commit FS #7881 by Mark Arigo - enable radio on the Sansa c200. It seems that many (if not all) c200s have the radio hardware even if you can't use it with the original firmware... 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14963 a1c6a512-1295-4272-9138-f99709370657
 2007-10-02 21:04:10 +00:00
Nicolas Pennequin
49a9e1ef35 Make the gradient look better when more than one line is selected (running time, ID3 info, cuesheet viewer...). I haven't found a solution for scrolling yet, so that won't look too good. 
The recording screen code needs a bit of adapting too, but I don't have a target to test on, so leave it for now.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14884 a1c6a512-1295-4272-9138-f99709370657
 2007-09-28 13:49:43 +00:00
Nicolas Pennequin
f3b015f73b FS#7808 by Tom Ross, Ken Fazzone and me, with help from Antoine Cellerier. 
Add two new line selector types: solid colour and gradient. Solid colour only uses the primary colour setting.
The secondary colour setting is used for the gradient. Text colour for the selected item is also changeable.
These new settings are a bit controversial so they may be removed later.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14868 a1c6a512-1295-4272-9138-f99709370657
 2007-09-27 15:42:55 +00:00
Peter D'Hoye
376169ab95 small optimisation: make a locally used function static 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14815 a1c6a512-1295-4272-9138-f99709370657
 2007-09-22 09:05:06 +00:00
Nils Wallménius
c70d9462be Make a few private functins static and use fewer bytes for constants 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14783 a1c6a512-1295-4272-9138-f99709370657
 2007-09-20 16:44:28 +00:00
Jonathan Gordon
cf1cef5f57 minor update to gui_synclist_do_button() which will hopefully simplify things later. 
Now returns true if the action was handled in that function instead of returning the handled action.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14733 a1c6a512-1295-4272-9138-f99709370657
 2007-09-17 10:08:50 +00:00
Jens Arnold
945462edef Make peakmeters work for real in swcodec simulators instead of just showing random movement. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14650 a1c6a512-1295-4272-9138-f99709370657
 2007-09-09 09:07:22 +00:00
Peter D'Hoye
a3fb2b4e3e The clipcount string used in the rec screen should have been named sysfont. Fix also the already translated ones. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14524 a1c6a512-1295-4272-9138-f99709370657
 2007-08-29 18:36:29 +00:00
Peter D'Hoye
6109d39469 only build the clipcounter for targets with recording 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14467 a1c6a512-1295-4272-9138-f99709370657
 2007-08-26 21:34:36 +00:00
Peter D'Hoye
583f186ce4 Implement FS #2976: Clip Counter for recording screen. If enabled in peak meter settings, it shows the number of times clipping occurred (clip indicator going on). Count is reset on recording start and only counts during actual recording. Stays on screen when stopping or pauzing. Also fix a drawing bug when peakmeters start at a non-zero x offset. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14455 a1c6a512-1295-4272-9138-f99709370657
 2007-08-25 15:53:54 +00:00
Jens Arnold
99ff02d2cb Make peak release work per tick as intended. But that's too fast, so it's not the final solution. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14397 a1c6a512-1295-4272-9138-f99709370657
 2007-08-20 06:36:24 +00:00
Nils Wallménius
c023cb8783 Revert previous 'fix' and implement the correct one, thanks markun! :-) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14396 a1c6a512-1295-4272-9138-f99709370657
 2007-08-19 21:33:57 +00:00
Nils Wallménius
f2a1803b28 Always reset glyph width for loadable keyboards fixes FS#6220 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14394 a1c6a512-1295-4272-9138-f99709370657
 2007-08-19 17:10:57 +00:00
Peter D'Hoye
ebcf06d237 Make peakmeter release setting work in units per tick (was units per read), add the unit and make it voiced. Make old leftover in lang file deprecated 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14390 a1c6a512-1295-4272-9138-f99709370657
 2007-08-18 23:03:03 +00:00
Nils Wallménius
5b76936a44 Accept FS#6159 'Add voice to roughly 100 splash screens and yes-no menus' by Stephane Doyon with some minor tweaks by me. Rerun 'configure' and do a 'make clean' before rebuilding your voice files. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14213 a1c6a512-1295-4272-9138-f99709370657
 2007-08-06 13:08:36 +00:00
Nils Wallménius
b311367481 *** Lang v2 cleanup (FS#6574) *** 
1) Introduces apps/features.txt that controls which strings are included 
for each target based on defines.
2) .lng and .voice files are now target specific and the format versions 
of both these file types have been bumped, which means that new voice 
files are needed. 
3) Use the 'features' mechanism to exclude strings for targets that 
didn't use them.
4) Delete unused and deprecated and duplicated strings, sort strings in 
english.lang

Some string IDs were changed so translations will be slightly worse than 
before.



git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14198 a1c6a512-1295-4272-9138-f99709370657
 2007-08-05 19:19:39 +00:00
Peter D'Hoye
6c36a58e49 Final changes to the recording naming code, this should make jhMikeS happy ;) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14165 a1c6a512-1295-4272-9138-f99709370657
 2007-08-03 18:55:00 +00:00
Peter D'Hoye
c21abddaae Even more optimizing for the recording name change... 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14148 a1c6a512-1295-4272-9138-f99709370657
 2007-08-02 18:45:38 +00:00
Jens Arnold
31ff52cee6 Simplify the source based recording file names a bit. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14136 a1c6a512-1295-4272-9138-f99709370657
 2007-08-02 10:40:47 +00:00
Peter D'Hoye
705ca703e3 Let recording create filenames based on the recording source, closes FS #921 (yes, he waited 4 years for his feature request to make it) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14125 a1c6a512-1295-4272-9138-f99709370657
 2007-08-01 22:04:28 +00:00
Jonathan Gordon
f7675a244b remove the need for action_signalscreenchange(). 
Fixes problems with targets where the ACTION_STD_CANCEL event is a combo


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13956 a1c6a512-1295-4272-9138-f99709370657
 2007-07-22 06:05:53 +00:00
Michael Sevakis
680afafc23 Fix all the red this time? 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13884 a1c6a512-1295-4272-9138-f99709370657
 2007-07-14 13:41:59 +00:00
Michael Sevakis
7d759f6b9c Do some planned radio interface cleanup since adding in the LV24020LP. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13880 a1c6a512-1295-4272-9138-f99709370657
 2007-07-14 11:20:31 +00:00