- Fix regexp case insensitive option being inverted.
- Pass more objects by reference.
- Some const-ness.
Change-Id: I1c77ad22ab1e505c8dce8c083d9c52e76a6860be
QProgressDialog shows / hides itself automatically based on the progress
value set, so calling hide() directly doesn't prevent the dialog from
showing itself.
Change the logic to set a value instead. Fixes the progress dialog
sometimes appearing in situations where it wasn't used at all.
Change-Id: Ifef063f31b7f888bb74f180dea0679e81cc5c8fe
When communicating with Festival via socket don't assume readAll() would
read all data we expect. We can only read the data that has been sent by
the server so far, and this is not necessarily complete.
This notably improves the configuration dialog response and reliably.
Change-Id: I9a812f03df785fb3ad32783a8573a2c86dc317ed
Qt uses the systems certificate store. On old(er) systems the root
certificate might not be present, so checking the certificate from the
rockbox.org server might fail.
On startup we try to download the build-info file. If this fails with a
certificate error allow the user to temporarily accept the rockbox.org
certificate for all successive requests.
Change-Id: I459e12d53286aaedea4db659d90a5e057c56801f
For development builds we provide a download URL, but use the daily
build files. Those require the version of the daily build to be set when
expanding the URL string.
Change-Id: Ie6dcf38f7e86527217edc01ee11a20758a178622
We now initialize sectorbuf explicitly, and there are situation where it
wasn't initialized explicitly.
Change-Id: I35516a1fa7326c0861885ffa058737de19285c2c
Don't try to get a bootloader filename from an empty list. This happens
if the device doesn't have a bootloader file on disk.
Change-Id: Idd4c265e7ae298913c5feefb3963120867a0e858
Instead of checking for certain hardcoded strings, fetch
the actual capability bitmask by instantiating an installer
and querying it.
Change-Id: I7883d9c1e90da37ee7c0189732ac626685adbfa1
Since we're using signals to connect to the Logger we don't need an
interface class, and the only thing still used was the log level enum.
Put those values in a dedicated header instead.
Change-Id: Ic3aee14ba13b81e283b477d11b1c15a5c26ffeab
Simplify, and replace use of QRegExp with QRegularExpression for Qt6
compatibility.
Also fix the test running on Windows. RockboxInfo constructs the
filename from path and filename, so we cannot pass an empty path, since
that results in an invalid path. On Linux / MacOS this works only
because we use an absolute path.
Change-Id: Ieaf30a2df005291d3e997aabf42d64ee832381c2
The former is not part of Qt6 anymore, while the latter has been
introduced with Qt5. We don't support Qt4 anymore, so move to
QRegularExpression.
Change-Id: Icc15ef422790f3740660c5581294aa0536f46b1f
rbutil uses several components from the utils folder, and can be
considered part of utils too. Having it in a separate folder is an
arbitrary split that doesn't help anymore these days, so merge them.
This also allows other utils to easily use libtools.make without the
need to navigate to a different folder.
Change-Id: I3fc2f4de19e3e776553efb5dea5f779dfec0dc21
