Nyaaori/rockbox
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
21018 commits 17 branches 142 tags 291 MiB
Commit graph

437 commits

Author SHA1 Message Date
Nicolas Pennequin
d3b8245ca8 Second part of FS#8104 by Bertrik Sikken: Simplification of audio_track_count, audio_have_tracks and audio_have_free_tracks. This hopefully won't affect anything, but the semantics of the functions have changed slightly. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15693 a1c6a512-1295-4272-9138-f99709370657
 2007-11-19 16:37:52 +00:00
Karl Kurbjun
d185f9eba8 Fix the Gigabeat red and move it's hw specific code into the target tree 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15562 a1c6a512-1295-4272-9138-f99709370657
 2007-11-10 23:13:27 +00:00
Karl Kurbjun
d3c0a7f169 Change the way the UART recieves data and how buttons pressed are processed. Also move some of the debug menu into the target tree and allow rockblox to build when the screen is rotated. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15560 a1c6a512-1295-4272-9138-f99709370657
 2007-11-10 22:12:54 +00:00
Jens Arnold
33acc66256 * Add newfound GPO32 register to pp502x.h. * Introduce macros for the PP502x's atomic GPIO bit manipulation feature. * Remove clock setup related registers from debug screen, and add DEV_EN2, DEV_EN3 (to be verified) and GPO32 instead. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15443 a1c6a512-1295-4272-9138-f99709370657
 2007-11-03 22:47:27 +00:00
Jens Arnold
c9fca1e69c Show exact CPU version on PP5002 targets. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15427 a1c6a512-1295-4272-9138-f99709370657
 2007-11-03 08:09:07 +00:00
Jonathan Gordon
13343c02ca tsc2100 debug screen 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15405 a1c6a512-1295-4272-9138-f99709370657
 2007-11-02 06:17:53 +00:00
Karl Kurbjun
38548c7118 Build some more plugins for M:Robe most work, doom builds and runs if you use a hack - need to fix the user timer so that it works properly. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15403 a1c6a512-1295-4272-9138-f99709370657
 2007-11-02 05:21:34 +00:00
Nicolas Pennequin
3e3c43c747 Finally commit Metadata on Buffer! 
buffering.c and buffering.h implement the new buffering API. playback.c is translated to that API. For more information about the whole concept, see http://www.rockbox.org/wiki/MetadataOnBuffer.
There should be no major visible changes, but most existing bugs remain (though fixing them should be easier now that playback.c is a bit less complex) and there probably will be new ones. Please report any problem!
Next step is to adapt cuesheet support, which is partly disabled here, and of course fix as much bugs as possible.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15306 a1c6a512-1295-4272-9138-f99709370657
 2007-10-25 21:27:45 +00:00
Barry Wardell
67d5b2b468 FS#8013 - tidy up ADC readings in debug menu. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15299 a1c6a512-1295-4272-9138-f99709370657
 2007-10-25 09:29:38 +00:00
Jonathan Gordon
0465101f92 allow simplelists to set the timeout and the start selection. 
set a slightly saner default timeout
talk the selected item when the list is first displayed


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15247 a1c6a512-1295-4272-9138-f99709370657
 2007-10-21 13:47:43 +00:00
Miika Pekkarinen
caff835d78 Fixed debug menu crashing. Show last file processed by tagcache engine in debug menu. Enabled autoupdating of deleted files for flash storage devices. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15244 a1c6a512-1295-4272-9138-f99709370657
 2007-10-21 11:06:30 +00:00
Jonathan Gordon
616971c71e remove the seelection_size param from the info init call to hopefully decrease the bin size a bit 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15237 a1c6a512-1295-4272-9138-f99709370657
 2007-10-21 06:42:52 +00:00
Jonathan Gordon
5eac0108f9 simplify the simpelist api slightly so not every struct member needs to be init manually. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15236 a1c6a512-1295-4272-9138-f99709370657
 2007-10-21 01:27:17 +00:00
Jonathan Gordon
5f893be2a3 add a list API for simple lists which dont need lots of code to run. 
Example uses in debug_menu.c
This API works best if most of the text is static, or not many actions 
need to acted on. (of course, any list could use this)



git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15221 a1c6a512-1295-4272-9138-f99709370657
 2007-10-20 12:32:55 +00:00
Michael Sevakis
a9b2fb5ee3 Finally full multicore support for PortalPlayer 502x targets with an eye towards the possibility of other types. All SVN targets the low-lag code to speed up blocking operations. Most files are modified here simple due to a name change to actually support a real event object and a param change to create_thread. Add some use of new features but just sit on things for a bit and leave full integration for later. Work will continue on to address size on sensitive targets and simplify things if possible. Any PP target having problems with SWP can easily be changed to sw corelocks with one #define change in config.h though only PP5020 has shown an issue and seems to work without any difficulties. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15134 a1c6a512-1295-4272-9138-f99709370657
 2007-10-16 01:25:17 +00:00
Michael Sevakis
6077e5b7c8 Unify PCM interface just above the hardware driver level for all targets including the sims. Perform lockout of audio callback when changing states. Weird new playback or recording trouble? Check before and after this revision first though things seem quite sound. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15006 a1c6a512-1295-4272-9138-f99709370657
 2007-10-06 22:27:27 +00:00
Michael Sevakis
7914e90738 Commit a subset of the dual core changes that have to do with cache handling, stacks, firmware startup and thread startup. Tested on e200, H10-20GB, iPod Color and 5.5G. Thread function return implemented for all targets. Some changes to plugins to follow shortly. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14879 a1c6a512-1295-4272-9138-f99709370657
 2007-09-28 10:20:02 +00:00
Jonathan Gordon
cf1cef5f57 minor update to gui_synclist_do_button() which will hopefully simplify things later. 
Now returns true if the action was handled in that function instead of returning the handled action.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14733 a1c6a512-1295-4272-9138-f99709370657
 2007-09-17 10:08:50 +00:00
Michael Sevakis
f64ebb1c1f Sim I/O and threading that runs more like on target. Tweakable if any genuine slowness imitation is required for any one of them. One point of concern is the sim shutdown on an OS other than Linux just because terminating threads in a manner other than having the do it themselves is kind of dirty IMHO. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14639 a1c6a512-1295-4272-9138-f99709370657
 2007-09-08 12:20:53 +00:00
Mark Arigo
dbc6b4e39a Sansa c200 port. Rockbox works with sound. Several features are disabled including some lcd options, FM radio, recording, and all plugins. Loading the OF from the Rockbox bootloader does not work. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14625 a1c6a512-1295-4272-9138-f99709370657
 2007-09-06 03:28:58 +00:00
Jens Arnold
bef4c24f39 H10 ADC values are 10 bit, hence we need 3 hex digits. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14431 a1c6a512-1295-4272-9138-f99709370657
 2007-08-22 20:43:47 +00:00
Peter D'Hoye
f94c5c6b3b H10: make all ADC values fit on the debug screen of the 5GB 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14416 a1c6a512-1295-4272-9138-f99709370657
 2007-08-21 21:57:00 +00:00
Jens Arnold
1d1d9a8491 Switch to using millivolt for battery voltage and other internal voltages. * Fix debug voltage history display. * Some code cleanup. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14364 a1c6a512-1295-4272-9138-f99709370657
 2007-08-15 23:57:27 +00:00
Jens Arnold
7d80ebd3a3 I supposed to show DEV_EN on PP502x.... 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14167 a1c6a512-1295-4272-9138-f99709370657
 2007-08-03 20:03:40 +00:00
Jens Arnold
e3ec22b607 Updated & added some PP register debug stuff. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14166 a1c6a512-1295-4272-9138-f99709370657
 2007-08-03 19:20:29 +00:00
Jens Arnold
604e44d0e2 iPod 1st..3rd gen: Fix CPU scaling instability on PP5002 * Add some new info to pp5002.h and sort it by port address. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14053 a1c6a512-1295-4272-9138-f99709370657
 2007-07-29 07:50:34 +00:00
Jens Arnold
794c968430 Make 'View HW Info' work on PP5002 targets and move clock estimation there. * Shorter way to write the wait for userabort. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14031 a1c6a512-1295-4272-9138-f99709370657
 2007-07-27 22:34:15 +00:00
Jens Arnold
9382e55415 Preparations for iPod G1 and G2. Does not even compile properly yet. * Sorted target cases in configure by menu number. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14016 a1c6a512-1295-4272-9138-f99709370657
 2007-07-26 22:42:31 +00:00
Dave Chapman
ebc076bc15 Remove the hack which read the ipod hardware revision from flash in the bootloader and passed it to Rockbox via a fixed address in SDRAM. Rockbox now remaps flash and so can just read the value itself. Also clean up the debug menu a little - only display the hw revision for ipods, and add the lcd_type variable to indicate the type of LCD (0 or 1) for ipod Color/Photo. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13986 a1c6a512-1295-4272-9138-f99709370657
 2007-07-25 13:12:38 +00:00
Michael Sevakis
ea0d2cf7d6 Some rewriting of the e200 ata driver. No more panicing. Faster card multiplexing. Some calculated yielding (further tuneable if needed). Hopefully more reliable in general. Easy revert if rebellious. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13976 a1c6a512-1295-4272-9138-f99709370657
 2007-07-25 06:15:07 +00:00
Jonathan Gordon
f7675a244b remove the need for action_signalscreenchange(). 
Fixes problems with targets where the ACTION_STD_CANCEL event is a combo


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13956 a1c6a512-1295-4272-9138-f99709370657
 2007-07-22 06:05:53 +00:00
Jens Arnold
66bb96b4f3 Make the audio thread debug screen leavable on H10 (and potentially other targets where ACTION_STD_CANCEL is a two-part acion). 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13933 a1c6a512-1295-4272-9138-f99709370657
 2007-07-19 23:40:28 +00:00
Michael Sevakis
e9d62762e5 Fix yellow. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13909 a1c6a512-1295-4272-9138-f99709370657
 2007-07-15 18:40:15 +00:00
Michael Sevakis
a16035d3dd Hopefully get the rest of the quirks out of the debug menus and save some size too. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13908 a1c6a512-1295-4272-9138-f99709370657
 2007-07-15 18:25:39 +00:00
Michael Sevakis
dc051248be e200: Tuner driver needs to yield alot and also be mutexed. FM debug screen got broken again and was ignoring cancellation and not drawing the lines. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13896 a1c6a512-1295-4272-9138-f99709370657
 2007-07-14 22:00:50 +00:00
Jonathan Gordon
e2014a9794 unused param 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13890 a1c6a512-1295-4272-9138-f99709370657
 2007-07-14 15:11:44 +00:00
Jonathan Gordon
7d04c81887 minor update to the debug screens to handle dynamic screens a bit better. And so there is no need to manually call the callback before enetering dbg_list() 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13889 a1c6a512-1295-4272-9138-f99709370657
 2007-07-14 15:08:46 +00:00
Jonathan Gordon
b41cde58bf fix radio screen 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13887 a1c6a512-1295-4272-9138-f99709370657
 2007-07-14 14:58:28 +00:00
Jonathan Gordon
4259eb1ed9 make the radio debug screen auto-update 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13886 a1c6a512-1295-4272-9138-f99709370657
 2007-07-14 14:52:06 +00:00
Robert Keevil
227a733e42 Fix typo in the debug disk info screen 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13882 a1c6a512-1295-4272-9138-f99709370657
 2007-07-14 12:32:37 +00:00
Michael Sevakis
7d759f6b9c Do some planned radio interface cleanup since adding in the LV24020LP. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13880 a1c6a512-1295-4272-9138-f99709370657
 2007-07-14 11:20:31 +00:00
Jonathan Gordon
5890f60137 Fix radio screen, and use the actual card type name for the title in the disk screen on ondio and sansa 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13877 a1c6a512-1295-4272-9138-f99709370657
 2007-07-14 08:55:47 +00:00
Jonathan Gordon
d7dd23939a convert the disk info debug screen to a list. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13863 a1c6a512-1295-4272-9138-f99709370657
 2007-07-12 09:58:54 +00:00
Jonathan Gordon
ed4df23e98 convert the tagcache, database and radio debug screens to nice lists 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13853 a1c6a512-1295-4272-9138-f99709370657
 2007-07-11 13:27:15 +00:00
Jonathan Gordon
f115804694 make the debug menu nice and fast 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13852 a1c6a512-1295-4272-9138-f99709370657
 2007-07-11 07:54:10 +00:00
Jens Arnold
85568d6040 iPod G3: Clock setup register display and CPU clock estimation in debug menu. * Fix clock being set to only half of what it should be (introduced with clock setup changes for PP502x). 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13844 a1c6a512-1295-4272-9138-f99709370657
 2007-07-10 20:47:01 +00:00
Jens Arnold
1cf80c3c95 Improved clock estimation in debug menu. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13811 a1c6a512-1295-4272-9138-f99709370657
 2007-07-07 05:59:35 +00:00
Jens Arnold
7b861eca95 More PP502x clock setup rework. This should fix the freezes on PP5020 once and for all. Enabled clock scaling for H10. * CPUFREQ_MAX changed to 78MHz * To be cleaned up soon. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13767 a1c6a512-1295-4272-9138-f99709370657
 2007-07-03 00:42:42 +00:00
Jens Arnold
fe23dc8f15 Improved CPU clock setup for PP502x. PP5020 and PP5022 are not register compatible here, so define the PP5022 targets properly, and introduce a CPU_PP502x macro for easier family check. Improves stability on PP5020 (less freezing, tested with Mini G1) and reduces clock change penalty (500us on PP5020; uses the relock bit on PP5022). 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13763 a1c6a512-1295-4272-9138-f99709370657
 2007-07-02 05:16:40 +00:00
Michael Sevakis
1167e3c72f Accept FS#7134 - Sansa: external sd card support by Antonius Hellmann with some tweaks. All testers have given the green light. (Now for the RED ?? ;). 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13741 a1c6a512-1295-4272-9138-f99709370657
 2007-06-30 02:08:27 +00:00
Michael Sevakis
7fb0f71668 Gigabeat: Replace generic i2c driver with one that uses the CPU's builtin controller. Add some clocking registers to 'View I/O ports'. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13720 a1c6a512-1295-4272-9138-f99709370657
 2007-06-26 02:11:30 +00:00
Michael Sevakis
2d48d0ffa6 Straighten out some audio path APIs and misc. audio stuff. Having recording is not a prerequisite to having input/output source selection which is probably most useful when adding a audio input features like FM to a new port without forcing recording to be implemented first. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13599 a1c6a512-1295-4272-9138-f99709370657
 2007-06-08 23:42:04 +00:00
Jonathan Gordon
3823486a58 Add a mode the lists which doesnt show the selection marker. 
Useful for the debug menus where users shouldn't think pressing select would do anything.



git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13588 a1c6a512-1295-4272-9138-f99709370657
 2007-06-07 12:14:31 +00:00
Michael Sevakis
21a4a87ca2 Accept FS#7178 - Sansa e200 FM tuner support by Ivan Zupan. Do the needed integration work into recording and the AS3514 audio driver. Do a little AS3514 fiq_record tweak to have it all work nicely from the start. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13573 a1c6a512-1295-4272-9138-f99709370657
 2007-06-06 19:23:48 +00:00
Steve Bavin
21d538b98e Fix for unlikely, but possible, division-by-zero 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13385 a1c6a512-1295-4272-9138-f99709370657
 2007-05-14 09:56:55 +00:00
Dave Chapman
f02cba8096 Code cleaning - remove some unnecessary defined(SIMULATOR) checks 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13369 a1c6a512-1295-4272-9138-f99709370657
 2007-05-10 13:16:08 +00:00
Karl Kurbjun
173b611921 Basic gigabeat buttonlight support outside of debug menu FS#7112. Also disables USB PLL and the USB device clock (uneeded to connect to computer) - May offer some power savings. Changed how some pins are initialized. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13346 a1c6a512-1295-4272-9138-f99709370657
 2007-05-07 19:34:34 +00:00
Jonathan Gordon
507345000d these should be static 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13288 a1c6a512-1295-4272-9138-f99709370657
 2007-04-29 23:26:26 +00:00
Jonathan Gordon
39a6b5d643 Stop using the old menu API in the debug menu (using the new api causes massive bin increase, so fake the old api with existing code instead) (onplay.c and plugins are the only parts using th eold api now) 
Fix a bug where the menu title was sometimes shown in the system font


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13286 a1c6a512-1295-4272-9138-f99709370657
 2007-04-29 15:31:43 +00:00
Karl Kurbjun
335de0b043 Clean up that warning and pull out an unneeded #ifdef 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13226 a1c6a512-1295-4272-9138-f99709370657
 2007-04-21 05:07:18 +00:00
Karl Kurbjun
8a1fd8c686 Commit FS#6929 - Gigabeat bootloader improvements by Barry Wardell and myself. This build fixes the problems seen with the latest builds on the Gigabeat X. Added View IO Ports under the Debug menu for the Gigabeat. Make sure you grab the latest bootloader from the Wiki as the old bootloader will not work properly with new builds. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13225 a1c6a512-1295-4272-9138-f99709370657
 2007-04-21 04:48:20 +00:00
Jens Arnold
8636e6949e Moved SH1 system code to target tree. * First shot at hwcompat cleanup. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13114 a1c6a512-1295-4272-9138-f99709370657
 2007-04-11 23:51:00 +00:00
Jens Arnold
d6e822cab9 Get rid of some old archos debug cruft (USB polarity, PR polarity and ATA address are all derived from the hw mask, and master/slave isn't displayed on other targets either). * Get rid of all the USB*STYLE macros (except USB_IPODSTYLE). 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13112 a1c6a512-1295-4272-9138-f99709370657
 2007-04-11 21:26:58 +00:00
Jonathan Gordon
21b415df56 Give all menus using the old API a nice title and icons (except plugins) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13068 a1c6a512-1295-4272-9138-f99709370657
 2007-04-08 05:52:47 +00:00
Jens Arnold
f9b90e9103 Now charcell displays require lcd_update() for updating the main lcd content like bitmap displays. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13050 a1c6a512-1295-4272-9138-f99709370657
 2007-04-06 22:55:00 +00:00
Jonathan Gordon
78585318b5 count was set wrong for the parititons screen. imo this is a bug in the list code, but quick fix untill a proper one 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13031 a1c6a512-1295-4272-9138-f99709370657
 2007-04-05 05:18:47 +00:00
Jonathan Gordon
d88db1fc12 Fix sim warning 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13030 a1c6a512-1295-4272-9138-f99709370657
 2007-04-05 05:01:38 +00:00
Jonathan Gordon
cd41bfa52e Make the partitions debug screen use the list also. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13029 a1c6a512-1295-4272-9138-f99709370657
 2007-04-05 04:52:53 +00:00
Miika Pekkarinen
b4a2d6a06a Killing of threads enabled also for logf debug builds. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12947 a1c6a512-1295-4272-9138-f99709370657
 2007-03-28 07:33:40 +00:00
Miika Pekkarinen
a289324e30 Ability to kill threads in debug screen by pressing select. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12945 a1c6a512-1295-4272-9138-f99709370657
 2007-03-28 06:36:34 +00:00
Miika Pekkarinen
66258a30a4 Make scheduler functions thread safe core wise. A big step towards playback running on COP (not yet possible because more protection on file system level is necessary). 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12926 a1c6a512-1295-4272-9138-f99709370657
 2007-03-26 16:55:17 +00:00
Jonathan Gordon
cd1ccad9d6 Make the OS stacks usage debug screen nicer, and unfiy the code for charcell/bmp lcds 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12921 a1c6a512-1295-4272-9138-f99709370657
 2007-03-26 12:09:08 +00:00
Jens Arnold
85a226d4e7 Rename some macros to account for the recently added M5 port. No code changes. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12809 a1c6a512-1295-4272-9138-f99709370657
 2007-03-16 23:02:39 +00:00
Jens Arnold
4d6374c923 Get rid of the 'center' parameter for splashes. There were only 2 of almost 500 splashes which were not centered. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12807 a1c6a512-1295-4272-9138-f99709370657
 2007-03-16 21:56:08 +00:00
Michael Sevakis
a2ee6a6681 FM Radio mishmash: Make a quieter screen for the SWCODEC targets esp. for the benefit of x5; I wasn't sure if it was good to alter timeouts for HW codec. Simplify things and prepare for eventual scanning and tuning changes (which should help quiet x5 down even more). Make things behave themselves better in general. Enable SWCODEC FM Recording menu and screen for sim as a bonus. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12804 a1c6a512-1295-4272-9138-f99709370657
 2007-03-16 14:40:40 +00:00
Barry Wardell
7f4f9aead7 Improved ADC driver for AS3514 (used in PP5024 - ie. Sansa e200) based off datasheet. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12745 a1c6a512-1295-4272-9138-f99709370657
 2007-03-13 01:50:13 +00:00
Michael Sevakis
c7954a0bec Clean up the debug menu serial number display code a bit and save a few bytes. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12725 a1c6a512-1295-4272-9138-f99709370657
 2007-03-11 15:33:59 +00:00
Michael Sevakis
89a38d4273 iAudio X5: Enable reading of DS2411 serial number. See it under System|Debug|View HW info. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12723 a1c6a512-1295-4272-9138-f99709370657
 2007-03-11 13:59:31 +00:00
Jens Arnold
8d0cd9f303 Some more M5 adjustments. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12616 a1c6a512-1295-4272-9138-f99709370657
 2007-03-05 01:31:26 +00:00
Jens Arnold
8876018d25 Bring up the M5 port to a working stage: Extended numerous explicit checks for IAUDIO_X5 to also check for IAUDIO_M5, moved code around the target tree, added preliminary background for the sim. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12610 a1c6a512-1295-4272-9138-f99709370657
 2007-03-05 00:04:00 +00:00
Barry Wardell
38b64f7b4b Get rid of C99 style variable declaration. Also, add one more use of #define instead of inl/outl that I missed last time. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12591 a1c6a512-1295-4272-9138-f99709370657
 2007-03-04 16:06:54 +00:00
Barry Wardell
169ebdbda7 Some more replacing of inl/outl with register #define's (doesn't change end-result binary). Add lots more #define's based on the ipodlinux wiki and some extrapolation. 
Also add PortalPlayer SoC version to the HW info debug screen.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12575 a1c6a512-1295-4272-9138-f99709370657
 2007-03-03 23:37:17 +00:00
Jonathan Gordon
8ca99d3288 Code Police: Remove tabs throught apps/ . Hopefully no actual code 
change


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12504 a1c6a512-1295-4272-9138-f99709370657
 2007-02-27 11:09:09 +00:00
Dave Chapman
d39b6ea1dc Ooops #2 - fix sim builds. The dbg_save_roms function will work on all PP targets apart from the Sansa. Using CPU_PP prevents attempted compilation in the sim. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12469 a1c6a512-1295-4272-9138-f99709370657
 2007-02-23 23:44:59 +00:00
Dave Chapman
9467eeafe3 Ooops. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12468 a1c6a512-1295-4272-9138-f99709370657
 2007-02-23 23:25:50 +00:00
Dave Chapman
fda1498696 Remap flash ROM to 0x20000000 on the ipods and H10s, and implement dbg_save_roms() in the debug menu for those targets to dump the content to a file. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12467 a1c6a512-1295-4272-9138-f99709370657
 2007-02-23 23:22:03 +00:00
Jonathan Gordon
9a6f419775 CONFIG_CHARGING 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12384 a1c6a512-1295-4272-9138-f99709370657
 2007-02-18 05:32:06 +00:00
Jonathan Gordon
8ff3a653bd Explicilty set CONFIG_ defines to 0 which are not used.. because doing 
#if defined(BLAA) && BLAA == something defeats the point of Wundef


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12378 a1c6a512-1295-4272-9138-f99709370657
 2007-02-18 02:04:47 +00:00
Daniel Stenberg
20a5926d2e build with -Wundef to make sure we have spelled the defines right in #if lines 
and have the proper includes included etc


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12360 a1c6a512-1295-4272-9138-f99709370657
 2007-02-17 21:54:17 +00:00
Steve Bavin
608e53d10f Remove H300 GPOODx debugging; it was using the wrong port addresses anyway 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12206 a1c6a512-1295-4272-9138-f99709370657
 2007-02-05 13:08:08 +00:00
Jens Arnold
67eb154146 Removed 'mode' parameter from creat(). It wasn't pure posix anyway, it was ignored on target and mixed into 'oflags' in the simulator. * Simplified io.c a bit by defining a dummy O_BINARY for OSes which don't have that. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12179 a1c6a512-1295-4272-9138-f99709370657
 2007-02-01 23:08:15 +00:00
Steve Bavin
338d94f466 FS#4770 - Add USB charging for the H300 series 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12169 a1c6a512-1295-4272-9138-f99709370657
 2007-02-01 10:47:22 +00:00
Jonathan Gordon
228d62dd18 Split the system status variables out of global_settings and put them into a new struct global_status. Use status_save() if these need 
saving.
Added car_adapter_mode to the nvram settings, so nvram settings will be reset.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12101 a1c6a512-1295-4272-9138-f99709370657
 2007-01-24 02:19:22 +00:00
Jonathan Gordon
f8c68c7912 Simple cpu boost tracker for LOGF builds. Shows the last 64 cpu_boost() calls from the debug menu 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12087 a1c6a512-1295-4272-9138-f99709370657
 2007-01-22 10:41:25 +00:00
Steve Bavin
991b2eefe9 Remove another tagcache reference from the UI 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11982 a1c6a512-1295-4272-9138-f99709370657
 2007-01-11 09:18:05 +00:00
Steve Gotthardt
93b047fffe Updated buttonlights for the Gigabeat port. Added LCD controller off and on for extra power savings - thanks to Greg White. Incorporated feedback from Gary Allen. Added 'battery charging' mode: shows leds during charging. Added 'follow' mode that turns off leds when backlight goes off. Flicker mode and new solid mode only show during disk access. Access settings from Info/debug menu for now. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11945 a1c6a512-1295-4272-9138-f99709370657
 2007-01-08 08:53:36 +00:00
Steve Gotthardt
c07814fce1 Revamped the backlight state machine and added buttonlight controls. Go to the Info/debug menu and test out the new modes for buttonlights on the Gigabeat - ON, OFF, Faint, and flicker - flickers on touchpad and disk reads. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11935 a1c6a512-1295-4272-9138-f99709370657
 2007-01-07 06:38:57 +00:00
Greg White
922c0d6d33 Fix simulator build 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11910 a1c6a512-1295-4272-9138-f99709370657
 2007-01-04 12:13:56 +00:00
Greg White
82c7757633 Add option to toggle LCD popwer off, gigabeat only 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11907 a1c6a512-1295-4272-9138-f99709370657
 2007-01-04 11:44:32 +00:00
Jonathan Gordon
acf73af2e8 Go back to the old button code for the debug ports screen so its usable 
again. (FS#6087, the first comment)


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11847 a1c6a512-1295-4272-9138-f99709370657
 2006-12-27 07:20:42 +00:00
Brandon Low
da7d05d5ad Make debug menu compile without priority scheduling and with multicore 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11838 a1c6a512-1295-4272-9138-f99709370657
 2006-12-25 15:44:35 +00:00
Jonathan Gordon
d152b6492a update the runtime screen and move it to the inf menu instead of debug 
menu


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11817 a1c6a512-1295-4272-9138-f99709370657
 2006-12-19 12:26:03 +00:00
Jens Arnold
314f3b58f1 More static'ing, and a few fixes resulting from that. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11737 a1c6a512-1295-4272-9138-f99709370657
 2006-12-12 22:22:21 +00:00
Miika Pekkarinen
c5d57f0aae Removed the cpu boost tracking debug feature for now because of 
different kind of problems. Better implementation can be done later.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11665 a1c6a512-1295-4272-9138-f99709370657
 2006-12-05 20:01:48 +00:00
Jens Arnold
31ffd7b154 Completed target tree move of the ata driver code. Some code cleanup. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11655 a1c6a512-1295-4272-9138-f99709370657
 2006-12-03 22:13:44 +00:00
Daniel Ankers
844d22f277 Allow GPIO debug screen on Sansa. Also remove a warning from the NAND driver 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11593 a1c6a512-1295-4272-9138-f99709370657
 2006-11-25 15:57:07 +00:00
Daniel Ankers
242cbd5cd7 Change if CONFIG_CPU==PP50XX to ifdef CPU_PP where appropriate 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11569 a1c6a512-1295-4272-9138-f99709370657
 2006-11-22 00:41:30 +00:00
Jonathan Gordon
6288523cfe * Move checkbox to plugin api (core never uses it) 
* replace the last of the scrollbar() calls with gui_scrollbar_draw()


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11552 a1c6a512-1295-4272-9138-f99709370657
 2006-11-19 14:11:42 +00:00
Michael Sevakis
cc50c149e9 H100/General: HAL for S/PDIF and refinement/bufixes in optical output powering/source selection. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11523 a1c6a512-1295-4272-9138-f99709370657
 2006-11-13 23:21:54 +00:00
Jens Arnold
780f79e7a4 Removed the Gmini 120 and Gmini SP code. These ports are dead, unfortunately. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11504 a1c6a512-1295-4272-9138-f99709370657
 2006-11-10 20:26:01 +00:00
Steve Bavin
3ad89d26d0 Restore CPU default frequency when boosting cancelled in debug menu 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11411 a1c6a512-1295-4272-9138-f99709370657
 2006-11-01 11:12:21 +00:00
Michael Sevakis
9e8fe0e4c6 General: changed local adc to voltage conversions in several places to use battery_voltage. Added battery_read_info function for unfiltered battery information. x5: removed adc_read as a distinct function. Removed adc tick task. adc_init is empty inline. Adjusted battery scale, voltage to level array and read 10 bits from the ADC for battery since 255 levels is not enough for true centivolt resolution. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11396 a1c6a512-1295-4272-9138-f99709370657
 2006-10-30 11:33:38 +00:00
Jens Arnold
85c9a05c56 H300: Don't read the button ADC as long as no button is pressed, utilising the PCF50606 accessory detect feature. Ported from X5. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11383 a1c6a512-1295-4272-9138-f99709370657
 2006-10-29 13:48:57 +00:00
Michael Sevakis
c4a0d45d36 Cleanup of new button reading code. Moved functions for enabling of scanning and the decision to scan or not to button_read_device. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11377 a1c6a512-1295-4272-9138-f99709370657
 2006-10-28 23:10:45 +00:00
Michael Sevakis
1d4a9c6366 Stop reading buttons if one is not down. Don't read remote keys if not plugged. Good for another few points of boost and 4fps full-screen unboosted. The button scan enabling seems stable and I've been using it without any difficulties but if the interrupts hiccup it could leave them unresponsive. Clearing the GPI0 interrupts before enabling them seems to prevent any difficulties. If there's problems there I'll just leave the remote reading bypass only and 50% of the benefits will still be realized. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11357 a1c6a512-1295-4272-9138-f99709370657
 2006-10-27 05:31:28 +00:00
Barry Wardell
d4dfe957f2 Oops. Missed part of FS#6235 in the last commmit 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11356 a1c6a512-1295-4272-9138-f99709370657
 2006-10-27 02:22:48 +00:00
Barry Wardell
e52d9610b5 Accept FS#6235. We should be using the *_ATTR defines instead of __attribute__ 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11355 a1c6a512-1295-4272-9138-f99709370657
 2006-10-27 02:09:35 +00:00
Daniel Ankers
6dfd6bd8c1 Enable I/O ports debug menu for 3G iPods 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11346 a1c6a512-1295-4272-9138-f99709370657
 2006-10-25 18:34:59 +00:00
Jonathan Gordon
710ccb7b48 ifdef all the tagcache code, allows rombox to be compiled again, Thanks Austin Appel 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11338 a1c6a512-1295-4272-9138-f99709370657
 2006-10-25 10:17:57 +00:00
Barry Wardell
73c0cfa632 Make the UI simulator compile on OSX again. dbg_flash_id() really shouldn't be compiled for the sim anyway. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11328 a1c6a512-1295-4272-9138-f99709370657
 2006-10-25 00:54:06 +00:00
Jens Arnold
450f619dcf Ondios: Slightly more verbose MMC info. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11225 a1c6a512-1295-4272-9138-f99709370657
 2006-10-15 11:51:56 +00:00
Steve Bavin
73e2f7bd6b Minor simplification #2; replace unneeded variable filebufused with a macro 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11201 a1c6a512-1295-4272-9138-f99709370657
 2006-10-12 16:51:22 +00:00
Steve Bavin
d49c810ec9 Add CPU boost tracker to see where boosts are coming from 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11125 a1c6a512-1295-4272-9138-f99709370657
 2006-10-05 10:07:03 +00:00
Steve Bavin
5db6bb1caf Oops 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11121 a1c6a512-1295-4272-9138-f99709370657
 2006-10-04 07:42:45 +00:00
Steve Bavin
2c2b50a458 Add (some of the) debug menu to sims 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11120 a1c6a512-1295-4272-9138-f99709370657
 2006-10-04 07:29:50 +00:00
Barry Wardell
b692fb11b3 Add support for H10 remote. Remote buttons have the same keymappings as their counterparts on the H10 itself, with vol-/vol+ being the same as scroll up/down. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11093 a1c6a512-1295-4272-9138-f99709370657
 2006-09-29 15:59:08 +00:00
Barry Wardell
d9fe5a77b0 Adjust PP5020 I/O Ports debug menu so that it will fit on the H10 5GB screen. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11092 a1c6a512-1295-4272-9138-f99709370657
 2006-09-29 12:20:04 +00:00
Barry Wardell
5a79b4e015 Add ADC to I/O ports debug menu on H10. Fix battery level reading empty when starting up on H10. Calibrated battery for H10 20GB. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11036 a1c6a512-1295-4272-9138-f99709370657
 2006-09-23 17:47:54 +00:00
Peter D'Hoye
1f760b8db4 battery_viewer: prevent div by zero if power_history highest and lowest values are identical 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10961 a1c6a512-1295-4272-9138-f99709370657
 2006-09-16 19:35:28 +00:00
Miika Pekkarinen
610190a04e Fixed the errors. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10959 a1c6a512-1295-4272-9138-f99709370657
 2006-09-16 16:33:42 +00:00
Miika Pekkarinen
a85044bf9e New scheduler, with priorities for swcodec platforms. Frequent task 
switching should be more efficient and tasks are stored in linked
lists to eliminate unnecessary task switching to improve performance.
Audio should no longer skip on swcodec targets caused by too CPU
hungry UI thread or background threads.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10958 a1c6a512-1295-4272-9138-f99709370657
 2006-09-16 16:18:11 +00:00
Miika Pekkarinen
8aa6180e92 Fixed the errors. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10854 a1c6a512-1295-4272-9138-f99709370657
 2006-09-02 08:14:52 +00:00
Miika Pekkarinen
3686228f9d Cleanup threads.c by moving declarations inside structs. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10853 a1c6a512-1295-4272-9138-f99709370657
 2006-09-02 07:56:52 +00:00
Daniel Ankers
c1e454508e Save a few bytes on non-Portalplayer builds 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10831 a1c6a512-1295-4272-9138-f99709370657
 2006-08-31 20:19:18 +00:00
Daniel Ankers
5076c84723 Oops - fix warnings for Player 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10682 a1c6a512-1295-4272-9138-f99709370657
 2006-08-21 17:49:57 +00:00
Daniel Ankers
0aec12f3fd Threading changes in preparation for multiple core support 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10681 a1c6a512-1295-4272-9138-f99709370657
 2006-08-21 17:35:35 +00:00
Marcoen Hirschberg
f59a37d3e8 fix gigabeat simulator build 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10674 a1c6a512-1295-4272-9138-f99709370657
 2006-08-21 12:21:16 +00:00
Peter D'Hoye
3b44ec9b0a Oops... small changes catch most errors 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10618 a1c6a512-1295-4272-9138-f99709370657
 2006-08-16 18:57:34 +00:00
Peter D'Hoye
6a8f06f6cb Show a splash on successful eeprom write to let the user know something happened and it went well 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10617 a1c6a512-1295-4272-9138-f99709370657
 2006-08-16 18:56:08 +00:00
Hristo Kovachev
1dc62dfc6b Okay, use µs instead of us 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10607 a1c6a512-1295-4272-9138-f99709370657
 2006-08-16 09:15:40 +00:00
Hristo Kovachev
340de14c0e Fix the stupid text editor's silliness and use "us" for microsec 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10605 a1c6a512-1295-4272-9138-f99709370657
 2006-08-16 07:02:46 +00:00
Jonathan Gordon
475be662a7 put the timeouts back the way they were (sorry amiconn) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10603 a1c6a512-1295-4272-9138-f99709370657
 2006-08-16 04:27:33 +00:00
Peter D'Hoye
c4a59a290b eeprom driver for the h3x0 series, cleaned up the h1x0 series driver a bit, added debug entry for h3x0 that allows to write to the eeprom 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10597 a1c6a512-1295-4272-9138-f99709370657
 2006-08-15 22:54:06 +00:00
Linus Nielsen Feltzing
6d97f6d949 Removed a warning 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10585 a1c6a512-1295-4272-9138-f99709370657
 2006-08-15 12:56:26 +00:00
Linus Nielsen Feltzing
224c0a13eb Finally, the new button action system is here, thanks to Jonathan Gordon. Some button mappings have changed and other things may break. Comments should go to the forum, http://forums.rockbox.org/index.php?topic=5829.0 or the mailing list. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10582 a1c6a512-1295-4272-9138-f99709370657
 2006-08-15 12:27:07 +00:00
Rani Hod
d159ae54b6 support for more detailed FM radio debug info and for X5 flash debug 
info.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10530 a1c6a512-1295-4272-9138-f99709370657
 2006-08-11 17:39:34 +00:00
Peter D'Hoye
5375e26e51 eeprom dump in debug screen: fix return value check 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10467 a1c6a512-1295-4272-9138-f99709370657
 2006-08-06 21:48:59 +00:00
Miika Pekkarinen
954b732654 Initial support and use for EEPROM memory on H120 & H140 players when 
Rockbox firmware has been flashed over original firmware (not yet
possible to do). Dircache & tagcache serialization for fast bootup
without the need to scan disk when Rockbox is in flash.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10464 a1c6a512-1295-4272-9138-f99709370657
 2006-08-05 20:19:10 +00:00
Miika Pekkarinen
cb8c795415 Support importing runtimedb data from ascii files. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10260 a1c6a512-1295-4272-9138-f99709370657
 2006-07-20 12:19:31 +00:00
Jens Arnold
0dd1f8ec11 Work-in-progress rework of charging status reading & display: * Changed several charging related HAVE_* macros into one multi-value CONFIG_CHARGING. * Always use proper macros for charging states. * Battery symbol charging animation now starts from current level on all targets with charging. Two-colour animation kept for non-b&w targets. Round down fill level while charging as before, but round to nearest pixel value for discharging on all targets. * Charging anim fixed on player. * Some code cleanup. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10080 a1c6a512-1295-4272-9138-f99709370657
 2006-06-06 22:23:52 +00:00