Andree Buschmann
05778b501d
Fix further tabs
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24156 a1c6a512-1295-4272-9138-f99709370657
2010-01-03 10:50:34 +00:00
Michael Giacomelli
ce8640d7b8
Second part of FS#10832 by Juliusz Chroboczek. Ignore empty mdat chunks in mp4 files.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24148 a1c6a512-1295-4272-9138-f99709370657
2010-01-02 21:02:13 +00:00
Michael Giacomelli
008c368c87
Commit first part of FS#10832 by Juliusz Chroboczek. Allows playback of unstreamable AAC/ALAC files by stepping through the file to find the index, potientially rebuffering. This is likely to impose a battery life hit on files which are unstreamable and not much smaller then the buffer, but should not impact streamable files at all.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24147 a1c6a512-1295-4272-9138-f99709370657
2010-01-02 20:54:55 +00:00
Magnus Holmgren
6b6463c8b7
Add support for the MP4 file type 'isom'. Based on FS#10790 with an additional fix, making the sample file play. Also updated some debug prints.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23708 a1c6a512-1295-4272-9138-f99709370657
2009-11-22 16:37:36 +00:00
Nils Wallménius
2e28c1853b
Unify fourcc macro and some style changes
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23664 a1c6a512-1295-4272-9138-f99709370657
2009-11-18 17:30:42 +00:00
Nils Wallménius
556daaf34a
Make svn properties consistent and set some missing ones
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23663 a1c6a512-1295-4272-9138-f99709370657
2009-11-18 16:59:34 +00:00
Mohamed Tarek
e0d8202599
Revert r23339 and use setid3v1title() from metadata/mp3.c instead.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23349 a1c6a512-1295-4272-9138-f99709370657
2009-10-25 18:11:55 +00:00
Mohamed Tarek
027e7634bf
Add support for ID3v1 metadta tags in Real Media container.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23339 a1c6a512-1295-4272-9138-f99709370657
2009-10-24 23:53:01 +00:00
Marcoen Hirschberg
c48af23c7e
add gapless playback for Nero encoded AAC files
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22984 a1c6a512-1295-4272-9138-f99709370657
2009-10-06 13:47:12 +00:00
Marcoen Hirschberg
f3e5ced844
add gapless support for MP3 files encoded with iTunes
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22872 a1c6a512-1295-4272-9138-f99709370657
2009-10-02 09:14:17 +00:00
Marcoen Hirschberg
500bdda4f2
add support for comments in ID3v2.2
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22868 a1c6a512-1295-4272-9138-f99709370657
2009-10-01 11:50:06 +00:00
Michael Giacomelli
ad9835c689
Logic was backwards on the check for NSF file format. Fix that and save one memcmp.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22559 a1c6a512-1295-4272-9138-f99709370657
2009-08-30 03:52:11 +00:00
Michael Giacomelli
f701fc5166
Patch doesn't SVN add . . .
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22558 a1c6a512-1295-4272-9138-f99709370657
2009-08-30 03:15:43 +00:00
Michael Giacomelli
e4c30bdf0e
Accept FS#10570 by Jason Yu. Adds metadata parsing for NSF files.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22557 a1c6a512-1295-4272-9138-f99709370657
2009-08-30 02:53:15 +00:00
Mohamed Tarek
685628cf18
Support for playback of atrac3 audio in rm, in sim.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22311 a1c6a512-1295-4272-9138-f99709370657
2009-08-14 17:36:57 +00:00
Mohamed Tarek
466b2ae248
Factor out bytestream reading functions needed in rm parsers/codecs.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22308 a1c6a512-1295-4272-9138-f99709370657
2009-08-14 15:13:14 +00:00
Mohamed Tarek
e63f1ecb97
Fix yellow.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22239 a1c6a512-1295-4272-9138-f99709370657
2009-08-10 19:53:10 +00:00
Boris Gjenero
7f971e0176
Fix FS#10476. Prevent FLAC bitrate calculation overflow with large files. The watermark depends on the bitrate, and so this also fixes playback pauses on large FLAC files.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22211 a1c6a512-1295-4272-9138-f99709370657
2009-08-08 20:27:03 +00:00
Mohamed Tarek
cc68b632cb
Add a couple of functions for the rm metadata parser for debugging, and add a comment to codecs/a52_rm.c to indicate the source of the decode
...
function.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22182 a1c6a512-1295-4272-9138-f99709370657
2009-08-06 05:45:54 +00:00
Mohamed Tarek
26cee86a0c
Add support for AC3 audio in RM container.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22155 a1c6a512-1295-4272-9138-f99709370657
2009-08-04 13:54:06 +00:00
Maurus Cuelenaere
1ace06a67d
Metadata parser: make adjust_mp3entry() not depend on id3_is_genre_string(), so there's no need to compare the string to the whole genre array (thanks to Mikael Magnusson)
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22105 a1c6a512-1295-4272-9138-f99709370657
2009-08-01 19:52:54 +00:00
Maurus Cuelenaere
faf37f9d21
MP3 metadata parser:
...
* Use ARRAYLEN()
* id3_is_genre_string(): loop over the whole array instead of comparing a pointer to the first and last item of an array of pointers (fixes crash on Onda VX747)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22104 a1c6a512-1295-4272-9138-f99709370657
2009-08-01 19:37:09 +00:00
Mohamed Tarek
c08a2c7c53
Change enum codecs in apps/codecs/librm/rm.h to follow the coding guidelines.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22067 a1c6a512-1295-4272-9138-f99709370657
2009-07-27 12:29:06 +00:00
Mohamed Tarek
5f5d105755
Change the naming scheme for codecs found in different containers.
...
Like changing AFMT_AAC to AFMT_MP4_AAC and AFMT_RAAC to AFMT_RM_AAC.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22066 a1c6a512-1295-4272-9138-f99709370657
2009-07-27 12:13:22 +00:00
Mohamed Tarek
fe1568a11c
Fix yellow - (Value in an enumeration not handled in a switch).
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22032 a1c6a512-1295-4272-9138-f99709370657
2009-07-25 15:54:05 +00:00
Mohamed Tarek
b8cccb5ae1
Adding support for playback of aac audio in rm container, with seeking.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22031 a1c6a512-1295-4272-9138-f99709370657
2009-07-25 15:47:13 +00:00
Mohamed Tarek
6f4294219e
Generic codec-extradata parsing, in preparation for addition of AAC/RM.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21941 a1c6a512-1295-4272-9138-f99709370657
2009-07-18 00:29:19 +00:00
Nils Wallménius
3d4701a6e4
FS#10080
...
* Move strncpy() from core to the pluginlib
* Introduce strlcpy() and use that instead in most places (use memcpy in a few) in core and some plugins
* Drop strncpy() from the codec api as no codec used it
* Bump codec and plugin api versions
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21863 a1c6a512-1295-4272-9138-f99709370657
2009-07-14 13:57:45 +00:00
Mohamed Tarek
ff7c0cd7c5
Silence warnings to fix yellows for now.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21810 a1c6a512-1295-4272-9138-f99709370657
2009-07-12 15:11:22 +00:00
Mohamed Tarek
6258e24e0e
Some fixes for the standalone test program.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21807 a1c6a512-1295-4272-9138-f99709370657
2009-07-12 14:43:24 +00:00
Maurus Cuelenaere
851b0e3234
Try at fixing 'cast to/from pointer to/from integer of different size' warnings
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21719 a1c6a512-1295-4272-9138-f99709370657
2009-07-08 17:18:59 +00:00
Maurus Cuelenaere
3c338766d1
RM metadata parser: fix unaligned access
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21716 a1c6a512-1295-4272-9138-f99709370657
2009-07-08 15:00:00 +00:00
Mohamed Tarek
e184ef1027
Adding support for rm playback. Only cook codec is supported for now and no seeking.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21695 a1c6a512-1295-4272-9138-f99709370657
2009-07-06 22:40:45 +00:00
Thomas Martitz
659425f23e
Redo r21460 and r21462 so that it doesn't introduce a new #define. Patch by Jeffrey Goode, taken from FS#10366.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21467 a1c6a512-1295-4272-9138-f99709370657
2009-06-22 18:40:49 +00:00
Thomas Martitz
78914f3833
FS#10364 - Optional debug output for vorbis.c by Jeffrey Goode.
...
Gets rid of the (recently added) annyoing vorbis debug statements. Comment out "#define LOGF_ENABLE" in vorbis.c to restore them.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21460 a1c6a512-1295-4272-9138-f99709370657
2009-06-21 21:59:16 +00:00
Magnus Holmgren
0b495f0a18
Improved Vorbis comment reader. The tags no longer need to fit in the first Ogg page to be fully read (album art can make the tags not fit).
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21134 a1c6a512-1295-4272-9138-f99709370657
2009-05-30 14:24:16 +00:00
Mohamed Tarek
b68707d465
Add read_uint8() and read_uint16be() to metadata_common.c/h
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20968 a1c6a512-1295-4272-9138-f99709370657
2009-05-16 19:05:50 +00:00
Andrew Mahone
fd7002ae6c
Attempt to fix yellow on sims (can't reproduce on my system).
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20954 a1c6a512-1295-4272-9138-f99709370657
2009-05-16 02:06:22 +00:00
Dave Chapman
da3dc455f6
Change the type of read_uint32be to uint32_t and ensure all variables passed to that function are also of that type. No functional changes, but makes read_uint32be consistent with the other read_* functions and prevents warning in the upcoming RealAudio metadata parser.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20950 a1c6a512-1295-4272-9138-f99709370657
2009-05-15 22:45:03 +00:00
Robert Keevil
4f47b38938
Fix reading of Musicbrainz track IDs from ID3 tags - incorrect return values resulted in these tags being partially overwritten
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20719 a1c6a512-1295-4272-9138-f99709370657
2009-04-16 23:10:45 +00:00
Nils Wallménius
5a55772201
Small code reuse improvement
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19943 a1c6a512-1295-4272-9138-f99709370657
2009-02-08 11:09:55 +00:00
Magnus Holmgren
c54ddbd78c
MP4/AAC: Add support for album artist tags written by Foobar2000. Closes FS#9723.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19669 a1c6a512-1295-4272-9138-f99709370657
2009-01-04 17:41:17 +00:00
Magnus Holmgren
5a00367a08
Fix FS#9522: stop reading an ID3v2 tag if a frame length is bad.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19005 a1c6a512-1295-4272-9138-f99709370657
2008-11-04 19:47:52 +00:00
Magnus Holmgren
ee378abe63
Add support for the album artist field used by Foobar2000 in ID3v2 tags.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18935 a1c6a512-1295-4272-9138-f99709370657
2008-10-30 19:00:24 +00:00
Bertrik Sikken
92683778f6
Add missing #include to mp3 metadata parser.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18885 a1c6a512-1295-4272-9138-f99709370657
2008-10-26 13:07:29 +00:00
Björn Stenberg
51b45d5602
Split id3.c/h into metadata.c/h and metadata/mp3.c. Updated all references. Moved mp3data.c/h from firmware to apps.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18814 a1c6a512-1295-4272-9138-f99709370657
2008-10-15 06:38:51 +00:00
Robert Keevil
2c170356f3
FS#9139 - support for ver 1.1 scrobbler log files. Upload any old files first - uploading software may need updating, see the LastFMLog wiki page
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18732 a1c6a512-1295-4272-9138-f99709370657
2008-10-07 18:39:44 +00:00
Nils Wallménius
1121af7b5e
Print a helpful error in the sim for usupported formats in Ogg containers (f.e. Ogg/FLAC)
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18623 a1c6a512-1295-4272-9138-f99709370657
2008-09-24 17:43:10 +00:00
Dominik Wenger
9b7566e3ec
asap: fix stereo mode and hopefully fix metadata handling.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18140 a1c6a512-1295-4272-9138-f99709370657
2008-07-28 19:20:40 +00:00
Dave Chapman
0d2254f478
SAP codec: Ensure the module_info struct is correctly aligned - seems to fix the data aborts being reported on ARM targets (closes FS#9216).
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18126 a1c6a512-1295-4272-9138-f99709370657
2008-07-27 10:49:43 +00:00