Commit graph

28787 commits

Author SHA1 Message Date
Michael Hohmuth
8207a4a267 FS#12132 patch 8: retrieve_entries: Decrease binsize by reenabling
inlining format_str() and avoiding a string copy by printing directly
into the name buffer.

Also uses quite a bit less stack space.

En passant, made basename printing more robust by not limiting the
buffer into which the file pathname is fetched by the max size of the
resulting basename string.  Also, fixed a potential buffer overrun in
format_str.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30248 a1c6a512-1295-4272-9138-f99709370657
2011-08-04 10:23:18 +00:00
Michael Hohmuth
e7c2449d07 Database: Fix array-bounds calculation when applying a format using
%strip to partially loaded (chunked) database results.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30247 a1c6a512-1295-4272-9138-f99709370657
2011-08-04 10:21:52 +00:00
Michael Hohmuth
4cb473562e Database: Fix memory-area bounds checking during database reload.
Check free space before reading new data from disk, and do not forget
to account for the RAM-cache header.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30246 a1c6a512-1295-4272-9138-f99709370657
2011-08-04 10:21:40 +00:00
Thomas Martitz
95c1e7d8b0 Fix oops in r30242. I didn't want to change/reduce the buffer size.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30244 a1c6a512-1295-4272-9138-f99709370657
2011-08-03 10:39:46 +00:00
Thomas Martitz
589879bb3d Plugin API/ABI got incompatible r30242. Bump and sort.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30243 a1c6a512-1295-4272-9138-f99709370657
2011-08-03 09:52:23 +00:00
Thomas Martitz
98096970e0 Cleanup tree.c cache handling a bit.
* Rename stuff to not re-use the term dircache
 * Move cache to own struct
 * Encapsulate retrieving entries a bit

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30242 a1c6a512-1295-4272-9138-f99709370657
2011-08-03 09:49:25 +00:00
Michael Hohmuth
fa5cf8edea Database: Fix to support case-sensitive file systems containing audio
files with names differing only in capitalization.  Thanks to Slasheri
for the fix.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30241 a1c6a512-1295-4272-9138-f99709370657
2011-08-02 22:10:06 +00:00
Andree Buschmann
7155be6ca4 Sync rockbox to r475 of musepack's svn.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30240 a1c6a512-1295-4272-9138-f99709370657
2011-08-02 19:08:29 +00:00
Thomas Martitz
7bbd7daaf7 Tagcache: Rename global static variable for better readability.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30239 a1c6a512-1295-4272-9138-f99709370657
2011-08-02 14:35:10 +00:00
Frank Gevaerts
68e066f400 #ifdef hell makes effectively suppressing this warning impossible, so stop trying
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30238 a1c6a512-1295-4272-9138-f99709370657
2011-08-01 20:21:34 +00:00
Frank Gevaerts
038a608bb7 Move the "warning suppression" down, so it comes after the last write to "remote", to ensure better warning avoidance
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30237 a1c6a512-1295-4272-9138-f99709370657
2011-08-01 20:13:43 +00:00
Frank Gevaerts
bd3056cb38 Suppress a "variable 'remote' set but not used" warning that some gcc versions (rightly) emit for the m:robe 100 sim. The "correct" solution would be to add about twenty five more #ifdefs to a function that already has way too many of them, or to rewrite the entire function.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30236 a1c6a512-1295-4272-9138-f99709370657
2011-08-01 20:07:05 +00:00
Frank Gevaerts
00c0221800 Make scrobbler_flush_cache() static
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30235 a1c6a512-1295-4272-9138-f99709370657
2011-08-01 19:43:13 +00:00
Michael Giacomelli
9d8866c7c2 Mention that MSC mode is reset after installing rockbox on AMS players.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30234 a1c6a512-1295-4272-9138-f99709370657
2011-08-01 18:10:42 +00:00
Thomas Martitz
86724a205d Remove dead rolo related code (boot_changed was never set to true).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30233 a1c6a512-1295-4272-9138-f99709370657
2011-08-01 13:03:21 +00:00
Frank Gevaerts
94b4a8bb9a revert r30226, which is apparently broken.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30232 a1c6a512-1295-4272-9138-f99709370657
2011-08-01 08:38:32 +00:00
Michael Hohmuth
935d3d717f FS#12132 patch 7: Add a new default format for untagged tracks:
Display the file's base name instead of "<Untagged>".

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30231 a1c6a512-1295-4272-9138-f99709370657
2011-07-31 16:26:39 +00:00
Michael Hohmuth
eab7e74778 FS#12132 patch 6, part 2: tagnavi.config: Add support for "basename"
in formats and conditions.  The basename is the non-directory part of
a file's pathname.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30230 a1c6a512-1295-4272-9138-f99709370657
2011-07-31 16:26:35 +00:00
Michael Hohmuth
accea18ded FS#12132 patch 6, part 1: tagnavi.config: Add support for string
truncation in tagnavi %formats using the standard
"%{width}.{truncation}s" format syntax.

String truncation is especially useful when using part of a string
tag, filename, or basename for sorting and %strip'ing.  (Basename
support is forthcoming in a subsequent commit.)

Also renovated the format_str() code a bit (improved structuring,
removed code duplication) and increased the maximum length of a printf
conversion specification to 20 characters.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30229 a1c6a512-1295-4272-9138-f99709370657
2011-07-31 16:26:31 +00:00
Frank Gevaerts
936494f9c5 Lower the maximum brightness of the fuzev2 backlight even more.
The previous maximum (20) still causes excessive heat for some people, and measurements (using a digital camera and a white screen) show that the maximum brightness in the OF corresponds to 12 in rockbox, so we use 12 now.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30227 a1c6a512-1295-4272-9138-f99709370657
2011-07-31 15:30:07 +00:00
Frank Gevaerts
92b392e722 Reload the current playlist after reboot even if it has ended. (FS#11644)
This is done to make reboot more transparent. If a playlist has ended, there should be no difference between the player doing nothing for ten minutes and the player shutting down after the idle timeout and being restarted.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30226 a1c6a512-1295-4272-9138-f99709370657
2011-07-31 12:56:00 +00:00
Thomas Martitz
ffded5fcf8 Move AFMT_MPA_L1 down in the enum as hwcodec can't play it.
Fixes a NULL-pointer derefence in probe_file_format().

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30225 a1c6a512-1295-4272-9138-f99709370657
2011-07-31 11:42:50 +00:00
Thomas Martitz
32b54164d8 Dircache: Fix 2 nasty bugs introduced with the reworks starting with r30032.
The first is an off-by-one that leads to miscalculation of the dircache size.
The format string size was used but dircache size was incremented by the snprintf() result which is smaller.
The other forgot to update the location of the "." and ".." strings upon compaction,
so that new folders got assigned orphaned pointers for those directory entires.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30224 a1c6a512-1295-4272-9138-f99709370657
2011-07-30 23:21:58 +00:00
Bertrik Sikken
564b696500 FS#12210 - Bulgarian translation update by Vencislav Atanasov
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30223 a1c6a512-1295-4272-9138-f99709370657
2011-07-29 19:13:52 +00:00
Jonas Häggqvist
8fcb752304 New language: Basque by Asier Arsuaga (FS#12205)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30221 a1c6a512-1295-4272-9138-f99709370657
2011-07-28 16:04:20 +00:00
Michael Giacomelli
55c77e229e Fix a bug introduced in r27463 that caused the line spectral pair look up tables to overwrite the noise coding VLC tables. Should fix decoding of files that have both noise coding and line spectral pairs, which are usually very low bitrate WMAs.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30220 a1c6a512-1295-4272-9138-f99709370657
2011-07-28 14:12:33 +00:00
Jonathan Gordon
969903b5fe Change the way the %Tl() (touch region) tag is done to remove dodgey 1-char settings.
check the manual...
%Tl(..., &action) -> %Tl(..., action, repeat_press)
%Tl(..., *action) -> %Tl(..., action, long_press)
%Tl(..., !action) -> %Tl(..., action, reverse_bar)
and a new allow_while_lock to make the region fire when softlocked

these options must all be after the action name, but otherwise the order doesnt matter. And for the setting_inc/dec/set action the setting name must follow the action name, *then* the options

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30219 a1c6a512-1295-4272-9138-f99709370657
2011-07-28 12:53:22 +00:00
Jonathan Gordon
bb618dbd84 skin engine softlock support for touchscreens:
Modify the %Tl() tag to add a new region 'lock' which will lock/unlock the wps/sbs from touches (hardware buttons still work)
You can also specify a region to work when locked by prepending ^ to the action name (this is probably about to change though)

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30218 a1c6a512-1295-4272-9138-f99709370657
2011-07-28 11:26:01 +00:00
Bertrik Sikken
b9f3230273 FS#12200 - July update of Czech language by Marek Salaba
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30217 a1c6a512-1295-4272-9138-f99709370657
2011-07-27 17:17:15 +00:00
Michael Giacomelli
ab759daf5b Explain in more detail what the precut option for EQ does, and also mention that it requires EQ to be enabled to use it.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30216 a1c6a512-1295-4272-9138-f99709370657
2011-07-27 16:02:43 +00:00
Dominik Riebeling
1ec180803a Show cluster size in System Info dialog.
Enlarge the default size of the dialog to something more reasonable for the
extended information displayed.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30215 a1c6a512-1295-4272-9138-f99709370657
2011-07-26 20:54:49 +00:00
Dominik Riebeling
743308e882 Take cluster size into account when calculating zip extracted size.
Allow passing an (optional) cluster size to round up all file sizes when
calculating the total size of an extracted zip archive. This allows to check if
the space on disk is actually sufficient without relying on an arbitrary
headroom value which might be wrong. Addresses FS#12195.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30214 a1c6a512-1295-4272-9138-f99709370657
2011-07-26 20:54:44 +00:00
Bertrik Sikken
3bb0fed345 FS#12198 - Romanian translation update by Sergiu Rotaru
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30213 a1c6a512-1295-4272-9138-f99709370657
2011-07-26 17:37:21 +00:00
Alessio Lenzi
d9bad6eaac Updated italian translation.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30212 a1c6a512-1295-4272-9138-f99709370657
2011-07-25 20:11:43 +00:00
Bertrik Sikken
7210d04603 battery bench: fix redundant '#' in the battery bench instruction header
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30211 a1c6a512-1295-4272-9138-f99709370657
2011-07-25 18:52:09 +00:00
Andree Buschmann
5dfc343a24 Submit FS#12196. Adds support for embedded album art (jpg) with APEv2 tags.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30210 a1c6a512-1295-4272-9138-f99709370657
2011-07-25 10:37:51 +00:00
Michael Giacomelli
62d666df6f Convert AMSv2 microphone samples from 14 to 16 bit before storing them.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30209 a1c6a512-1295-4272-9138-f99709370657
2011-07-25 01:00:15 +00:00
Michael Giacomelli
c27ea297a3 Commit FS#12111 by Stephan Grossklass. Disables output mixer auto gain control on AMSv2. Should fix occasional distortion reported when running the player at very high output levels (e.g. at or above 0dB).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30208 a1c6a512-1295-4272-9138-f99709370657
2011-07-24 21:56:24 +00:00
Amaury Pouly
855e3c6f0f imx233/fuze+: implement lcd_blit_yuv (untested)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30207 a1c6a512-1295-4272-9138-f99709370657
2011-07-24 19:12:27 +00:00
Amaury Pouly
1df8072c08 imx233/fuze+: cleanup sd code
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30206 a1c6a512-1295-4272-9138-f99709370657
2011-07-24 19:12:23 +00:00
Amaury Pouly
de13803352 sbtools: fix version output, add support for options section and product/component versions in command files
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30205 a1c6a512-1295-4272-9138-f99709370657
2011-07-24 19:12:18 +00:00
Bertrik Sikken
0157c62418 ipod nano 1g: enable readout of battery current through ADC channel 4066_ISTAT
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30204 a1c6a512-1295-4272-9138-f99709370657
2011-07-24 17:32:50 +00:00
Andree Buschmann
10a1e8a609 Fix musepack resume for resume positions > 7:30m.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30202 a1c6a512-1295-4272-9138-f99709370657
2011-07-23 20:56:53 +00:00
Amaury Pouly
fa0f17d9b0 imx233/fuze+: move page table to dram
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30201 a1c6a512-1295-4272-9138-f99709370657
2011-07-23 13:48:01 +00:00
Amaury Pouly
eb90d95693 imx233/fuze+: huge rework
- enable MMU
-rework lcd frame buffer
- add rtc/adc/power stubs (or not)
- fix a few MMC related defines (hopefully)
- implement cache handling for DMA
- more SD work
- add keymap (based on clip)
- add virtual buttons
- update linker scripts
- big step toward apps actually compiling

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30200 a1c6a512-1295-4272-9138-f99709370657
2011-07-23 11:45:22 +00:00
Amaury Pouly
06c94740e5 imx233/fuze+: prepare target to enable MMU
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30199 a1c6a512-1295-4272-9138-f99709370657
2011-07-23 11:45:18 +00:00
Amaury Pouly
3f8bf5e041 imx233/fuze+: fix memory size and appextra configuration
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30198 a1c6a512-1295-4272-9138-f99709370657
2011-07-23 11:45:03 +00:00
Amaury Pouly
82f70b8efd imx233/fuze+: add SD detection support
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30196 a1c6a512-1295-4272-9138-f99709370657
2011-07-22 15:45:58 +00:00
Amaury Pouly
85c32dbd12 imx233/fuze+: add pin irq support
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30195 a1c6a512-1295-4272-9138-f99709370657
2011-07-22 15:45:50 +00:00
Amaury Pouly
7d1d4c6f07 imx233/fuze+: implement gpio interrupts
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30194 a1c6a512-1295-4272-9138-f99709370657
2011-07-22 15:45:46 +00:00