strcpy() will terminate the string with zero,
the boot sector/buffer has only space for eight characters.
Credit goes to "cppcheck".
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30351 a1c6a512-1295-4272-9138-f99709370657
Enlarge the default size of the dialog to something more reasonable for the
extended information displayed.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30215 a1c6a512-1295-4272-9138-f99709370657
Allow passing an (optional) cluster size to round up all file sizes when
calculating the total size of an extracted zip archive. This allows to check if
the space on disk is actually sufficient without relying on an arbitrary
headroom value which might be wrong. Addresses FS#12195.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30214 a1c6a512-1295-4272-9138-f99709370657
On OS X Configure and Quit menu entries are not placed in the File menu. Qt
handles that for us if they are not translated, and translations are then
handled automatically (as well as setting the OS X specific accelerator keys).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30147 a1c6a512-1295-4272-9138-f99709370657
Those functions are rather general, so put them into the Utils class instead.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30146 a1c6a512-1295-4272-9138-f99709370657
Make sure to convert it on reading to avoid not finding it even if stored with
native separators in the configuration. Fix a warning on Windows.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30145 a1c6a512-1295-4272-9138-f99709370657
The delegate will be used for the dropdown list and show both mountpoint (left
aligned) and label / size information (right aligned). This improves
readability compared to the previous implementation. Also, the mountpoint
itself is now the text of the combo box and the additional information is in
the Qt::UserRole to avoid having to handle a user entered mountpoint separately
(since previously the mountpoint was stored in Qt::UserRole, but an edited item
would have the value in Qt::TextRole).
Disable editing the combo box entry for release builds, it shouldn't be needed
by users.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30144 a1c6a512-1295-4272-9138-f99709370657
When its possible to retrieve the label of the selected mountpoint display it
in the main window too. Right now this only affects Windows.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30143 a1c6a512-1295-4272-9138-f99709370657
With the rework of the mountpoint selection the tree browser isn't used
anymore.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30142 a1c6a512-1295-4272-9138-f99709370657
In mountpoint selection and system info dialog show the volume name to make it
easier to identify a specific device.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30141 a1c6a512-1295-4272-9138-f99709370657
Instead of entering the mountpoint via a tree browser or manually use a combo
box that lists all available drives / mountpoints. This also allows to easily
add more information like the free and total size for each mountpoint. For
development this can still be overriden by editing the dropdown value manually.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30140 a1c6a512-1295-4272-9138-f99709370657
This should help identifying the correct player by size, since the free space
is only useful to figure if there is enough space to install Rockbox. Change
units to GiB since that is more useful given the size of current devices.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30139 a1c6a512-1295-4272-9138-f99709370657
The proxy settings are stored as string representation in the configuration
file. If username / password contains characters used as separators parsing the
string again will cause wrong results. Percent-encode them before storing, and
parse it as percent-encoded string when reading it back.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30071 a1c6a512-1295-4272-9138-f99709370657
The "file" bootloader installation method usually can uninstall the bootloader.
Some upgrade methods (like the Iaudio players) remove the bootloader file
placed on the player after upgrading so those can't uninstall the bootloader.
Instead of rejecting uninstallation for all players using this method check the
current bootloader and only display an error if no suitable bootloader is
found (which would happen in the Iaudio case).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30070 a1c6a512-1295-4272-9138-f99709370657
In order to enable it, #define HAVE_DUALBOOT when building the bootloader.
Do not use the automatically created x5_fw.bin or m5_fw.bin, but use mkboot
to create a new firmware file from an OF x5_fw.bin resp. m5_fw.bin and
bootloader.bin.
The dual-boot bootloader boots the OF when pressing Play (main or remote) for
more than 3 seconds. Hold it a bit longer because the OF also checks buttons.
Short press boots rockbox.
As a bonus, the Play button read (for hold check) is done a bit earlier for
single-boot mode as well.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30018 a1c6a512-1295-4272-9138-f99709370657
Introduce a new folder that will hold the original files for various variants
of the Rockbox logo. The "Rb" variant of the icon (used in the Rockbox Utility
icon on Windows) has been missing from svn.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29960 a1c6a512-1295-4272-9138-f99709370657
Extend sapi_voice.vbs with slovak (FS#10904). Additionally add it to the list
of supported languages in Rockbox Utility and fix the country code used for
slovenscina (by myself).
Author: Peter Lecky
Flyspray: FS#10904
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29830 a1c6a512-1295-4272-9138-f99709370657
Add support for passing and injecting a build ID to the souces prior to
compiling. Allows to easily create rebuilds of Rockbox Utility without creating
false positives on update detection.
Fix a typo in version.h. Thanks to sideral for noting.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29825 a1c6a512-1295-4272-9138-f99709370657
The purpose of this is to allow versioning of builds. This is useful when a new
build is made to fix problems with the build itself that haven't been noticed
earlier (like the accessibility issue reported as FS#12089) as it will avoid
false positives for the update check.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29824 a1c6a512-1295-4272-9138-f99709370657
The regexp used when displaying the names didn't take into account that names
could start with non-ASCII letters. Use a different approach when filtering the
header to make them not disappear.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29803 a1c6a512-1295-4272-9138-f99709370657
Run lupdate on all other translation files as well and drop obsolete strings.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29795 a1c6a512-1295-4272-9138-f99709370657
The settings currently can't differentiate between default values for different
subitems (i.e. different TTS systems). As a result the default value returned
for SAPI speed was way out of bounds, leading to the upper limit getting used.
Work around this limitation by checking the value for bounds and use a sensible
value in that case.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29763 a1c6a512-1295-4272-9138-f99709370657
Since setting the maximum number of threads to use to 1 causes sporadically
files missing add a simple alternative implementation that doesn't use futures.
This is a stop-gap solution to fix voice files not creating (reported on
Windows with SAPI voices, see FS#11994). Encoding doesn't seem to be affected
by the problem and is unchanged.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29762 a1c6a512-1295-4272-9138-f99709370657
To have a better indication what player has been detected and to keep this
information in view make the entry for the detected player bold. This also
(partly) addresses FS#10694.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29761 a1c6a512-1295-4272-9138-f99709370657
Make sure the temporary file doesn't get destroyed before it has been played.
Fixes the "Test TTS" button not giving a test playback anymore for TTS systems
that cannot do the playback themselves.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29760 a1c6a512-1295-4272-9138-f99709370657
If no TTS has been selected previously default to the system one if any.
Otherwise use espeak.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29758 a1c6a512-1295-4272-9138-f99709370657
The configuration dialog isn't needed anymore once the finished() signal is
emitted. In that case schedule it for deletion by the event loop.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29674 a1c6a512-1295-4272-9138-f99709370657
The current TTS configuration doesn't allow querying the system values so it
currently can't be displayed. A value of 0 will use the system default. The
default pitch is dependent on the voice; most voices should have a default
pitch of 45 - 55.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29673 a1c6a512-1295-4272-9138-f99709370657
The OS X TTS engine (and likely others) allows outputting its speech directly
to the sound system. This avoids the extra step of creating a temporary file to
play for TTS preview. Currently implemented as TTS capability reported.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29672 a1c6a512-1295-4272-9138-f99709370657
Instead of hard coding the query part of the genlang url store the full url as
template and replace parts as done for other urls as well.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29669 a1c6a512-1295-4272-9138-f99709370657
This change fixes problems with zip files created with newer zip utilities (a
known issue is the iLike theme). QuaZip also allows better feedback during
operations without changing the imported code. Additionally Rockbox Utility and
the Theme Editor are now both using QuaZip; currently Rockbox Utility uses a
copy of the sources, merging them later is planned.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29645 a1c6a512-1295-4272-9138-f99709370657
Autodetection only showed an MTP device error for e200v1 and an unspecified
error for all other players (except if the detected player is an Ipod, in which
case the error indicates a WinPod). Consider all non-Ipod errors as MTP error.
Fix wrong MTP USB ID for e200v1 which made that detection fail even for e200v1.
Should fix FS#11563.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29621 a1c6a512-1295-4272-9138-f99709370657
