Commit graph

209 commits

Author SHA1 Message Date
Alexander Levin
7d4c0c5e7e Rename functions so that the code is easier to read
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27313 a1c6a512-1295-4272-9138-f99709370657
2010-07-06 16:53:52 +00:00
Jonathan Gordon
edf06dc0b2 a few more HAVE_PICTUREFLOW_INTEGRATION
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26717 a1c6a512-1295-4272-9138-f99709370657
2010-06-09 09:00:42 +00:00
Jonathan Gordon
10e24d22c4 rename HAVE_PICTUREFLOW to HAVE_PICTUREFLOW_INTEGRATION to make it more clear what it is needed for
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26716 a1c6a512-1295-4272-9138-f99709370657
2010-06-09 08:51:29 +00:00
Jonathan Gordon
881a5b9759 reclaim most of the delta from the pictureflow commit
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26715 a1c6a512-1295-4272-9138-f99709370657
2010-06-09 08:14:41 +00:00
Jonathan Gordon
d871ff8cce FS#11270 by Chris Savery - WPS integration for pictureflow
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26710 a1c6a512-1295-4272-9138-f99709370657
2010-06-09 04:25:41 +00:00
Alexander Levin
c79bc8006d No need to have a variable for a thing computed by the preprocessor
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25956 a1c6a512-1295-4272-9138-f99709370657
2010-05-11 17:10:07 +00:00
Jeffrey Goode
aaa07970ee Fix yellow
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25951 a1c6a512-1295-4272-9138-f99709370657
2010-05-11 13:50:39 +00:00
Jeffrey Goode
e141f80e11 Add Insert Shuffled to hotkey options
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25950 a1c6a512-1295-4272-9138-f99709370657
2010-05-11 13:40:25 +00:00
Jeffrey Goode
156272fced More hotkey code cleanup
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25942 a1c6a512-1295-4272-9138-f99709370657
2010-05-11 04:41:15 +00:00
Jeffrey Goode
1ad76ff25b FS#11250: Hotkey setting method changed to menu item vs button pres in context menu. Manuals updated to match.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25905 a1c6a512-1295-4272-9138-f99709370657
2010-05-09 02:02:51 +00:00
Jeffrey Goode
16e0c5730d Hotkey menu items have their own icon
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25866 a1c6a512-1295-4272-9138-f99709370657
2010-05-07 03:21:12 +00:00
Thomas Martitz
50a6ca39ad Move c/h files implementing/defining standard library stuff into a new libc directory, also standard'ify some parts of the code base (almost entirely #include fixes).
This is to a) to cleanup firmware/common and firmware/include a bit, but also b) for Rockbox as an application which should use the host system's c library and headers, separating makes it easy to exclude our files from the build.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25850 a1c6a512-1295-4272-9138-f99709370657
2010-05-06 21:04:40 +00:00
Thomas Martitz
c61e89c0ed Make creat() posix compliant API-wise. Shouldn't affect the core as it's wrapped via a static inline.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25843 a1c6a512-1295-4272-9138-f99709370657
2010-05-06 17:35:04 +00:00
Alexander Levin
bfd53beda4 Mark const return value; correct the comment about valid menu items for the hotkey
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25607 a1c6a512-1295-4272-9138-f99709370657
2010-04-12 16:44:02 +00:00
Jeffrey Goode
7d5b23e1f1 Small hotkey code changes for readability
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25589 a1c6a512-1295-4272-9138-f99709370657
2010-04-11 13:17:23 +00:00
Jeffrey Goode
ef30d7ef71 FS#11195, plus. Simplified hotkey struct, thanks alle!
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25581 a1c6a512-1295-4272-9138-f99709370657
2010-04-11 00:32:16 +00:00
Alexander Levin
4779456c3f Fix typos in comments
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25574 a1c6a512-1295-4272-9138-f99709370657
2010-04-10 20:31:01 +00:00
Alexander Levin
31959e78d0 Use better names for hotkey related constants; add somecomments (FS#11191)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25570 a1c6a512-1295-4272-9138-f99709370657
2010-04-10 19:43:47 +00:00
Jeffrey Goode
7be582b5f5 Fix data abort due to malformed switch code. My bad.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25537 a1c6a512-1295-4272-9138-f99709370657
2010-04-08 14:34:14 +00:00
Jeffrey Goode
accc046cbd Hotkey: better settings handling, fewer saved variables, localizable hotkey info list
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25529 a1c6a512-1295-4272-9138-f99709370657
2010-04-08 01:43:50 +00:00
Alexander Levin
ba7501513a No need to call the same function twice
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25458 a1c6a512-1295-4272-9138-f99709370657
2010-04-03 21:28:19 +00:00
Alexander Levin
8802482e3e Make hotkey strings (question and confirmation) better localizable (FS#11171)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25457 a1c6a512-1295-4272-9138-f99709370657
2010-04-03 20:59:35 +00:00
Jeffrey Goode
d5e6bc7a8c FS#11081 - Hotkey patch. Many targets supported, but some keymaps need work before they can be switched on
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25414 a1c6a512-1295-4272-9138-f99709370657
2010-04-01 03:14:44 +00:00
Teruaki Kawashima
993376cb67 FS#11017: add Playlist Catalog and Properties item to database's context menu.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24804 a1c6a512-1295-4272-9138-f99709370657
2010-02-21 12:01:14 +00:00
Thomas Martitz
c19e53654b Playlist Viewer Changes to bring consistency:
- combine its two context menus to one and
- make the ACTION_STD_MENU go to the main menu as it does in all other screens
- call playlist_viewer() via root_menu to reduce call depth and to be consistent with other screens (and for the above changes to be more flexible w.r.t to the following screen)

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24791 a1c6a512-1295-4272-9138-f99709370657
2010-02-20 19:06:39 +00:00
Teruaki Kawashima
9bea349382 onplay.c: optimize a little bit.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24666 a1c6a512-1295-4272-9138-f99709370657
2010-02-15 13:04:09 +00:00
Teruaki Kawashima
f884068c6e onplay: move functions to a bit more logical order; some functions, some menu items which use the functions and then a callback function.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24646 a1c6a512-1295-4272-9138-f99709370657
2010-02-14 12:42:32 +00:00
Jonathan Gordon
eee5423fe1 skin rework (FS#10922) notable changes:
- simplify the setting/skin relationship. settings are used as the fallback if it's not specified in the skin
- backdrop buffers are now in the skin buffer (which has also increased slightly to accomodate 1 backdrop for each skin and 2 full colour screens for bmps (up for 1.5))
- if no %X is specified in a skin then the backdrop setting will be used. use %Xd to explicitly disable a skin from displaying a backdrop
- the base skin can now specify a backdrop.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24366 a1c6a512-1295-4272-9138-f99709370657
2010-01-29 07:52:13 +00:00
Bertrik Sikken
5c4ef78cc9 Simplify some expressions using the ? operator
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24136 a1c6a512-1295-4272-9138-f99709370657
2010-01-01 22:47:25 +00:00
Mohamed Tarek
e35a15cf54 Make the delete_handler function return the actual result, instead of just 'false'.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24135 a1c6a512-1295-4272-9138-f99709370657
2010-01-01 21:23:17 +00:00
Jonathan Gordon
74d1c31baf Fix FS#10433 - "Play Next" should use the "warn on playlist change" setting like the rest of the options that erase the playlist
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24064 a1c6a512-1295-4272-9138-f99709370657
2009-12-18 05:53:29 +00:00
Jonathan Gordon
7c440bff32 remove 3 bad viewport functions:
* viewport_set_current_vp() because if a screen wants to not use the user setting it shouldn't be dealing with the viewport manager at all (other than to disable the bars)
* viewport_ui_vp_get_state() is unused (and not needed)
* viewport_get_current_vp() because you should be using set_defaults() instead.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23606 a1c6a512-1295-4272-9138-f99709370657
2009-11-11 06:39:23 +00:00
Jeffrey Goode
59dd433ccd Removed unneeded includes
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23578 a1c6a512-1295-4272-9138-f99709370657
2009-11-09 05:46:08 +00:00
Teruaki Kawashima
30faf032ad Show insert_last_shuffled item and queue_last_shuffled item when playlist file is selected.
break long lines.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23464 a1c6a512-1295-4272-9138-f99709370657
2009-11-01 14:25:38 +00:00
Dave Hooper
494fd9673d Committing FS#10717 by Tomasz Kowalyczyk: add PLAYLIST_INSERT_LAST_SHUFFLED (appends the inserted folder into shuffled order to end of playlist)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23385 a1c6a512-1295-4272-9138-f99709370657
2009-10-28 22:27:38 +00:00
Thomas Martitz
6bc092db0e Change the "Rename failed" message to a splash.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22472 a1c6a512-1295-4272-9138-f99709370657
2009-08-23 15:22:50 +00:00
Thomas Martitz
595a828e0d Bound the progress slider into the currently used viewport (which should be the ui viewport at virtually any time).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22471 a1c6a512-1295-4272-9138-f99709370657
2009-08-23 15:06:11 +00:00
Thomas Martitz
4764ee04c9 Add backdrop functions to the multiscreen api and add a enum backdrop_type parameter for different backdrops (main, wps), symplifying calls and removing dozens of #ifdefs (stubs added for non-backdrop displays that can't do backdrops).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22176 a1c6a512-1295-4272-9138-f99709370657
2009-08-06 00:14:40 +00:00
Jonathan Gordon
24b136f62d rework cuesheet support:
swcodec: search for a .cue during buffering (with the possibility of adding embedded cuesheets later)
hwcodec: search for a .cue when the id3 info for the current track is requested for the first time (disk should be spining so non issue)

major beenfit from this is simplofy cuesheet handling code a bit... if mp3entry.cuesheet != NULL then there is a valid cuesheet.. no need to worry about if its enabled and preloaded.
There is the possibility of putting the next/prev subtrack handling inside the playback code (as well as the id3 updating stuff (see FS#9789 for more info), but thats probably not a good idea.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21978 a1c6a512-1295-4272-9138-f99709370657
2009-07-20 05:18:18 +00:00
Nils Wallménius
3d4701a6e4 FS#10080
* Move strncpy() from core to the pluginlib
* Introduce strlcpy() and use that instead in most places (use memcpy in a few) in core and some plugins
* Drop strncpy() from the codec api as no codec used it
* Bump codec and plugin api versions


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21863 a1c6a512-1295-4272-9138-f99709370657
2009-07-14 13:57:45 +00:00
Bertrik Sikken
09085a30f6 Remove unneeded #include "backdrop.h"
Remove unneeded #include "statusbar.h"


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20891 a1c6a512-1295-4272-9138-f99709370657
2009-05-09 18:09:14 +00:00
Thomas Martitz
87d1744e91 Fix playlist "Insert" a bit.
If insert was used to create a new playlist (e.g. inserting without audio playing), the insert position wasn't updated. Thus, the playlist created was in reversed order (except for the first song).
This was the reason "Insert last" was actually used as Insert in this case. BUT, this one doesn't update the insert position eiterh, but the order of the songs is fine, at least (due to appending).
Now, insert always updates the insert position properly, so that the aforementioned bugs are fixed. Insert is always used now.
Other impact: If you create a playlist using insert, every subsequent insert will append songs at the end of the playlist,if you start playback pressing select on songs, every subsequent insert will insert after the current track.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20241 a1c6a512-1295-4272-9138-f99709370657
2009-03-08 17:18:18 +00:00
Jonas Häggqvist
73639e8e2e Fix FS#9945 - Paste operation doesn't detect disk full (and possibly other errors).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20121 a1c6a512-1295-4272-9138-f99709370657
2009-02-26 22:55:04 +00:00
Jonathan Gordon
e385ee18ce Decouple the statusbar drawing from the rest of the screen drawing. it is not drawn roughly 4x per second automatically.
viewport_Set_defaults() will setup the given viewport with the correct "full screen" dimensions (so start at 0,0 if statusbars are disabled or 0,8 if they are enabled.)
All screens should keep the statusbar enabled, but if you really want to ignore the user setting you can disbaled it with viewportmanager_set_statusbar(false).

This commit also includes some menu/list viewport cleanups from kugel in FS#9603


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19622 a1c6a512-1295-4272-9138-f99709370657
2008-12-31 05:59:26 +00:00
Jonathan Gordon
ff2e9bdf72 fix FS#9687 - 'set song rating' should not be shown if the DB isnt useable
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19523 a1c6a512-1295-4272-9138-f99709370657
2008-12-21 09:58:11 +00:00
Nils Wallménius
d7fb430935 Fix FS#9357 'Cut/Paste does not remove old folder when replacing', fix suggested by Dan Everton
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19285 a1c6a512-1295-4272-9138-f99709370657
2008-12-01 11:31:22 +00:00
Bertrik Sikken
ae929e4dcd Make struct text_message const in apps/onplay.c
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19270 a1c6a512-1295-4272-9138-f99709370657
2008-11-30 12:33:58 +00:00
Björn Stenberg
51b45d5602 Split id3.c/h into metadata.c/h and metadata/mp3.c. Updated all references. Moved mp3data.c/h from firmware to apps.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18814 a1c6a512-1295-4272-9138-f99709370657
2008-10-15 06:38:51 +00:00
Jonathan Gordon
1da2f0112e Accept FS#9231 - viewportify the pitch screen by Thomas Martitz.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18714 a1c6a512-1295-4272-9138-f99709370657
2008-10-05 13:01:54 +00:00
Alessio Lenzi
8aa0491fb7 Used correct voice messages for some splash screens.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18498 a1c6a512-1295-4272-9138-f99709370657
2008-09-11 20:13:02 +00:00