Commit graph

164 commits

Author SHA1 Message Date
Jonathan Gordon
fe9dca3d5b option_screen() now accepts a viewport
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17223 a1c6a512-1295-4272-9138-f99709370657
2008-04-23 11:07:40 +00:00
Nils Wallménius
ac1b30ef73 Nicer handling of unset clock in the 'Rockbox Info' screen
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17199 a1c6a512-1295-4272-9138-f99709370657
2008-04-20 21:01:39 +00:00
Andree Buschmann
850a11250a Adding new setting to System Settings <Accessory Power Supply -- off by default). This setting can be used to enable/disable the power supply for accessories. With this commit implemented for iPods with PCF50605 power controller.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17193 a1c6a512-1295-4272-9138-f99709370657
2008-04-20 18:28:25 +00:00
Bertrik Sikken
8924686224 Removed unneeded dependency on pcmbuf.h
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17183 a1c6a512-1295-4272-9138-f99709370657
2008-04-20 10:21:44 +00:00
Bertrik Sikken
5633784f4f Made local functions static in playback_menu.c
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17177 a1c6a512-1295-4272-9138-f99709370657
2008-04-19 23:29:39 +00:00
Nils Wallménius
8dca930a1a Some small binsize savings
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17052 a1c6a512-1295-4272-9138-f99709370657
2008-04-09 16:01:40 +00:00
Nils Wallménius
6848961aa5 Pass the buffer length to the list_get_name callback functions instead of using hardcoded MAX_PATH
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17049 a1c6a512-1295-4272-9138-f99709370657
2008-04-09 15:25:17 +00:00
Linus Nielsen Feltzing
29cdd30dbc Fix for FS#8820 by Christopher Williams - Misformatted time in Rockbox Info
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16899 a1c6a512-1295-4272-9138-f99709370657
2008-03-31 07:37:19 +00:00
Dan Everton
ad74906e18 In the equalizer menu, switch to low-latency mode in the smallest scope rather than for the entire equalizer menu. Also mark some more functions as static.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16888 a1c6a512-1295-4272-9138-f99709370657
2008-03-30 09:31:09 +00:00
Dave Chapman
d746b79317 Remove unnecessary (and incorrect) #ifdefs surrounding #include "backdrop.h", and correct remaining references to HAVE_LCD_REMOTE to HAVE_REMOTE_LCD
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16873 a1c6a512-1295-4272-9138-f99709370657
2008-03-29 01:14:10 +00:00
Jens Arnold
5280395baa Update the LCD after setting flip status as required by the LCD drivers. Fixes garbled display after flipping before the first list update.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16867 a1c6a512-1295-4272-9138-f99709370657
2008-03-28 19:07:27 +00:00
Steve Bavin
c9df8fd87b The const police raid playback.c, should be no change to behaviour.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16860 a1c6a512-1295-4272-9138-f99709370657
2008-03-28 11:24:24 +00:00
Jonathan Gordon
5ca1539969 the menu and list now accepts a parent viewport to draw in (and the menu can be told to not show status/button bars). This lays the groundwork to fix colour problems with plugin menus (see star.c for an example.) This hopefully fixes some button bar issues as well as theme problems.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16812 a1c6a512-1295-4272-9138-f99709370657
2008-03-26 03:35:24 +00:00
Steve Bavin
cd88e2ad93 Code police raid on the settings code, consting and putting headers alongside their implementation.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16798 a1c6a512-1295-4272-9138-f99709370657
2008-03-25 15:24:03 +00:00
Jonathan Gordon
22fbafb6ba So, I've been sick these last few days, and I'm trying to not take drugs to get over the sickness... turns out that may not have been such a good descision. (AKA, I'm trying to get on the front page... (AKA, really revert this time... really) )
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16795 a1c6a512-1295-4272-9138-f99709370657
2008-03-25 13:13:46 +00:00
Jonathan Gordon
0158336ead well we suck! how could something seemingly simple be fubar'ed so much! KISS says revert this catastrofeeeee befroe anyone realises
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16794 a1c6a512-1295-4272-9138-f99709370657
2008-03-25 12:42:47 +00:00
Jonathan Gordon
58ee0fbd69 ok, redo that last commit.. always write /.rockbox/oldconfig.cfg when you load a new config or reset settings
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16793 a1c6a512-1295-4272-9138-f99709370657
2008-03-25 10:38:55 +00:00
Jonathan Gordon
9ed5a67b69 write the current settings to .rockbox/config.cfg.bak before resetting settings
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16792 a1c6a512-1295-4272-9138-f99709370657
2008-03-25 10:28:37 +00:00
Jonathan Gordon
e1ba7f76ef there is no need to load the filename settings unless reading from a .cfg, so stop them being read every time settings_apply() is called
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16535 a1c6a512-1295-4272-9138-f99709370657
2008-03-06 07:03:14 +00:00
Jonathan Gordon
012833ce15 merge the variou set color functions which all do the same thing (and just let settings_apply() set the setting)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16534 a1c6a512-1295-4272-9138-f99709370657
2008-03-06 05:49:10 +00:00
Jonathan Gordon
0def1dd23c force the lists to reload when the colour changes
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16529 a1c6a512-1295-4272-9138-f99709370657
2008-03-05 10:44:28 +00:00
Jonathan Gordon
0e5cec2d18 FS#8457 - convert the list drawing code to use viewports. This does not include any of the customizability which was in the patch, so unless any bugs show up users should not notice any difference.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16527 a1c6a512-1295-4272-9138-f99709370657
2008-03-05 09:58:30 +00:00
Dan Everton
0466319a75 Try and only use the PCM buffer low latency mode in sound settings when we really need to.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16496 a1c6a512-1295-4272-9138-f99709370657
2008-03-03 11:06:04 +00:00
Dan Everton
48a79ade6f All references to the hardware equalizer should have be removed.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16495 a1c6a512-1295-4272-9138-f99709370657
2008-03-03 10:58:23 +00:00
Steve Bavin
ea358a1fdc Keyclick option (FS#7307). Disabled by default, go into System settings to enable it. WARNING: PortalPlayer targets reportedly have a problem with this, so don't enable it on those unless you want to risk burning your ears with horrible noise. This is probably a bug in pcmbuf_beep(), and I'm hoping that someone who has an affected target will look into it and fix it as a result of this commit.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16132 a1c6a512-1295-4272-9138-f99709370657
2008-01-21 09:48:44 +00:00
Jonathan Gordon
189f9e2be9 charcell doesnt show titles in lists, so remove the "show path" setting and free up some bin space
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16069 a1c6a512-1295-4272-9138-f99709370657
2008-01-13 09:29:45 +00:00
Nils Wallménius
43cc03457d Fix FS#8451
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16065 a1c6a512-1295-4272-9138-f99709370657
2008-01-12 22:40:17 +00:00
Jonathan Gordon
b8bc45ded0 FS#8353 - add a quick way to make a .cfg from the sound settings.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15971 a1c6a512-1295-4272-9138-f99709370657
2007-12-24 22:35:31 +00:00
Jonathan Gordon
f5ec3e49e0 remove the duplicated gui_list struct and only duplicate the members which are actually different on each screen. should translate to a smaller bin and easier code (users shouldnt notice any difference)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15947 a1c6a512-1295-4272-9138-f99709370657
2007-12-17 02:37:21 +00:00
Thom Johansen
39e2de8f1b Crossfeed settings used to be stored inverted in the cfg file for legacy reasons, change that and kill some identical formatting functions while we're at it. NOTE TO CROSSFEED USERS: this will completely garble your crossfeed settings, write them down if you want to keep them.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15895 a1c6a512-1295-4272-9138-f99709370657
2007-12-08 01:45:04 +00:00
Dan Everton
5886efabf5 Save some bytes and reuse the settings saving code for eq preset saving.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15891 a1c6a512-1295-4272-9138-f99709370657
2007-12-07 10:59:07 +00:00
Dan Everton
d7e1f77146 Commit FS#7440. The iPod Video doesn't actually have a hardware equalizer. It does have hardware bass/treble settings with configurable cutoff. So make the bass/treble settings use the hardware and remove the hardware equalizer configuration.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15782 a1c6a512-1295-4272-9138-f99709370657
2007-11-24 07:51:00 +00:00
Björn Stenberg
b4e5123e5d New USB stack
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15758 a1c6a512-1295-4272-9138-f99709370657
2007-11-22 20:51:00 +00:00
Stéphane Doyon
a4f491cac1 Add a setting to control whether or not to speak the file type (r15506).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15508 a1c6a512-1295-4272-9138-f99709370657
2007-11-07 03:25:33 +00:00
Stéphane Doyon
fe2f1af0d3 Fix my mess in r15419: LANG_BATTERY_TOPOFF_CHARGE is only defined
when CONFIG_CHARGING == CHARGING_CONTROL.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15424 a1c6a512-1295-4272-9138-f99709370657
2007-11-03 05:40:22 +00:00
Stéphane Doyon
da93299865 Accept FS#7910: spontaneously speak out the battery level when it falls
under 50%, 30% and 15%. Guarded by an option under voice settings.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15422 a1c6a512-1295-4272-9138-f99709370657
2007-11-03 05:00:49 +00:00
Stéphane Doyon
69f88a5c35 Info screen: charging and battery.
For CHARGING_SIMPLE: if the charger is inserted, then indicate that the
battery is charging, and do not show the battery level (which should be
bogus anyway). This is the only place the charger status is reported for
blind users.

Allow reporting charge_state for CHARGING_MONITOR: the header file says
it could be CHARGING or TRICKLE. Hope this is right. Interestingly,
that's how the #ifdefs were for the voice part.

Have the voice match the displayed info.  In particular do not report
battery level when in a charging state.
Use the new talk time unit for the battery remaining duration.
If battery_level() is 0 and no info is available, then say "blank"
instead of nothing.
LANG_BATTERY_CHARGE: more verbose voice entry.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15419 a1c6a512-1295-4272-9138-f99709370657
2007-11-03 04:13:25 +00:00
Stéphane Doyon
f6b404bd73 Info screen fixups:
* Shortened the voice entry for external disk names.
* Deprecated LANG_CURRENT_TIME which is not used anywhere.
* Before there were CRLFs, then there were blank lines, cleaned that up.
* Removed extra format specifier and args in the snprintf for MMC NOT_PRESENT.
* Made the voice info about disks match more closely what is displayed:
  basically, speak disk size for multi-volume case as well.
* Not too sure about the reordering, so I did NOT touch that.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15415 a1c6a512-1295-4272-9138-f99709370657
2007-11-03 03:38:54 +00:00
Jonathan Gordon
9e23e9d43e Fix FS#7826 - make the view catalog option in the main menu > playlists menu use the same text as the view catalog option in the onplay menus
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15392 a1c6a512-1295-4272-9138-f99709370657
2007-11-01 13:41:16 +00:00
Alessio Lenzi
6c2a904f2b * For a better access to the information of the Rockbox Info menu by visually
impaired users, the order of the items has been modified.
* Now the software displays a message when the external memory card is not in
the device slot. (only for Sansa and Ondio models)
* The voice tag for the current_time message has been restored.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15381 a1c6a512-1295-4272-9138-f99709370657
2007-10-30 21:41:03 +00:00
Steve Bavin
fda41b892e Try and save some bytes, seeing as we already assumed LANG_ constants for month and weekday names are contiguous.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15289 a1c6a512-1295-4272-9138-f99709370657
2007-10-24 15:34:36 +00:00
Steve Bavin
b76b5b9fa2 Use some consts...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15287 a1c6a512-1295-4272-9138-f99709370657
2007-10-24 14:16:02 +00:00
Steve Bavin
7c95e5e6a6 Improved enum naming.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15286 a1c6a512-1295-4272-9138-f99709370657
2007-10-24 13:54:04 +00:00
Steve Bavin
072a3c5017 Complete info screen voicing; now consistent with displayed screen
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15284 a1c6a512-1295-4272-9138-f99709370657
2007-10-24 12:32:12 +00:00
Stéphane Doyon
a82a860c7e Small voice-related tweaks and fixes to simplelists.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15276 a1c6a512-1295-4272-9138-f99709370657
2007-10-23 05:19:03 +00:00
Jonathan Gordon
7c594d6ea1 convert the rockbox info screen to use the list. you need to move up/down in the list to voice each item
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15240 a1c6a512-1295-4272-9138-f99709370657
2007-10-21 09:33:42 +00:00
Steve Bavin
32a9575130 FS#7994 - Rename talk.c API, make talk_disable() affect all talking (not just menus), hopefully save some space.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15206 a1c6a512-1295-4272-9138-f99709370657
2007-10-19 15:31:42 +00:00
Stéphane Doyon
0279c71a92 Voice the recording trigger settings screen.
From FS#6325, with a slight coding improvement.
Also take out a duplicated snprintf in there.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15059 a1c6a512-1295-4272-9138-f99709370657
2007-10-10 01:41:48 +00:00
Stéphane Doyon
26e47f2ad5 Use dynamic menu voice callbacks to speak menu item names in the
"Simple EQ Settings" menu and the Peak filter item names in the
"Advanced EQ Settings" menu.
From FS#7563.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15043 a1c6a512-1295-4272-9138-f99709370657
2007-10-09 03:53:46 +00:00
Stéphane Doyon
5acf091046 Add a voice callback to dynamic menus, along side the text_callback.
From FS#7563.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15042 a1c6a512-1295-4272-9138-f99709370657
2007-10-09 03:48:56 +00:00