Commit graph

580 commits

Author SHA1 Message Date
Maurus Cuelenaere
5dca53eeb0 Even more touchscreen improvements.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17673 a1c6a512-1295-4272-9138-f99709370657
2008-06-01 13:56:34 +00:00
Maurus Cuelenaere
995b71a51d Some more touchscreen gui list improvements.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17672 a1c6a512-1295-4272-9138-f99709370657
2008-06-01 13:37:33 +00:00
Maurus Cuelenaere
944219bb77 (Simulator) Touchscreen improvements.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17662 a1c6a512-1295-4272-9138-f99709370657
2008-05-30 22:55:24 +00:00
Peter D'Hoye
f76122f0e7 Accept FS #9052 by Alexander Levin with a fix by me. Changes HAS_BUTTONBAR into HAVE_BUTTONBAR to bring it in line with the other defines
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17655 a1c6a512-1295-4272-9138-f99709370657
2008-05-29 20:32:39 +00:00
Jonathan Gordon
0792596e17 the splash should set the viewport to NULL untill we start passing it a vp. (not any time soon though)
"fix" FS#9044 by changing the delete dir screen to use the splash instead so it doesnt have to worry about the statusbar 
height


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17654 a1c6a512-1295-4272-9138-f99709370657
2008-05-29 14:40:12 +00:00
Jonathan Gordon
0501fb016c total removal of gui_textarea. The only thing using the text_message struct is the yesno screen so move its definition to yesno.h
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17653 a1c6a512-1295-4272-9138-f99709370657
2008-05-29 11:13:46 +00:00
Jonathan Gordon
43f0770943 move the HAS_BUTTONBAR define to the config-<target>.h files
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17652 a1c6a512-1295-4272-9138-f99709370657
2008-05-29 09:14:32 +00:00
Jonathan Gordon
fd3b46c22c draw the buttonbar in its own viewport. It always uses the sysfont and is drawn on the bottom.
Callers need to remeber to fiddle with their viewports to not be overwritten by the bar.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17651 a1c6a512-1295-4272-9138-f99709370657
2008-05-29 08:59:57 +00:00
Jonathan Gordon
ff469ab573 Updated recording trigger screen (seems to be a feature almost noone uses?)
problems/complaints in http://forums.rockbox.org/index.php?topic=16837.0
there is a known issue that on this screen the stop icon wont update, I dont know why and noone else wants to look at it, so hopefully this will force another set of eyes on it.. this is only a graphical issue... recordings still work fine


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17643 a1c6a512-1295-4272-9138-f99709370657
2008-05-28 10:55:39 +00:00
Jonathan Gordon
cdf18bf388 callbacks were being called with the old value.. spotted in IRC last week
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17641 a1c6a512-1295-4272-9138-f99709370657
2008-05-28 10:41:07 +00:00
Peter D'Hoye
f2d7270b70 Fix FS #9022: space reserved for the icons in the quickscreen used the incorrect constant
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17616 a1c6a512-1295-4272-9138-f99709370657
2008-05-23 21:20:05 +00:00
Jonathan Gordon
32db049a2a fix FS#9020 and make scrolling down in lists a bit more consistant with scrolling up
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17602 a1c6a512-1295-4272-9138-f99709370657
2008-05-22 06:23:15 +00:00
Bertrik Sikken
9244259f08 Make list.c use button_queue_count() instead of accessing the button_queue directly.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17587 a1c6a512-1295-4272-9138-f99709370657
2008-05-20 19:41:48 +00:00
Nils Wallménius
a21004dee6 Fix FS#9010 warning in checkwps when building on an amd64 machine
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17582 a1c6a512-1295-4272-9138-f99709370657
2008-05-19 14:37:16 +00:00
Jonathan Gordon
3e5b38945c const raid in option_select
add table settings and fix int settings with negative step in option_select_next_val
bump plugin API and sort newer functions


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17520 a1c6a512-1295-4272-9138-f99709370657
2008-05-15 06:58:36 +00:00
Nils Wallménius
111c999756 Delete whitespace to make 'Id' keyword behave as desired
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17501 a1c6a512-1295-4272-9138-f99709370657
2008-05-14 08:52:19 +00:00
Steve Bavin
71fa58985f Oops, forgot one.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17475 a1c6a512-1295-4272-9138-f99709370657
2008-05-12 18:05:06 +00:00
Steve Bavin
ad95df2cab Const police raid.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17474 a1c6a512-1295-4272-9138-f99709370657
2008-05-12 17:52:50 +00:00
Jonathan Gordon
95be4febc8 doh! fix yellow.
remove the calls to stop_scroll(), clear_viewport() does that

nothing should be using screens[].nb_lines anymore... change the list code to be a good example. (playlist_viewer is the last thing using it which needs fixing)



git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17456 a1c6a512-1295-4272-9138-f99709370657
2008-05-11 14:08:46 +00:00
Jonathan Gordon
aff220c9f5 and the time/date screen...
also change the order the yes/no screen clears the viewport.. stop_scroll should be called before clear or you might get artifacts


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17455 a1c6a512-1295-4272-9138-f99709370657
2008-05-11 13:59:27 +00:00
Jonathan Gordon
10df05438e more textarea to viewport conversion... yes/no screen...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17454 a1c6a512-1295-4272-9138-f99709370657
2008-05-11 13:39:22 +00:00
Nils Wallménius
fc25f3f61b Binsize optimization for targets without lcd remotes, whitespace/long lines police
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17453 a1c6a512-1295-4272-9138-f99709370657
2008-05-11 10:28:52 +00:00
Bertrik Sikken
7835a20347 Prototype declaration strictness fixes.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17424 a1c6a512-1295-4272-9138-f99709370657
2008-05-08 20:37:26 +00:00
Nicolas Pennequin
357ffb3c46 Convert the whole codebase to UTF-8, except docs/COMMITTERS and tools/creative.c, which need checking.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17369 a1c6a512-1295-4272-9138-f99709370657
2008-05-05 10:32:46 +00:00
Nicolas Pennequin
ef5fa8eaf5 Restore Zagor's copyright from before the WPS tokenizer. I shouldn't have removed it. Also add mine in playback.c, alongside Slasheri's.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17368 a1c6a512-1295-4272-9138-f99709370657
2008-05-05 09:40:22 +00:00
Jonathan Gordon
8e57ede59f move the pitchscreen out of screens.c.. no functional changes
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17365 a1c6a512-1295-4272-9138-f99709370657
2008-05-05 07:07:19 +00:00
Stéphane Doyon
7e86e5d866 Polish voicing of quickscreen: make it like in FS#6171: announce
"quickscreen" on entering, announce when leaving, say option name
when changing values in case the user isn't entirely familiar with
the layout...


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17358 a1c6a512-1295-4272-9138-f99709370657
2008-05-04 15:02:46 +00:00
Stéphane Doyon
ab0f7e17ef Accept FS#6188: study mode.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17355 a1c6a512-1295-4272-9138-f99709370657
2008-05-04 13:47:58 +00:00
Jonathan Gordon
1ef5a836f8 doh! those talk functions dont check the setting (which for some reason I thought they did).. shut the quickscreen up if talk is disabled
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17354 a1c6a512-1295-4272-9138-f99709370657
2008-05-04 13:39:54 +00:00
Jonathan Gordon
daa8341a13 a bit of code cleanup.. use a single function to get the statusbar height (or lack of if its enabled), and remove some gui_textarea stuff which could be done using the splash. (gui_textarea is on the way out)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17350 a1c6a512-1295-4272-9138-f99709370657
2008-05-04 10:58:05 +00:00
Jonathan Gordon
39bccd65b9 recommit the talking quickscreen... silly rename bug which I mised this morning
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17348 a1c6a512-1295-4272-9138-f99709370657
2008-05-04 08:11:28 +00:00
Stéphane Doyon
49a73ca90f Revert r17345 on jdgordon's request, until we figure out why it crashes my x5.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17346 a1c6a512-1295-4272-9138-f99709370657
2008-05-04 02:57:30 +00:00
Jonathan Gordon
dd4e3848b8 make the quickscreen talk
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17345 a1c6a512-1295-4272-9138-f99709370657
2008-05-04 02:11:24 +00:00
Jonathan Gordon
b234ef29b6 make the quickscreen not block so the statusbar gets updated
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17343 a1c6a512-1295-4272-9138-f99709370657
2008-05-04 01:42:11 +00:00
Bertrik Sikken
6a0340fc21 More static / header file cleanup.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17341 a1c6a512-1295-4272-9138-f99709370657
2008-05-03 23:18:56 +00:00
Jonathan Gordon
ef5286c48c remove some dead code
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17320 a1c6a512-1295-4272-9138-f99709370657
2008-05-03 14:26:47 +00:00
Jonathan Gordon
ea664e0647 Viewported quickscreen (take 2 :D) (FS#8553)
- no customization support
- no top item
- much better use of the screen
- deprecates 20 odd lang strings (the QS can now use the regular lang strings and user font)


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17315 a1c6a512-1295-4272-9138-f99709370657
2008-05-03 12:30:40 +00:00
Bertrik Sikken
e15f8a21a9 Made source files #include the header file that they implement to make sure they are in sync. Made some local functions static.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17312 a1c6a512-1295-4272-9138-f99709370657
2008-05-03 08:35:14 +00:00
Bertrik Sikken
2843469876 Moved atoi declaration to stdlib.h. Deleted atoi.h
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17280 a1c6a512-1295-4272-9138-f99709370657
2008-04-28 16:18:04 +00:00
Nils Wallménius
f79bc56430 Use smaller data types in structs which are in big arrays to save memory
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17256 a1c6a512-1295-4272-9138-f99709370657
2008-04-27 12:54:36 +00:00
Nils Wallménius
33c44461e1 Const police raid, making a lot of pointers to lang strings const and removing some ugly casting
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17251 a1c6a512-1295-4272-9138-f99709370657
2008-04-26 09:30:24 +00:00
Jonathan Gordon
fe9dca3d5b option_screen() now accepts a viewport
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17223 a1c6a512-1295-4272-9138-f99709370657
2008-04-23 11:07:40 +00:00
Jonathan Gordon
f8181966e6 And fix the bug which I was actually being pinged about...
dont show the selection marker if its not supposed to be shown (i.e the debug lists)


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17205 a1c6a512-1295-4272-9138-f99709370657
2008-04-21 13:44:52 +00:00
Jonathan Gordon
fa64dbb525 So, I was skimming the irc logs from my 3 day absense and I was pinged about a bug in the simplelist code and this function in particular. Neither time was the actual bug explained so I dont know what this commit fixes... I'm fairly certain it does fix it though because the old code was rediculously wrong. MY guess is it has something to do with the radio debug screen seen as its the only call to this with the param != 0.
Please use the damn tracker for bug reports.. pinging someone when they arnt even online (as opposed to idling in the channel) really is a waste of time.)


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17204 a1c6a512-1295-4272-9138-f99709370657
2008-04-21 13:32:10 +00:00
Nicolas Pennequin
380e915428 Fix FS#8914 (WPS %mp tag inconsistency).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17198 a1c6a512-1295-4272-9138-f99709370657
2008-04-20 20:07:05 +00:00
Stéphane Doyon
4b5f0909d1 Fix bug in r17188.
The warning from the build page was valid and helpful, wish my compiler had
given it to me...


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17189 a1c6a512-1295-4272-9138-f99709370657
2008-04-20 14:44:36 +00:00
Stéphane Doyon
b2aa86a785 FS#7980: Select default option in an option list
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17188 a1c6a512-1295-4272-9138-f99709370657
2008-04-20 14:12:28 +00:00
Bertrik Sikken
db2d61f4ea Killed unnecessary global variables by making them static.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17184 a1c6a512-1295-4272-9138-f99709370657
2008-04-20 10:24:15 +00:00
Nicolas Pennequin
a5ad74ffca Revert what was left of r17018 until I find a better way. It had quirks in some cases, and doesn't play well with what I'm about to commit.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17108 a1c6a512-1295-4272-9138-f99709370657
2008-04-14 15:51:40 +00:00
Nils Wallménius
84dc8d2c7e Move a function to gwps-common.c because it belongs there
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17084 a1c6a512-1295-4272-9138-f99709370657
2008-04-12 13:25:16 +00:00