Commit graph

37 commits

Author SHA1 Message Date
Dominik Riebeling
9ad1ef0e55 rbutil: Fix encoding for themes info data.
The themes info data uses utf-8 encoding, while QSettings defaults to
ASCII and uses escape sequences, resulting in non-ASCII characters being
garbled. Use the correct encoding.

Change-Id: Ibee58b51926f6d7c3885dead0b42579e21bfb1db
2020-12-10 21:30:13 +01:00
Dominik Riebeling
b064a6cbb5 rbutil: Rework and merge player and build server info handling.
Handling the data for players from rbutil.ini and the build-info data
from the server is closely related. Splitting things up into different
classes only creates tightly coupling, which is unnecessary, and the
need to differentiate between them in the application.

Merge both classes into a single one and rework handling so the
application doesn't have to deal with two separate classes anymore.

Furthermore, change URL templates to use new values from build-info
instead of hard coding them.

Change-Id: Ica550973ce23d1559110782add52bc214eba552d
2020-12-03 22:25:12 +01:00
Dominik Riebeling
78a01db47c rbutil: Get rid of configure_modelname in rbutil.ini.
The target selection string used for configure is the same as the
internally used player string, minus the (optional) variant suffix.
Don't duplicate things, simply strip the suffix.

Change-Id: Ic34bd5f933fab0d837adce0d0ae9c403868d720d
2020-12-03 22:25:12 +01:00
Dominik Riebeling
fb6840e572 rbutil: Remove done() signal from Themes Install window.
This shadows a slot from the base class. Since it isn't used simply
remove it.

Change-Id: If2e524141b7ca4ab1083b4b713b2db3a0b25e6a6
2020-11-19 21:32:41 +01:00
Dominik Riebeling
12764781c6 rbutil: Modernize code to use C++11 nullptr.
Change-Id: I112cf95122a896cdb30a823b4c1f49831273dc7e
2020-11-19 21:32:41 +01:00
Dominik Riebeling
be1be797b2 rbutil: Rework player configuration.
Rename config entries and remove now unnecessary default value handling.

Change-Id: I5c60ef9769fc01f45f45290dafffb80c1962e674
2020-11-14 16:42:29 +01:00
Dominik Riebeling
2509def164 rbutil: Rework player configuration.
- Split internal configuration into player specific and common parts.
  Always require passing the player for player specific data instead of
  implicitly assuming the currently selected one; only use the currently
  selected one if the player name is explicitly passed as empty.
- Similarly adjust handling of server info data; prepare for splitting
  into build type specific values so the naming becomes cleaner.

Change-Id: I894e694f83bd9fe2d22ad46b3f8f7df3e2c68033
2020-11-14 16:42:29 +01:00
Dominik Riebeling
96f82f828a rbutil: More Qt6 compatibility.
Qt6 doesn't contain QTextCodec anymore but instead provides it in the
optional core5compat module.

Change-Id: Ia45985a32df3826faf041981b8935c839946e5c9
2020-10-29 21:28:29 +01:00
Dominik Riebeling
4d2ce949b3 Use cutelogger for Rockbox Utility internal trace.
Change tracing from qDebug() to use cutelogger, which is available under the
LGPL2.1. This allows to automatically add filename and line number to the log,
and also provides multiple log levels.

Change-Id: I5dbdaf902ba54ea99f07ae10a07467c52fdac910
2013-11-04 23:32:52 +01:00
Dominik Riebeling
7184980dca Update Qt includes for compatibility with Qt5.
Change-Id: Ibe400700f6bce0335a2975c6d635e10ae940f932
2013-01-27 20:11:17 +01:00
Dominik Riebeling
abd87ccf15 Themes Window: don't set cache folder on each request.
The Themes Window reuses the download object for getting preview images. Since
the object is reused it isn't necessary to set the cache path on each network
request.

Change-Id: Ibc531e09ad19ede3cab7326d9230bd5188710d98
2013-01-27 20:11:17 +01:00
Dominik Riebeling
1f1826e39c Remove Rockbox Utility Offline Mode.
Offline Mode was intended to allow performing an installation without network
access. However, to get the required files cached the same installation has to
be performed with network access, which is a rather strange prerequisite. A
better way would be a way to direct Rockbox Utility to some local "repository"
that holds the required files.

Furthermore, Offline Mode hasn't been tested since long and is likely to be
broken since the caching mechanism has been extended.

For now remove this functionality. As far as I know it's been rarely used (if
at all) anyway.

Change-Id: Ib2af4892708e0440bd0a7940c131f04182ddb39a
2013-01-13 19:45:29 +01:00
Dominik Riebeling
39396cc707 Themes Window: do not download themes information multiple times.
Change-Id: Ic8011ec3f45d4313436a5a49a3a0f604f8931840
2012-08-19 11:04:54 +02:00
Dominik Riebeling
b7931594f9 Handle no selected themes properly.
When installing themes without any themes selected show a notice in the log and
continue instead of stopping.

Change-Id: Ieeb03e4656b041ce1dda25b2c44b6b6f0aa0ca80
2012-07-01 14:58:39 +02:00
Dominik Riebeling
9b783bc105 Separate select and install parts in themes install window.
Allow using the themes installation dialog as selection dialog separately from
installing themes. For this the installation is now triggered separately and
can be told to not to do the installation on Ok button. In this case the dialog
is selection only, and the Ok button is changed to Select. The installation
itself is still done in the class but started by calling the install() method
separately.

Change-Id: I856db8204788302b2b539e6d8283f73cb354f033
2012-06-26 18:30:27 +02:00
Dominik Riebeling
bdb00fa1fb Remove useless operation.
Change-Id: I378be5202d96cf6b44fb448cb7e620465ff36961
2012-04-28 16:49:08 +02:00
Dominik Riebeling
7263ccb105 Remove svn keyword lines from sources.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30806 a1c6a512-1295-4272-9138-f99709370657
2011-10-19 20:51:16 +00:00
Dominik Riebeling
2e3de70401 Rockbox Utility: listen to translation change events.
When changing the language don't require a restart anymore. Instead listen to
the appropriate changeEvent and retranslate the UI. Designer generated UI files
already provide such a function.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30633 a1c6a512-1295-4272-9138-f99709370657
2011-10-02 14:30:05 +00:00
Dominik Riebeling
b2998ef6c7 Move retrieval of revision and release numbers to RockboxInfo class.
This allows reusing retrieval for upcoming distinguishing between release and
current voice files.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26636 a1c6a512-1295-4272-9138-f99709370657
2010-06-06 18:02:01 +00:00
Dominik Riebeling
32a2b3e3fa Transmit installed build revision and release version to theme site.
To allow the theme site handling different versions of the theme syntax
transmit the revision number and release number (whatever applies) to the
server. A later update to the theme site can then return a theme list with
themes compatible, and include the correct download links.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26625 a1c6a512-1295-4272-9138-f99709370657
2010-06-06 12:56:27 +00:00
Dominik Riebeling
0a4b576248 Move constructing the themes info download link to rbutil.ini.
Instead of constructing the download link with fixed script name put a template
into the system info file. That way changing the download link doesn't require
changing the code anymore.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26495 a1c6a512-1295-4272-9138-f99709370657
2010-06-02 21:55:22 +00:00
Dominik Riebeling
9fedc8187f Move utils.cpp functions into separate class and split it up.
Move class-less functions in utils.cpp into a new Utils class and make the old
functions static. This prevents clashes with system C functions. Rename some
functions to avoid macro problems (check() is a macro on OS X). Split out the
RockboxInfo class into a separate file.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25441 a1c6a512-1295-4272-9138-f99709370657
2010-04-02 21:24:19 +00:00
Dominik Wenger
6128bd14e9 rbutil: split RbSettings. use Stable/unstable status from server.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24331 a1c6a512-1295-4272-9138-f99709370657
2010-01-24 21:12:11 +00:00
Tomer Shalev
294b017cd1 Revert r24174 following the discussion on mailing-list
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24213 a1c6a512-1295-4272-9138-f99709370657
2010-01-10 17:13:32 +00:00
Tomer Shalev
86c1360169 rbutil: Fix some messages
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24174 a1c6a512-1295-4272-9138-f99709370657
2010-01-03 20:17:36 +00:00
Tomer Shalev
a398e44680 rbutil: Explicitly set some widgets layout direction to LTR
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24173 a1c6a512-1295-4272-9138-f99709370657
2010-01-03 20:04:45 +00:00
Tomer Shalev
d011eecad4 FS#10748 - rbutil: Explicitly override GUI layout direction setting for some widgets
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23441 a1c6a512-1295-4272-9138-f99709370657
2009-10-31 17:16:34 +00:00
Dominik Riebeling
f1fadb2b60 Clean up and improve themes install window debug messages.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20989 a1c6a512-1295-4272-9138-f99709370657
2009-05-19 21:10:19 +00:00
Dominik Wenger
33d9cf091a rbutil: make RbSettings a static class. (FS#10183 with improvements)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20890 a1c6a512-1295-4272-9138-f99709370657
2009-05-09 16:59:14 +00:00
Dominik Riebeling
d5f7dab230 Cleanup and un-gui ZipInstaller class:
- Use signals for updating the progress logger from  ZipInstaller class.
- Move ZipInstaller class to base folder as it doesn't rely on QtGui anymore.
- cleanup debugging output a bit.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20845 a1c6a512-1295-4272-9138-f99709370657
2009-05-02 18:50:31 +00:00
Dominik Riebeling
7cfdd47587 Clean up ProgressLogger state handling:
- use better names for member functions
- don't emit aborted() when exiting a successful log


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20844 a1c6a512-1295-4272-9138-f99709370657
2009-05-02 18:40:04 +00:00
Dominik Riebeling
3d2e42ab4c Completely rework RbSettings class.
- use a single member function for accessing a settings value.
- use an enum to figure the correct value in the settings file instead of functions.
- return the settings value as QVariant instead and leave converting to the caller.
- accept QVariant as value when setting values.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20823 a1c6a512-1295-4272-9138-f99709370657
2009-04-29 20:58:47 +00:00
Dominik Riebeling
244ab33298 Fix the includes I forgot when renaming the ZipInstaller class file.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20814 a1c6a512-1295-4272-9138-f99709370657
2009-04-27 19:58:24 +00:00
Dominik Riebeling
d111f3b66f Qt always assumes ini files to use Latin1 encoding but the theme site uses utf-8. Explicitly convert texts displayed to the user. Fixes non-ascii characters showing up incorrectly.
Replace some HTML entities for the themes list as that isn't parsed as HTML.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20811 a1c6a512-1295-4272-9138-f99709370657
2009-04-27 17:48:49 +00:00
Dominik Riebeling
40137a9c07 Trim description text before displaying and display newlines as line breaks.
Trim themes titles before displaying in the list to remove stray whitespace.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20810 a1c6a512-1295-4272-9138-f99709370657
2009-04-27 16:07:27 +00:00
Dominik Riebeling
29dbd8f317 Invalidate preview image cache when updating to prevent a resize event repainting the old image before the new image is downloaded.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20773 a1c6a512-1295-4272-9138-f99709370657
2009-04-21 19:50:27 +00:00
Dominik Riebeling
270106d151 Rename ThemeInstall class files to actually match the class name.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20594 a1c6a512-1295-4272-9138-f99709370657
2009-03-31 19:50:43 +00:00
Renamed from rbutil/rbutilqt/installthemes.cpp (Browse further)