Commit graph

4656 commits

Author SHA1 Message Date
Brandon Low
483c947c3d Add a logf, remove an unused parameter, and an unused member of the track_info struct, ensure that we unboos on stop even if buffering, make a function take a parameter instead of using a global
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9644 a1c6a512-1295-4272-9138-f99709370657
2006-04-13 15:48:00 +00:00
Brandon Low
c95044a9c1 Track skipping rework more. This seems to handle rapid skipping very gracefully without compromising buffer safety. There may still be a potentially broken code path if the user does a very rapid skip, stop sequence, and I will be sure to investigate this. Due to Slasheri's concern, reimplement rapid GUI update for track skipping in a safe way.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9643 a1c6a512-1295-4272-9138-f99709370657
2006-04-13 14:17:12 +00:00
Dave Chapman
5cce8fb99f Explicitly set the foreground colour instead of using the user's default foreground colour. Fixes bug report #5117 (which was applicable to all Colour targets)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9642 a1c6a512-1295-4272-9138-f99709370657
2006-04-13 14:03:59 +00:00
Miika Pekkarinen
24bf89259e Fixed a bug in retrieving track filename when tagcache is loaded in ram.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9641 a1c6a512-1295-4272-9138-f99709370657
2006-04-13 07:15:30 +00:00
Brandon Low
b1fa534f14 Simplify audio startup, and remove some unnecessary code
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9640 a1c6a512-1295-4272-9138-f99709370657
2006-04-13 02:46:34 +00:00
Miika Pekkarinen
1b18dd0f17 Show progress while committing tagcache.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9637 a1c6a512-1295-4272-9138-f99709370657
2006-04-12 10:31:24 +00:00
Brandon Low
44d9576ff5 Track changes should zero the seek_time to prevent undesired seeking in the new track
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9636 a1c6a512-1295-4272-9138-f99709370657
2006-04-12 03:25:54 +00:00
Brandon Low
54af304a5b use the cur_ti pointer, as it's always synched up with track_ridx any way
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9635 a1c6a512-1295-4272-9138-f99709370657
2006-04-12 02:01:26 +00:00
Brandon Low
376950155c Get the GUI and audio in sync for track changes
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9634 a1c6a512-1295-4272-9138-f99709370657
2006-04-12 01:45:53 +00:00
Brandon Low
10c3a34c85 Fix major rebuffer stupidity, remove a redundant call, and a wrong comment.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9633 a1c6a512-1295-4272-9138-f99709370657
2006-04-12 00:21:29 +00:00
Thom Johansen
bd6b62bc84 OK, GCC obviously has a hard time with this. Let's just pretend GCC 4.1 doesn't exist for now and revert last change.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9632 a1c6a512-1295-4272-9138-f99709370657
2006-04-12 00:14:39 +00:00
Thom Johansen
e99dafa2ae Fix a couple of warnings for GCC 4.1.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9630 a1c6a512-1295-4272-9138-f99709370657
2006-04-11 23:33:41 +00:00
Thom Johansen
81cb35d42d Various optimisations for libmad by
Antonius HellmanO5Cn. Details at
http://www.rockbox.org/tracker/task/5078


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9629 a1c6a512-1295-4272-9138-f99709370657
2006-04-11 23:29:25 +00:00
Brandon Low
af09d22125 Add and improve logfing, fix a possible cause of problems due to abuse of read_next_metadata
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9628 a1c6a512-1295-4272-9138-f99709370657
2006-04-11 23:08:21 +00:00
Brandon Low
d6b370be02 Fix logf build, fix double reporting buffer events.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9627 a1c6a512-1295-4272-9138-f99709370657
2006-04-11 22:38:33 +00:00
Brandon Low
16ee4160d6 Make logf not be a dumb wrapper
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9626 a1c6a512-1295-4272-9138-f99709370657
2006-04-11 22:19:47 +00:00
Adam Boot
c9ca7ef23d Jewels: fix a couple minor menu inconsistencies
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9623 a1c6a512-1295-4272-9138-f99709370657
2006-04-11 21:46:51 +00:00
Brandon Low
87484fcbc7 Almost entirely formatting changes, but also add one logf, and fix one nearly impossible to hit (I doubt it's been hit in the history of rockbox) bug
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9621 a1c6a512-1295-4272-9138-f99709370657
2006-04-11 20:41:04 +00:00
Ben Basha
390f167754 Brickmania and Tetrox for iPod mini by Anton Romanov (FS #5094 & #5067)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9618 a1c6a512-1295-4272-9138-f99709370657
2006-04-11 20:16:05 +00:00
Jens Arnold
93c1626d67 FPS test: Made output better fit smaller screens. * Added remote LCD FPS measurement.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9617 a1c6a512-1295-4272-9138-f99709370657
2006-04-11 19:29:01 +00:00
Brandon Low
8529414c7f Clarify a comment
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9616 a1c6a512-1295-4272-9138-f99709370657
2006-04-11 17:20:55 +00:00
Brandon Low
8966c018fa Clear tracks in more appropriate ways/places
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9615 a1c6a512-1295-4272-9138-f99709370657
2006-04-11 17:17:24 +00:00
Brandon Low
01219fa29e Handle rebuffer-and-seek and track skip buffer events smarter. Fill the buffer all the way around on a 'normal' rebuffer. Rename and invert a strangely named variable for simpler logic.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9614 a1c6a512-1295-4272-9138-f99709370657
2006-04-11 17:08:11 +00:00
Brandon Low
a476718aab Fix yellow
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9613 a1c6a512-1295-4272-9138-f99709370657
2006-04-11 16:13:24 +00:00
Brandon Low
ba19bc201a Updated korean.lang, and a main_menu.c string size increase to accomodate larger lang strings
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9612 a1c6a512-1295-4272-9138-f99709370657
2006-04-11 16:12:57 +00:00
Brandon Low
73365c8bda Fix a (very unlikely) bug in buffering
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9611 a1c6a512-1295-4272-9138-f99709370657
2006-04-11 15:45:11 +00:00
Brandon Low
b6607459c2 Fix some signedness and exit condition stuff. Not sure if this addresses live bugs, but it was wrong nonetheless
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9610 a1c6a512-1295-4272-9138-f99709370657
2006-04-11 14:13:41 +00:00
Thom Johansen
8238b49c74 New crossfeed complete with no volume reducing bugs. Feedback on all the
new options is appreciated. Thanks to Dan Everton for the settings/GUI
code.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9609 a1c6a512-1295-4272-9138-f99709370657
2006-04-11 13:49:05 +00:00
Brandon Low
6bd1f143fa Try to recover from a codec failure by restarting playback
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9608 a1c6a512-1295-4272-9138-f99709370657
2006-04-11 13:21:51 +00:00
Brandon Low
afb64a481b Whoops, remove a done TODO
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9607 a1c6a512-1295-4272-9138-f99709370657
2006-04-11 13:02:06 +00:00
Brandon Low
a9debda64e Fix some comments
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9606 a1c6a512-1295-4272-9138-f99709370657
2006-04-11 13:00:45 +00:00
Brandon Low
3b76544fa9 Ensure that codecs are cleared from the buffer if they will not be needed by the track about to play and some minor changes for correctness with no functional difference
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9605 a1c6a512-1295-4272-9138-f99709370657
2006-04-11 12:29:46 +00:00
Daniel Stenberg
d2848f3d72 moved the LCD framebuffer to IRAM for iAudio X5 - gives ~40% speed boost
I also extended the iram size properly since the 5250 coldfire has 128K


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9604 a1c6a512-1295-4272-9138-f99709370657
2006-04-11 10:37:37 +00:00
Daniel Stenberg
8521215211 use the power switch on units without off button (like the X5)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9603 a1c6a512-1295-4272-9138-f99709370657
2006-04-11 08:03:45 +00:00
Zakk Roberts
a0a01b38e2 Readjusted quickscreen code so that it now actually scales to larger LCDs. Get rid of 'left_right_text' argument - this also means that 'scroll bar' and 'status bar' look better in some languages.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9602 a1c6a512-1295-4272-9138-f99709370657
2006-04-11 06:38:10 +00:00
Brandon Low
62ccbbb418 Rework track skipping. Full playback stop is no longer involved in track skipping. Further simplification of the play related functions can be achieved with this in place, but that's for later. Known skip related bug, high pitched noise sometimes, otherwise stuff is better
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9601 a1c6a512-1295-4272-9138-f99709370657
2006-04-11 03:55:58 +00:00
Brandon Low
fb6b475dee Minor fix to metadata fetching, the track-info.filesize is not populated at this point
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9600 a1c6a512-1295-4272-9138-f99709370657
2006-04-11 03:54:24 +00:00
Brandon Low
574c5242e0 Quick bugfix for skip-to-beginning behavior
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9599 a1c6a512-1295-4272-9138-f99709370657
2006-04-11 01:41:40 +00:00
Miika Pekkarinen
58fe4dea05 Major improvement in playlist creation speed with tagcache. Fixed also
the sorting bug.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9592 a1c6a512-1295-4272-9138-f99709370657
2006-04-10 10:26:24 +00:00
Brandon Low
2caad6fbc1 Get the next track's metadata in a more timely manner
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9591 a1c6a512-1295-4272-9138-f99709370657
2006-04-10 04:14:20 +00:00
Zakk Roberts
2f943b054c Enabled the quickscreen for iAudio X5. Globally, REC enters the menu and holding REC enters the quickscreen. Also moved the quickscreen #define to model config files, which simplifies the checking for it and makes checking more consistent. Cleaned up keymappings in quickscreen.h.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9590 a1c6a512-1295-4272-9138-f99709370657
2006-04-10 03:51:17 +00:00
Brandon Low
bf6f9c66a1 Enable AB repeat on ipods with 4g keypad, requires quick fingers or you get the context menu instead of a marker. Thanks to Mikachu on IRC.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9589 a1c6a512-1295-4272-9138-f99709370657
2006-04-10 00:39:48 +00:00
Miika Pekkarinen
93ed0a7bb0 Small optimization to use the already opened master lookup index.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9586 a1c6a512-1295-4272-9138-f99709370657
2006-04-09 20:00:49 +00:00
Miika Pekkarinen
bd39c25586 Now define the _PRE-function correctly.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9585 a1c6a512-1295-4272-9138-f99709370657
2006-04-09 19:17:32 +00:00
Magnus Holmgren
92ff0e292d Back out the 'do not stop playback until stop button has been released' change, because of interaction issues with exiting menus using the same button, causing the wps to exit. (Also, the '_PRE' suffix is for 'preceeding' events (e.g., button presses), not button releases.)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9584 a1c6a512-1295-4272-9138-f99709370657
2006-04-09 17:08:32 +00:00
Brandon Low
25e367ce34 Formatting, and logf changes
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9583 a1c6a512-1295-4272-9138-f99709370657
2006-04-09 16:12:12 +00:00
Brandon Low
4f3bb2ded7 Fix another nasty rebuffering bug, and ensure that buffer and unbuffer events are triggered correctly. Also remove another unused varialbe track_info->filepos
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9582 a1c6a512-1295-4272-9138-f99709370657
2006-04-09 15:30:28 +00:00
Christian Gmeiner
a91b794cb2 use #ifdef x instead of #if defined(x)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9581 a1c6a512-1295-4272-9138-f99709370657
2006-04-09 15:00:30 +00:00
Christian Gmeiner
eb7d4f88ea HAVE_ADJUSTABLE_CPU_FREQ isn't defined for simulators, so we don't have to check for simulator builds before using cpu_boost()
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9580 a1c6a512-1295-4272-9138-f99709370657
2006-04-09 14:50:43 +00:00
Dave Chapman
65293be9bf HAVE_ADJUSTABLE_CPU_FREQ isn't defined for simulators, so we don't have to check for simulator builds before using cpu_boost()
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9579 a1c6a512-1295-4272-9138-f99709370657
2006-04-09 14:20:14 +00:00