Thomas Martitz
50a6ca39ad
Move c/h files implementing/defining standard library stuff into a new libc directory, also standard'ify some parts of the code base (almost entirely #include fixes).
...
This is to a) to cleanup firmware/common and firmware/include a bit, but also b) for Rockbox as an application which should use the host system's c library and headers, separating makes it easy to exclude our files from the build.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25850 a1c6a512-1295-4272-9138-f99709370657
2010-05-06 21:04:40 +00:00
Jonathan Gordon
6643a3bc74
Fix FS#9660 - make warn on playlist erase work correctly when creating a new playlist from the database (a bit of a hack, but not bad enough to outright reject)
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24089 a1c6a512-1295-4272-9138-f99709370657
2009-12-21 05:44:00 +00:00
Jeffrey Goode
9d842683eb
Comment out LOGF_ENABLE defines everywhere, replace evil comments
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23497 a1c6a512-1295-4272-9138-f99709370657
2009-11-03 16:25:03 +00:00
Jeffrey Goode
9a4420bf96
FS#10739: playback.c code split
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23444 a1c6a512-1295-4272-9138-f99709370657
2009-10-31 19:17:36 +00:00
Thomas Martitz
774bacc692
Correct wrong usage of event callbacks all over the place. It's not supposed to return anything, and should take a data parameter.
...
Fixing it because correcting the event api prototypes causes many warnings.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23301 a1c6a512-1295-4272-9138-f99709370657
2009-10-20 21:54:44 +00:00
Thomas Martitz
16983afae7
Fix displaying of the database browser's progress splash so that it works as intended (according to r16432: hide until 0.5s have passed, but never if the disk isn't spinning).
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22442 a1c6a512-1295-4272-9138-f99709370657
2009-08-20 19:31:09 +00:00
Thomas Martitz
18e40e0f4c
Make kbd_input() show a cancel splash to indicate user abort better and for better consistency all over the place. Change checking for its return value (style-wise) at some places too.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22269 a1c6a512-1295-4272-9138-f99709370657
2009-08-12 14:38:25 +00:00
Nils Wallménius
3d4701a6e4
FS#10080
...
* Move strncpy() from core to the pluginlib
* Introduce strlcpy() and use that instead in most places (use memcpy in a few) in core and some plugins
* Drop strncpy() from the codec api as no codec used it
* Bump codec and plugin api versions
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21863 a1c6a512-1295-4272-9138-f99709370657
2009-07-14 13:57:45 +00:00
Miika Pekkarinen
8e2bdcaab6
A bunch of stability fixes into tagcache engine and database browser. Mainly data retrieval problems, races, data corruption of sorted index files at the end with junk data, access to unitialized memory and so on. Should fix FS#8710 and may fix FS#8414.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21402 a1c6a512-1295-4272-9138-f99709370657
2009-06-20 16:17:54 +00:00
Andrew Mahone
1248a0dc1f
Replace arrays of tags that are numeric/sorted/uniqued with bitfields flagging each tag that is a member of the set, and replace the membership tests with a shift and bitwise and. The test is still done inside a function on SH, as this saves some space vs the macro used on other targets.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21175 a1c6a512-1295-4272-9138-f99709370657
2009-06-03 08:19:32 +00:00
Thomas Martitz
38d5175b52
Rename struct root_menu and the global int root_menu to avoid clashes with #including plugin.h (which #includes root_menu.h), which will be needed for pictureflow in the database (I have some code for that).
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21137 a1c6a512-1295-4272-9138-f99709370657
2009-05-30 16:35:28 +00:00
Thomas Martitz
fc502e0b15
Move enum table into tagtree.c as it's not used elsewhere and switch to uppercase for its constants as per docs/CONTRIBUTING.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21135 a1c6a512-1295-4272-9138-f99709370657
2009-05-30 16:10:34 +00:00
Bertrik Sikken
2dc2054319
Remove some unused declarations
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21010 a1c6a512-1295-4272-9138-f99709370657
2009-05-21 12:32:26 +00:00
Bertrik Sikken
b24fafbf14
Yet more #include cleanups
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20249 a1c6a512-1295-4272-9138-f99709370657
2009-03-08 20:28:15 +00:00
Frank Gevaerts
2f8a0081c6
Apply FS#9500. This adds a storage_*() abstraction to replace ata_*(). To do that, it also introduces sd_*, nand_*, and mmc_*.
...
This should be a good first step to allow multi-driver targets, like the Elio (ATA/SD), or the D2 (NAND/SD).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18960 a1c6a512-1295-4272-9138-f99709370657
2008-11-01 16:14:28 +00:00
Jonathan Gordon
71898e5c54
Accept FS#9480 - centralise and organise the events in the apps/ layer.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18819 a1c6a512-1295-4272-9138-f99709370657
2008-10-16 10:38:03 +00:00
Frank Gevaerts
46573019a5
add HAVE_DISK_STORAGE, and use that instead of HAVE_FLASH_STORAGE when checking for an actual disk (i.e. related to spindown, skipping,...)
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18735 a1c6a512-1295-4272-9138-f99709370657
2008-10-07 19:37:33 +00:00
Jonathan Gordon
a3b9bfc763
dont let the database create a new playlist when party mode is on. (fixes FS#8292)
...
its not consistant with the filebrowser though, i.e you have to open the context menu for the item to add it to the playlist (whereas in the filebrowser it automatically gets queued if its selected)
still better than ignoreing the setting though
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18316 a1c6a512-1295-4272-9138-f99709370657
2008-08-19 12:05:01 +00:00
Nils Wallménius
01729e7a18
FS#9281 Rename of splash functions.
...
* Remove gui_splash()
* Rename gui_syncsplash() to splashf() and remove its voice
capabilities.
* Rename the internal splash() to splash_internal() and introduce an
externally visible splash() that handles simple splashing without
printf functionality e.g. splash(HZ, ID2P(LANG_FOO)); or splash(HZ,
"foo"); if a LANG_* id is passed it will be voiced.
* Adjust all places that called gui_syncsplash() to use the correct
variant from above.
* Export both new functions to plugins and adjust places calling
rb->splash() to use the correct variant so that we now have naming
consistency between the core and plugins.
* Fix one latent bug that would cause my sim to crash with the above
changes and correct P2STR and P2ID macros, thanks to pondlife.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18282 a1c6a512-1295-4272-9138-f99709370657
2008-08-15 08:27:39 +00:00
Bertrik Sikken
f4d4a6ab60
Implement FS#8947 - Add a stub in the simulator for ata_disk_is_active. This make it possible to clean up some #ifdef SIMULATOR macros.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17927 a1c6a512-1295-4272-9138-f99709370657
2008-07-03 13:37:57 +00:00
Robert Kukla
f9f2d6d42e
fix FS#9104 - Database sorting does not work on un-filtered list
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17910 a1c6a512-1295-4272-9138-f99709370657
2008-07-01 20:55:19 +00:00
Jonathan Gordon
a3e63cf044
very minor code police. also fix a possible but unlikely missed cpu_boost(false)
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17867 a1c6a512-1295-4272-9138-f99709370657
2008-06-29 07:29:14 +00:00
Daniel Stenberg
2acc0ac542
Updated our source code header to explicitly mention that we are GPL v2 or
...
later. We still need to hunt down snippets used that are not. 1324 modified
files...
http://www.rockbox.org/mail/archive/rockbox-dev-archive-2008-06/0060.shtml
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17847 a1c6a512-1295-4272-9138-f99709370657
2008-06-28 18:10:04 +00:00
Nils Wallménius
dabcb81e13
Introduce a small helper function that asks the user if the dynamic playlist should be erased to increase code re-use
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17295 a1c6a512-1295-4272-9138-f99709370657
2008-05-01 10:13:12 +00:00
Bertrik Sikken
2843469876
Moved atoi declaration to stdlib.h. Deleted atoi.h
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17280 a1c6a512-1295-4272-9138-f99709370657
2008-04-28 16:18:04 +00:00
Bertrik Sikken
43414807da
Updated use of events.h header file.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17267 a1c6a512-1295-4272-9138-f99709370657
2008-04-27 19:56:16 +00:00
Nils Wallménius
33c44461e1
Const police raid, making a lot of pointers to lang strings const and removing some ugly casting
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17251 a1c6a512-1295-4272-9138-f99709370657
2008-04-26 09:30:24 +00:00
Bertrik Sikken
3e98eb2de0
Renamed remove_all_tracks to playlist_remove_all_tracks to make it consistent with the naming of the other functions in playlist.c
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17186 a1c6a512-1295-4272-9138-f99709370657
2008-04-20 11:19:50 +00:00
Jonathan Gordon
a67e5d89ef
It makes more sense for the callback registrar to decide if its a "oneshot" then the callback caller.
...
(Doing it this way means playback could(/should?) registar a disk spinup callback at init which is called every spinup without needing to be reregistered)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16685 a1c6a512-1295-4272-9138-f99709370657
2008-03-17 05:22:53 +00:00
Miika Pekkarinen
19c6e66c13
Implement the playback event handling as a system-wide multi-purpose event system. Unified mpeg.c and playback.c audio event handling. Converted ata_idle_notify to use the new event handling system also.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16682 a1c6a512-1295-4272-9138-f99709370657
2008-03-16 13:55:16 +00:00
Miika Pekkarinen
104fa099cc
Fixed red. HWCODEC platforms still use the old api.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16549 a1c6a512-1295-4272-9138-f99709370657
2008-03-07 23:59:48 +00:00
Miika Pekkarinen
2ccdc48ee9
Rewritten playback event handling. Should fix runtime statistics gathering.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16546 a1c6a512-1295-4272-9138-f99709370657
2008-03-07 22:56:51 +00:00
Barry Wardell
aef38f6ef4
Fix sim builds.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16433 a1c6a512-1295-4272-9138-f99709370657
2008-02-27 17:54:57 +00:00
Barry Wardell
ca57699ed5
More improvement to the display of Searching... splashes in the tagtree:
...
1) Only show splashes on searches after 1/2 second has passed. This avoids splashes for very short searches.
2) Update the splash a little more frequently for better feedback.
3) Fix a bug where the number of items found was reported wrongly a lot of the time.
4) Display the splash straight away if the disk needs to spin up because it's definitely going to be waiting at least a couple of seconds then.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16432 a1c6a512-1295-4272-9138-f99709370657
2008-02-27 17:42:51 +00:00
Barry Wardell
3e4d79eaf5
Remove the annoying 'Searching...0 tracks found' splash on Sansa when using the database.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16429 a1c6a512-1295-4272-9138-f99709370657
2008-02-26 19:25:07 +00:00
Robert Kukla
ad5610dccd
fix FS#8599 - First Song in Tagcache can't be rated
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16291 a1c6a512-1295-4272-9138-f99709370657
2008-02-12 18:51:10 +00:00
Steve Bavin
c7a046dd1d
FS#8375 - Fix division by zero using the random database selection in a near-empty subset. Thanks to Henri Valta.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15989 a1c6a512-1295-4272-9138-f99709370657
2008-01-03 07:29:19 +00:00
Steve Bavin
de741cd534
FS#6960 - Add random selection option to database, by Mark Reiche. This satisfies FS#6915.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15957 a1c6a512-1295-4272-9138-f99709370657
2007-12-21 13:31:50 +00:00
Robert Kukla
a334bd2891
revise commit r15463 - we still get the immediate display of runtime data in the wps, but avoid unnecessary calls while initialising/updating the database.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15781 a1c6a512-1295-4272-9138-f99709370657
2007-11-23 23:36:42 +00:00
Miika Pekkarinen
f98a0a97f6
Fixed compile errors with logf enabled.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15777 a1c6a512-1295-4272-9138-f99709370657
2007-11-23 17:58:03 +00:00
Robert Kukla
ca1b920896
Fix for FS#8082:
...
runtime data fields are filled like any other fields in the mp3entry struct during the call to get_metadata(); HWCODEC still uses the old callback mechanism
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15463 a1c6a512-1295-4272-9138-f99709370657
2007-11-04 21:11:40 +00:00
Nicolas Pennequin
7f79564abc
Accept FS#8053 by Bertrik Sikken: playback.c and mpeg.c simplification by removal of last_track argument in track_(un)buffer callback.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15384 a1c6a512-1295-4272-9138-f99709370657
2007-10-31 13:43:50 +00:00
Robert Kukla
c436657571
some improvements to FS#8008 - see tracker entry for details
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15371 a1c6a512-1295-4272-9138-f99709370657
2007-10-30 10:02:57 +00:00
Jonathan Gordon
75eff7af5e
rework my previous commit (FS#8008) to be able to work for any of the strings in the id3 info struct, new ones need to be added to tagtree.c and tagnavi.config
...
*currently available tags are* #title# #artist# #album# #genre# #composer# #albumartist# and #directory#
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15358 a1c6a512-1295-4272-9138-f99709370657
2007-10-29 14:10:24 +00:00
Jonathan Gordon
1f415e2fe3
fix yellow
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15355 a1c6a512-1295-4272-9138-f99709370657
2007-10-29 12:15:47 +00:00
Jonathan Gordon
4d18aa3546
Accept FS#8008 - allows the current artist or album to be used in databse searches (use the #artist# or #album# keywords in tagnavi.config)
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15354 a1c6a512-1295-4272-9138-f99709370657
2007-10-29 12:02:55 +00:00
Dan Everton
eecfe9f1cb
Add support for grouping tags. From FS#7362.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14242 a1c6a512-1295-4272-9138-f99709370657
2007-08-08 10:19:56 +00:00
Nils Wallménius
5b76936a44
Accept FS#6159 'Add voice to roughly 100 splash screens and yes-no menus' by Stephane Doyon with some minor tweaks by me. Rerun 'configure' and do a 'make clean' before rebuilding your voice files.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14213 a1c6a512-1295-4272-9138-f99709370657
2007-08-06 13:08:36 +00:00
Nils Wallménius
b311367481
*** Lang v2 cleanup (FS#6574) ***
...
1) Introduces apps/features.txt that controls which strings are included
for each target based on defines.
2) .lng and .voice files are now target specific and the format versions
of both these file types have been bumped, which means that new voice
files are needed.
3) Use the 'features' mechanism to exclude strings for targets that
didn't use them.
4) Delete unused and deprecated and duplicated strings, sort strings in
english.lang
Some string IDs were changed so translations will be slightly worse than
before.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14198 a1c6a512-1295-4272-9138-f99709370657
2007-08-05 19:19:39 +00:00
Dan Everton
f4a61f0c4a
Add support for parsing the disc number tag from metadata and use of it in the database. Patch originally from FS#4961 with some minor tweaks by me.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14154 a1c6a512-1295-4272-9138-f99709370657
2007-08-03 10:00:42 +00:00