Commit graph

596 commits

Author SHA1 Message Date
Jonathan Gordon
d8e56e30d7 allow the full lowercase a-z to be used as conditional viewport grouping id's
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17789 a1c6a512-1295-4272-9138-f99709370657
2008-06-25 08:08:39 +00:00
Jonathan Gordon
e0b957fd51 quick fix for FS#8729
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17780 a1c6a512-1295-4272-9138-f99709370657
2008-06-24 08:09:35 +00:00
Jonathan Gordon
bdbdb97f19 FS#9051 - remove LCD margins... use viewports if you need them...
NOTE to WPS people....
%m has been removed, but (i think) because of the other %m tags it wont fail if you try loading a wps with %m|..|, it will just be ignored.
Also note that if the statusbar is enabled the default viewport is 8 pixels shorter than when its not, i.e (0,0) is really (0,8) if the statusbar is shown... I dont think this will be a major issue because almost no WPS show the bar and use bitmaps... text only WPS shouldnt be affected.

Please report problem screens in http://forums.rockbox.org/index.php?topic=17358.0


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17763 a1c6a512-1295-4272-9138-f99709370657
2008-06-23 13:20:35 +00:00
Jonathan Gordon
082f50b947 fix yellow
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17760 a1c6a512-1295-4272-9138-f99709370657
2008-06-23 06:17:22 +00:00
Jonathan Gordon
5a169bb717 commit FS#9027 - conditional viewports
** BREAKS CURRENT WPS's  **
* %P has been removed, merged with the new %pb
* %pb is now %pb or %pb|bitmap|x|y|width|height| (any of those params can be - to use sane defaults... check wiki/task for more explaination)

* New %Vl and %Vd tags which are used to setup and display conditionaly displayed viewports (%Vl|<id>|<usual %V params>| to set up, then %Vd<id> to enable the viewport
* bumps the max allowed viewport count to 24
* you can setup 3 different progressbars in a WPS... max of one per viewport though

http://www.rockbox.org/tracker/task/9027?getfile=16785 is a simple perl script to convert old %P/%pb to the new %pb syntax

I'll commit changes to the cabbie wps soon which shows how to use %Vl/%Vd properly...

Reminder: %m will be removed soonish also so when fixing your WPS's remember to use conditional viewports to replace %m


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17759 a1c6a512-1295-4272-9138-f99709370657
2008-06-23 06:04:17 +00:00
Jonathan Gordon
6653072292 bah, fix yellow
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17758 a1c6a512-1295-4272-9138-f99709370657
2008-06-23 02:57:24 +00:00
Jonathan Gordon
4982b87b9c fix FS#9098 - fade was updating the WPS sometimes when it shouldnt. also minor code policing.. use true/false instead of 1/0 for calls to fade()
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17757 a1c6a512-1295-4272-9138-f99709370657
2008-06-23 02:45:55 +00:00
Jonathan Gordon
5c416ae855 "Fix" FS#7887 - the line selector colours would be completly wrong on scrolling lines.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17725 a1c6a512-1295-4272-9138-f99709370657
2008-06-15 13:12:26 +00:00
Jonathan Gordon
23bca7e400 fix FS#5821 and FS#8449 - WPS isnt updated during fade, play status isnt changed to pause fast enough.
not sure if this is the best fix, wondering why fade() is handled by the wps code and not playback....


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17723 a1c6a512-1295-4272-9138-f99709370657
2008-06-15 11:22:44 +00:00
Jonathan Gordon
ae49b387bf Accept FS#9075 and rename valid_vals to set_vals
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17698 a1c6a512-1295-4272-9138-f99709370657
2008-06-07 09:01:02 +00:00
Maurus Cuelenaere
4bbdc5c3a3 Fix yellow
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17696 a1c6a512-1295-4272-9138-f99709370657
2008-06-06 18:44:59 +00:00
Maurus Cuelenaere
e1753de41a 1) Implement generic touchscreen detection library for the plugins
2) Adapt minesweeper, pegbox & calculator to it
3) Simplify gui/bitmap/list.c


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17695 a1c6a512-1295-4272-9138-f99709370657
2008-06-06 18:29:46 +00:00
Magnus Holmgren
c2416bf8b9 Fix typo in the new default values for %V, so that the background color is actually set on 16-bit targets.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17692 a1c6a512-1295-4272-9138-f99709370657
2008-06-05 15:21:08 +00:00
Jonathan Gordon
f002b7d055 make %V a little simpler. only the x and y values have to be specified now (i.e %V|0|0|||||| )
default values are as follows:
width - lcd width - the x value
height - lcd height - y value
font - user font
fg colour - the themes fg colour on 16bit targets, black on greyscale targets
bg colour - the themes bg colour on 16bit targets, white on greyscale targets



git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17690 a1c6a512-1295-4272-9138-f99709370657
2008-06-05 08:20:39 +00:00
Maurus Cuelenaere
75cac2c604 Fix some mistakes
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17678 a1c6a512-1295-4272-9138-f99709370657
2008-06-02 18:59:32 +00:00
Maurus Cuelenaere
cad30d334c 1) Make touchscreen interface more intuitive
2) Comment the code


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17676 a1c6a512-1295-4272-9138-f99709370657
2008-06-02 16:08:01 +00:00
Maurus Cuelenaere
5dca53eeb0 Even more touchscreen improvements.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17673 a1c6a512-1295-4272-9138-f99709370657
2008-06-01 13:56:34 +00:00
Maurus Cuelenaere
995b71a51d Some more touchscreen gui list improvements.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17672 a1c6a512-1295-4272-9138-f99709370657
2008-06-01 13:37:33 +00:00
Maurus Cuelenaere
944219bb77 (Simulator) Touchscreen improvements.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17662 a1c6a512-1295-4272-9138-f99709370657
2008-05-30 22:55:24 +00:00
Peter D'Hoye
f76122f0e7 Accept FS #9052 by Alexander Levin with a fix by me. Changes HAS_BUTTONBAR into HAVE_BUTTONBAR to bring it in line with the other defines
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17655 a1c6a512-1295-4272-9138-f99709370657
2008-05-29 20:32:39 +00:00
Jonathan Gordon
0792596e17 the splash should set the viewport to NULL untill we start passing it a vp. (not any time soon though)
"fix" FS#9044 by changing the delete dir screen to use the splash instead so it doesnt have to worry about the statusbar 
height


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17654 a1c6a512-1295-4272-9138-f99709370657
2008-05-29 14:40:12 +00:00
Jonathan Gordon
0501fb016c total removal of gui_textarea. The only thing using the text_message struct is the yesno screen so move its definition to yesno.h
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17653 a1c6a512-1295-4272-9138-f99709370657
2008-05-29 11:13:46 +00:00
Jonathan Gordon
43f0770943 move the HAS_BUTTONBAR define to the config-<target>.h files
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17652 a1c6a512-1295-4272-9138-f99709370657
2008-05-29 09:14:32 +00:00
Jonathan Gordon
fd3b46c22c draw the buttonbar in its own viewport. It always uses the sysfont and is drawn on the bottom.
Callers need to remeber to fiddle with their viewports to not be overwritten by the bar.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17651 a1c6a512-1295-4272-9138-f99709370657
2008-05-29 08:59:57 +00:00
Jonathan Gordon
ff469ab573 Updated recording trigger screen (seems to be a feature almost noone uses?)
problems/complaints in http://forums.rockbox.org/index.php?topic=16837.0
there is a known issue that on this screen the stop icon wont update, I dont know why and noone else wants to look at it, so hopefully this will force another set of eyes on it.. this is only a graphical issue... recordings still work fine


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17643 a1c6a512-1295-4272-9138-f99709370657
2008-05-28 10:55:39 +00:00
Jonathan Gordon
cdf18bf388 callbacks were being called with the old value.. spotted in IRC last week
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17641 a1c6a512-1295-4272-9138-f99709370657
2008-05-28 10:41:07 +00:00
Peter D'Hoye
f2d7270b70 Fix FS #9022: space reserved for the icons in the quickscreen used the incorrect constant
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17616 a1c6a512-1295-4272-9138-f99709370657
2008-05-23 21:20:05 +00:00
Jonathan Gordon
32db049a2a fix FS#9020 and make scrolling down in lists a bit more consistant with scrolling up
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17602 a1c6a512-1295-4272-9138-f99709370657
2008-05-22 06:23:15 +00:00
Bertrik Sikken
9244259f08 Make list.c use button_queue_count() instead of accessing the button_queue directly.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17587 a1c6a512-1295-4272-9138-f99709370657
2008-05-20 19:41:48 +00:00
Nils Wallménius
a21004dee6 Fix FS#9010 warning in checkwps when building on an amd64 machine
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17582 a1c6a512-1295-4272-9138-f99709370657
2008-05-19 14:37:16 +00:00
Jonathan Gordon
3e5b38945c const raid in option_select
add table settings and fix int settings with negative step in option_select_next_val
bump plugin API and sort newer functions


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17520 a1c6a512-1295-4272-9138-f99709370657
2008-05-15 06:58:36 +00:00
Nils Wallménius
111c999756 Delete whitespace to make 'Id' keyword behave as desired
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17501 a1c6a512-1295-4272-9138-f99709370657
2008-05-14 08:52:19 +00:00
Steve Bavin
71fa58985f Oops, forgot one.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17475 a1c6a512-1295-4272-9138-f99709370657
2008-05-12 18:05:06 +00:00
Steve Bavin
ad95df2cab Const police raid.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17474 a1c6a512-1295-4272-9138-f99709370657
2008-05-12 17:52:50 +00:00
Jonathan Gordon
95be4febc8 doh! fix yellow.
remove the calls to stop_scroll(), clear_viewport() does that

nothing should be using screens[].nb_lines anymore... change the list code to be a good example. (playlist_viewer is the last thing using it which needs fixing)



git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17456 a1c6a512-1295-4272-9138-f99709370657
2008-05-11 14:08:46 +00:00
Jonathan Gordon
aff220c9f5 and the time/date screen...
also change the order the yes/no screen clears the viewport.. stop_scroll should be called before clear or you might get artifacts


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17455 a1c6a512-1295-4272-9138-f99709370657
2008-05-11 13:59:27 +00:00
Jonathan Gordon
10df05438e more textarea to viewport conversion... yes/no screen...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17454 a1c6a512-1295-4272-9138-f99709370657
2008-05-11 13:39:22 +00:00
Nils Wallménius
fc25f3f61b Binsize optimization for targets without lcd remotes, whitespace/long lines police
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17453 a1c6a512-1295-4272-9138-f99709370657
2008-05-11 10:28:52 +00:00
Bertrik Sikken
7835a20347 Prototype declaration strictness fixes.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17424 a1c6a512-1295-4272-9138-f99709370657
2008-05-08 20:37:26 +00:00
Nicolas Pennequin
357ffb3c46 Convert the whole codebase to UTF-8, except docs/COMMITTERS and tools/creative.c, which need checking.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17369 a1c6a512-1295-4272-9138-f99709370657
2008-05-05 10:32:46 +00:00
Nicolas Pennequin
ef5fa8eaf5 Restore Zagor's copyright from before the WPS tokenizer. I shouldn't have removed it. Also add mine in playback.c, alongside Slasheri's.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17368 a1c6a512-1295-4272-9138-f99709370657
2008-05-05 09:40:22 +00:00
Jonathan Gordon
8e57ede59f move the pitchscreen out of screens.c.. no functional changes
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17365 a1c6a512-1295-4272-9138-f99709370657
2008-05-05 07:07:19 +00:00
Stéphane Doyon
7e86e5d866 Polish voicing of quickscreen: make it like in FS#6171: announce
"quickscreen" on entering, announce when leaving, say option name
when changing values in case the user isn't entirely familiar with
the layout...


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17358 a1c6a512-1295-4272-9138-f99709370657
2008-05-04 15:02:46 +00:00
Stéphane Doyon
ab0f7e17ef Accept FS#6188: study mode.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17355 a1c6a512-1295-4272-9138-f99709370657
2008-05-04 13:47:58 +00:00
Jonathan Gordon
1ef5a836f8 doh! those talk functions dont check the setting (which for some reason I thought they did).. shut the quickscreen up if talk is disabled
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17354 a1c6a512-1295-4272-9138-f99709370657
2008-05-04 13:39:54 +00:00
Jonathan Gordon
daa8341a13 a bit of code cleanup.. use a single function to get the statusbar height (or lack of if its enabled), and remove some gui_textarea stuff which could be done using the splash. (gui_textarea is on the way out)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17350 a1c6a512-1295-4272-9138-f99709370657
2008-05-04 10:58:05 +00:00
Jonathan Gordon
39bccd65b9 recommit the talking quickscreen... silly rename bug which I mised this morning
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17348 a1c6a512-1295-4272-9138-f99709370657
2008-05-04 08:11:28 +00:00
Stéphane Doyon
49a73ca90f Revert r17345 on jdgordon's request, until we figure out why it crashes my x5.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17346 a1c6a512-1295-4272-9138-f99709370657
2008-05-04 02:57:30 +00:00
Jonathan Gordon
dd4e3848b8 make the quickscreen talk
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17345 a1c6a512-1295-4272-9138-f99709370657
2008-05-04 02:11:24 +00:00
Jonathan Gordon
b234ef29b6 make the quickscreen not block so the statusbar gets updated
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17343 a1c6a512-1295-4272-9138-f99709370657
2008-05-04 01:42:11 +00:00