Nyaaori/rockbox
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
13305 commits 17 branches 142 tags 291 MiB
Commit graph

356 commits

Author SHA1 Message Date
Nicolas Pennequin
aa220d5acd Trim a bunch of long lines and fix an infinite loop and buffer overrun in the impossible case that a WPS line ends with a litteral string but without a newline char (wps_parser.c:774). 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13306 a1c6a512-1295-4272-9138-f99709370657
 2007-05-02 17:51:01 +00:00
Magnus Holmgren
05a158ecf3 Treat empty strings as 'no value' in conditionals, as it used to. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13304 a1c6a512-1295-4272-9138-f99709370657
 2007-05-02 16:28:24 +00:00
Nicolas Pennequin
378a140ae2 Add a check for unclosed conditionals at the end of the WPS parsing in case we didn't reach the end of the file. Also a few minor other changes. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13303 a1c6a512-1295-4272-9138-f99709370657
 2007-05-02 11:39:46 +00:00
Peter D'Hoye
3494b2118b FS #7093 by Dave Hooper: prevent crash when loading too many/long static strings in the wps 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13302 a1c6a512-1295-4272-9138-f99709370657
 2007-05-01 23:36:15 +00:00
Nicolas Pennequin
7e6af1532b Better handling of strings in the WPS parser by detecting duplicates to avoid having two copies of the same string in the string buffer. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13295 a1c6a512-1295-4272-9138-f99709370657
 2007-04-30 14:08:58 +00:00
Jonathan Gordon
39a6b5d643 Stop using the old menu API in the debug menu (using the new api causes massive bin increase, so fake the old api with existing code instead) (onplay.c and plugins are the only parts using th eold api now) 
Fix a bug where the menu title was sometimes shown in the system font


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13286 a1c6a512-1295-4272-9138-f99709370657
 2007-04-29 15:31:43 +00:00
Nicolas Pennequin
1cf2ec38b1 Change some ifdefs for the recent backdrop changes (fixes the yellow builds) and move the backdrop files. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13265 a1c6a512-1295-4272-9138-f99709370657
 2007-04-25 22:08:00 +00:00
Nicolas Pennequin
7fdfa56454 Add backdrop support for LCD remotes with depth > 1-bit. Only WPS backdrops, but the groundwork is laid for main backdrops too (all that's really needed are menus to set/clear them). 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13263 a1c6a512-1295-4272-9138-f99709370657
 2007-04-25 21:44:56 +00:00
Nicolas Pennequin
2a2b8d8a82 Make bitmaps use the right format in a RWPS and prevent a backdrop tag in a RWPS from clearing the main display's backdrop. This also allows future backdrop support for LCD remotes by making the parsing code aware of whether the display for a WPS is a remote or not. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13261 a1c6a512-1295-4272-9138-f99709370657
 2007-04-25 13:09:56 +00:00
Nicolas Pennequin
6ac306a515 Add a new commandline switch to the simulator: "--debugwps". It enables printing of advanced (and very verbose) WPS debugging information. Also make the debugging code a bit cleaner. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13257 a1c6a512-1295-4272-9138-f99709370657
 2007-04-24 23:58:57 +00:00
Nicolas Pennequin
d7fd989319 WPS Parser: On parse failure, print a (hopefully) useful error message with line number (sim only). 
Also the debug code is still  disabled but now in a nicer way.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13251 a1c6a512-1295-4272-9138-f99709370657
 2007-04-24 00:57:04 +00:00
Jens Arnold
6bf86b799e Ooooops, fix warning. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13243 a1c6a512-1295-4272-9138-f99709370657
 2007-04-22 12:48:05 +00:00
Jens Arnold
5070f41bfc Consolidated several potential places of return from WPS into one. Fixes the 'Return from WPS at end of playlist always brings up the root menu.' bug on hwcodec. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13241 a1c6a512-1295-4272-9138-f99709370657
 2007-04-22 12:38:11 +00:00
Jonathan Gordon
9d3694ced6 Fix FS#7056 - dont display garbage if the viewer icon set and the main iconset have different icon heights 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13237 a1c6a512-1295-4272-9138-f99709370657
 2007-04-22 08:50:24 +00:00
Nicolas Pennequin
814d402d4c More strict WPS parsing and displaying code. If there are errors, WPS loading will fail and the default WPS will be displayed. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13236 a1c6a512-1295-4272-9138-f99709370657
 2007-04-21 19:31:46 +00:00
Michael Sevakis
26d242ae65 General housekeeping: Make plugin buffer functions take size_t * instead of int * to match the parameter type of the buffer functions called in the core. Get rid of unsafe int * <==> size_t * casting. Use ssize_t where int was used and size_t where unsigned int was used in the buffer calls to not alter signedness in the plugins. No API version change since it should only be an issue for 64-bit sim builds. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13233 a1c6a512-1295-4272-9138-f99709370657
 2007-04-21 18:38:25 +00:00
Jonathan Gordon
7f3c66f1cb Fix the playlist viewer so only 1 line flashes when you move a track 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13231 a1c6a512-1295-4272-9138-f99709370657
 2007-04-21 11:14:57 +00:00
Magnus Holmgren
392a4ef49b Fix logf builds on devices that support remotes. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13202 a1c6a512-1295-4272-9138-f99709370657
 2007-04-18 17:49:32 +00:00
Jonathan Gordon
36a2e30872 Move the inbuilt filetype info into filetypes.c and rename the defines. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13201 a1c6a512-1295-4272-9138-f99709370657
 2007-04-18 13:03:01 +00:00
Jonathan Gordon
e9610dca80 Remove unneeded #include, comment the filename define 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13193 a1c6a512-1295-4272-9138-f99709370657
 2007-04-17 08:37:01 +00:00
Jonathan Gordon
754d9195f7 explicitly set *loaded_ok = false; when given "" for a filename. 
remove icon_init from the startup sequence, its not dependant on filetypes_init anymore,settings_apply calls the icons_init (causes the bmp's to only be read once on boot instead of twice)


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13191 a1c6a512-1295-4272-9138-f99709370657
 2007-04-17 06:37:22 +00:00
Jens Arnold
79a8b41513 Fix loadable remote icons. fb_data != fb_remote_data ... 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13190 a1c6a512-1295-4272-9138-f99709370657
 2007-04-17 01:03:25 +00:00
Jens Arnold
f87eaf3c4e Fix non-working default viewer icons. Remote viewer icons work now, but still not properly. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13189 a1c6a512-1295-4272-9138-f99709370657
 2007-04-17 00:29:04 +00:00
Jens Arnold
ded87cfcf5 Fix yellow... 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13188 a1c6a512-1295-4272-9138-f99709370657
 2007-04-17 00:08:58 +00:00
Jens Arnold
539c513fe6 Temporary fix for remote bitmap functions in the multi-screen API. Fixed icon.c to use this. Also fixed crash due to missing assignment of lcd_bitmap[_part] for monochrome main LCDs. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13187 a1c6a512-1295-4272-9138-f99709370657
 2007-04-16 23:55:19 +00:00
Magnus Holmgren
62994d42a7 Reduce code size a bit. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13185 a1c6a512-1295-4272-9138-f99709370657
 2007-04-16 19:17:37 +00:00
Jonathan Gordon
a9c1df4001 * its name[rows][columns] you drongo! 
* make custom viewer icons work slightly better
* minor nit-picks to keep crop happy
* create a /.rockbox/themes/default_rockbox_icons.cfg to restore the default icons easily


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13183 a1c6a512-1295-4272-9138-f99709370657
 2007-04-16 14:33:29 +00:00
Jonathan Gordon
b6658bbeef Santiy check shouldnt have been commented out 
Show the ? icon on the remote if the requested icon (from a .icons file) isnt in the remote viewer iconset


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13182 a1c6a512-1295-4272-9138-f99709370657
 2007-04-16 12:50:01 +00:00
Jonathan Gordon
4a16739bdd Some gremlins got into my computer again and changed all my code! 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13181 a1c6a512-1295-4272-9138-f99709370657
 2007-04-16 12:26:49 +00:00
Jonathan Gordon
ccaf24a29c Fix the wavplay icon 
Fix copy+paste mistake
Fix typo in comment
Fix crash when trying to run a bmp
Reset the icons properly when loading a .icons file (hopefully will use the correct icon now)


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13179 a1c6a512-1295-4272-9138-f99709370657
 2007-04-16 11:01:41 +00:00
Jonathan Gordon
6a5cc0bd25 Customizable icons for all bitmap targets. (FS#7013) 
http://www.rockbox.org/twiki/bin/view/Main/CustomIcons for info on format and how to load them


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13177 a1c6a512-1295-4272-9138-f99709370657
 2007-04-16 09:14:36 +00:00
Jens Arnold
ce05addf52 Revert recording/repeat timer for now. It is useful as a feature, but didn't receive enough testing on multiple targets, and fixing it is non-trivial. Later reversal would be complicated because of .lng spreading. * The patch should probably redone in a different way, as it's huge for what it does... * Issues: (1) The repeat timer setting has NULL pointer hits. (2) The multi-int setting screen breaks with proportional fonts, and with somewhat larger fonts. (3) On some targets, all values except the leftmost one are unreachable. * Hint: The timer itself would be much simpler if it'd just store & compare ticks (497 days before it wraps). 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13172 a1c6a512-1295-4272-9138-f99709370657
 2007-04-15 22:16:28 +00:00
Nicolas Pennequin
49cf05cb91 Hopefully fix the 64-bit warning. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13171 a1c6a512-1295-4272-9138-f99709370657
 2007-04-15 22:11:53 +00:00
Miika Pekkarinen
f53a8f8cd4 Added autoscore tag (%ra) to wps. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13169 a1c6a512-1295-4272-9138-f99709370657
 2007-04-15 15:46:46 +00:00
Miika Pekkarinen
1c0f41447a Reverted FS#6949 as we have a strict policy against anonymous contributions. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13168 a1c6a512-1295-4272-9138-f99709370657
 2007-04-15 15:38:08 +00:00
Martin Scarratt
49952325c9 Recording countdown timer and repeat timer - see FS #6297 for more details 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13165 a1c6a512-1295-4272-9138-f99709370657
 2007-04-15 13:56:21 +00:00
Miika Pekkarinen
3c6e46ce64 FS#6949 - WPS tag for database autoscore. Author wanted to remain anonymous. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13164 a1c6a512-1295-4272-9138-f99709370657
 2007-04-15 13:50:07 +00:00
Nicolas Pennequin
483c87a04d Oops, the condition was wrong. Sorry about that :) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13163 a1c6a512-1295-4272-9138-f99709370657
 2007-04-15 03:26:26 +00:00
Nicolas Pennequin
2e1169bdda * Make the WPS parser close open conditionals on new sublines and comments as well as new lines. 
* Make the displaying code check for invalid conditional constructs in order to avoid some rare cases of infinite looping.
* Make the WPS parser check that it doesn't read more strings than it can.
* Increase the string buffer size (from 512 to 1024, to accomodate the TextBox WPS which uses a lot of unicode characters).


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13162 a1c6a512-1295-4272-9138-f99709370657
 2007-04-15 02:59:34 +00:00
Nicolas Pennequin
32bd59d4f7 Better error checking for the image display tag (%xdn). Should prevent problems with the former crossfeed tag (%xd) when used in a conditional construct. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13158 a1c6a512-1295-4272-9138-f99709370657
 2007-04-14 16:20:33 +00:00
Jens Arnold
0b7bb31453 Simplification, queue pointers don't wrap (except at INT_MAX, but the calculation is still correct in this case). Implemented queue_count() for the simulator. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13154 a1c6a512-1295-4272-9138-f99709370657
 2007-04-14 09:47:47 +00:00
Marcoen Hirschberg
5d2b1e3cb3 rename ACTION_WPSAB_RESET to ACTION_WPS_ABRESET to be more consistent with the rest 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13142 a1c6a512-1295-4272-9138-f99709370657
 2007-04-13 15:42:25 +00:00
Nicolas Pennequin
2ea39db310 FS#7020. Make the behaviour of '#' more consistent. It now requires escaping by a '%' to be displayed. If it is not escaped, the following text will be interpreted as a comment (including the newline character). 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13140 a1c6a512-1295-4272-9138-f99709370657
 2007-04-13 11:43:10 +00:00
Jens Arnold
c05ee02312 Removed unused struct member from gui_synclist, and reordered struct members of gui_list for optimal packing. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13139 a1c6a512-1295-4272-9138-f99709370657
 2007-04-12 23:53:17 +00:00
Jens Arnold
47bf6c5a5a Moved archos backlight code to target tree. Changed old mutlivalue CONFIG_BACKLIGHT to a simple HAVE_BACKLIGHT. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13136 a1c6a512-1295-4272-9138-f99709370657
 2007-04-12 22:12:13 +00:00
Nicolas Pennequin
27cbf6bcea * Add the crossfade (%xf) WPS tag 
* Avoid eating the whole line when unsuccessfully parsing a %x or %xl tag. This will prevent unknown tags starting with %x from making the line disappear.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13127 a1c6a512-1295-4272-9138-f99709370657
 2007-04-12 16:15:34 +00:00
Jonathan Gordon
08e633c25c Hide the list title if only one line would fit under it 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13107 a1c6a512-1295-4272-9138-f99709370657
 2007-04-11 10:34:44 +00:00
Nicolas Pennequin
5cac46164a Use valid_time() instead of using individual checks which amount to the same thing, and add RTC tokens beginning and end values that are used to check if a token is an RTC one. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13096 a1c6a512-1295-4272-9138-f99709370657
 2007-04-10 15:27:52 +00:00
Nicolas Pennequin
536c5d9e74 RTC tags for the WPS: Accept FS#6998 and FS#7001 by Alexander Levin with changes by me. CUSTOM WPS FILES NEED TO BE UPDATED ! 
The RTC tags are now atomic, i.e. instead of using one tag with the format (e.g. %cd m yc), we use several separate tags, one for each value (e.g. %cd %cm %cy).
Also, %cP produces an uppercase AM/PM indicator and %cp a lowercase one, which is the opposite from what they did before.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13093 a1c6a512-1295-4272-9138-f99709370657
 2007-04-10 13:37:08 +00:00
Nicolas Pennequin
ad07c23a83 Accept FS#7004 by Michal Jevjak: Fix new sublines not being displayed after scrolling lines. This bug was introduced in the previous WPS commit. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13090 a1c6a512-1295-4272-9138-f99709370657
 2007-04-10 01:14:04 +00:00