Bertrik Sikken
2843469876
Moved atoi declaration to stdlib.h. Deleted atoi.h
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17280 a1c6a512-1295-4272-9138-f99709370657
2008-04-28 16:18:04 +00:00
Nils Wallménius
33c44461e1
Const police raid, making a lot of pointers to lang strings const and removing some ugly casting
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17251 a1c6a512-1295-4272-9138-f99709370657
2008-04-26 09:30:24 +00:00
Bertrik Sikken
db2d61f4ea
Killed unnecessary global variables by making them static.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17184 a1c6a512-1295-4272-9138-f99709370657
2008-04-20 10:24:15 +00:00
Magnus Holmgren
79fb077933
When looking for album art in /.rockbox/albumart/, use album artist rather than artist, if available.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17171 a1c6a512-1295-4272-9138-f99709370657
2008-04-19 15:21:09 +00:00
Nils Wallménius
a01996436d
Use file_exists and dir_exists functions where appropriate, fix one wrong file descriptor check and one possible dir descriptor leak
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17147 a1c6a512-1295-4272-9138-f99709370657
2008-04-16 19:51:43 +00:00
Nils Wallménius
6848961aa5
Pass the buffer length to the list_get_name callback functions instead of using hardcoded MAX_PATH
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17049 a1c6a512-1295-4272-9138-f99709370657
2008-04-09 15:25:17 +00:00
Steve Bavin
799e9489ca
Remove some more simulator debugging output.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17019 a1c6a512-1295-4272-9138-f99709370657
2008-04-07 17:19:53 +00:00
Dave Chapman
78d29f535f
Major cleanup of checkwps - fix all warnings and add a script to build versions for all supported targets (plus some unsupported ones). You now need to run the version of checkwps that matches the device your WPS is for.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16831 a1c6a512-1295-4272-9138-f99709370657
2008-03-26 23:35:34 +00:00
Dave Chapman
b9bb723f12
1) Make Rockbox reject any WPSs if there are errors loading any of the required bmps; 2) Make checkwps actually load the images using the Rockbox bmp loader, and reject the WPS in the same was as Rockbox on bmp errors.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16822 a1c6a512-1295-4272-9138-f99709370657
2008-03-26 18:18:22 +00:00
Jonathan Gordon
5ca1539969
the menu and list now accepts a parent viewport to draw in (and the menu can be told to not show status/button bars). This lays the groundwork to fix colour problems with plugin menus (see star.c for an example.) This hopefully fixes some button bar issues as well as theme problems.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16812 a1c6a512-1295-4272-9138-f99709370657
2008-03-26 03:35:24 +00:00
Dave Chapman
d02c79c03f
Commit viewports-in-WPS patch (FS#8385). This adds the %V tag - see the CustomWPS page for details (shortly...). There is still some work to do - decide how to handle font references, decide how to handle conditionals. Plus checkwps is broken - I'll fix that in a separate commit.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16733 a1c6a512-1295-4272-9138-f99709370657
2008-03-21 19:38:00 +00:00
Jens Arnold
8113717da9
Fix BMP loader for the iAudio M3 display.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16722 a1c6a512-1295-4272-9138-f99709370657
2008-03-20 17:40:58 +00:00
Jens Arnold
76614b3687
Make vkeyboard usable on M3.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16709 a1c6a512-1295-4272-9138-f99709370657
2008-03-18 22:59:39 +00:00
Peter D'Hoye
9c3f6c4079
Simplify that clip indicator reset code a bit
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16559 a1c6a512-1295-4272-9138-f99709370657
2008-03-08 20:32:37 +00:00
Peter D'Hoye
30ab1a3c0e
Reset recording clipping indicators when changing gain. Solves FS #6147
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16557 a1c6a512-1295-4272-9138-f99709370657
2008-03-08 17:43:04 +00:00
Peter D'Hoye
0ecdb37e99
Fix FS #8514 (remote peakmeter issue) by separating the peak release times for the screens. Thanks to amiconn for pointing in the right direction.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16234 a1c6a512-1295-4272-9138-f99709370657
2008-02-06 21:53:07 +00:00
Magnus Holmgren
2235081dbc
Prevent possible buffer overflow when locating album art.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16231 a1c6a512-1295-4272-9138-f99709370657
2008-02-06 19:51:19 +00:00
Nicolas Pennequin
cfe51b0cd1
Add a couple safety checks in search_albumart_files(). Should fix the sliding_puzzle crashes.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16225 a1c6a512-1295-4272-9138-f99709370657
2008-02-05 11:56:21 +00:00
Jonas Häggqvist
2cffb1bf3d
Look for albumart in .rockbox/albumart/<artist>-<album><size>.bmp in addition to the current locations.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16110 a1c6a512-1295-4272-9138-f99709370657
2008-01-19 18:05:06 +00:00
Nicolas Pennequin
536b5a0482
Accept FS#8469 by Bryan Childs with a few adjustments: Remove duplicate strip_extension() function from albumart.c. The other one is moved from tree.c to misc.c.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16103 a1c6a512-1295-4272-9138-f99709370657
2008-01-18 10:02:03 +00:00
Jonathan Gordon
4d238c14d7
bandaid fix for FS#8168 - statusbar would be enabled if poweroff happened while in fm screen. a proper fix is to not force the statusbar on in the fm screen, but untill that happens this is fine.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16044 a1c6a512-1295-4272-9138-f99709370657
2008-01-10 06:46:04 +00:00
Peter D'Hoye
db1e12bac0
Quick fix to prevent freezing of H10 (possibly others too) when left at the disk full message. Needs more investigation to find the cause of the freeze.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15938 a1c6a512-1295-4272-9138-f99709370657
2007-12-15 23:51:13 +00:00
Nicolas Pennequin
90ce826903
Initial commit of the PictureFlow plugin, a nice visualization for album covers.
...
Original code by Ariya Hidayat. Rockbox port by Jonas Hurrelmann and a few tweaks by me.
On the first startup the database is scanned and album art is searched for each album. This process will take some time (dircache enabled and/or database in RAM speed it up, and it is possible to abort by pressing MENU), but the results are cached and the next startups will be very quick.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15900 a1c6a512-1295-4272-9138-f99709370657
2007-12-09 18:48:02 +00:00
Peter D'Hoye
05007e1a79
More code police
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15890 a1c6a512-1295-4272-9138-f99709370657
2007-12-07 00:31:31 +00:00
Peter D'Hoye
327d78eb6e
Code police
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15889 a1c6a512-1295-4272-9138-f99709370657
2007-12-07 00:28:16 +00:00
Peter D'Hoye
a007b558b3
Fix gradient selection bar in recording screen
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15888 a1c6a512-1295-4272-9138-f99709370657
2007-12-07 00:07:30 +00:00
Jens Arnold
89bfb66939
BMP loader: Handle top-down BMP files (height is negative). Note that the e200 example pictures still don't work, as they are larger than the screen (not a loader problem).
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15855 a1c6a512-1295-4272-9138-f99709370657
2007-11-30 08:51:18 +00:00
Michael Sevakis
b0dd9eb5bc
Repair the no-spinup on start/split feature of recording. Recording directory selection broke it. Please only look at the disk during encoder loading opportunities in future additions.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15853 a1c6a512-1295-4272-9138-f99709370657
2007-11-30 05:14:57 +00:00
Linus Nielsen Feltzing
236cdaee03
Make the recording screen handle button repeats correctly when changing gain. Fixes FS#8038.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15811 a1c6a512-1295-4272-9138-f99709370657
2007-11-26 11:51:39 +00:00
Nils Wallménius
e711de2974
Make the variable for numbers of screens to update const on non-remote-lcd targets.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15806 a1c6a512-1295-4272-9138-f99709370657
2007-11-25 21:47:16 +00:00
Robert Kukla
ed64a663a0
make check_dir use dir_exists and slightly optimise the latter
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15744 a1c6a512-1295-4272-9138-f99709370657
2007-11-21 22:42:52 +00:00
Robert Kukla
d87b037efe
consolidate the 3 file_exists() functions into one; use the version that explicitly uses dircache; give dir_exists() the same treatment for consistency
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15742 a1c6a512-1295-4272-9138-f99709370657
2007-11-21 21:28:27 +00:00
Michael Sevakis
fadbf0a6f7
Make threads responsible for explicit cancellation of their own boosted status. Sleeping and timeouts will no longer cancel it.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15709 a1c6a512-1295-4272-9138-f99709370657
2007-11-20 03:44:25 +00:00
Magnus Holmgren
7aa4ae6e45
Improved use of album name when locating the album art file: replace chars that are invalid in file names; double quotes to single quotes, other invalid chars to underscore (now only very long album names could cause a problem). Also removed some unecessary code and reduced stack usage a bit.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15630 a1c6a512-1295-4272-9138-f99709370657
2007-11-15 20:22:03 +00:00
Nicolas Pennequin
1480d078e7
Add an error check, just to be safe.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15596 a1c6a512-1295-4272-9138-f99709370657
2007-11-12 14:26:47 +00:00
Nicolas Pennequin
81dedee7d0
Various album art improvements:
...
* Make the album art display tag static instead of dynamic, making it be drawn less often, which is good.
* Add the possibility of clearing the album art bitmap instead of drawing it, and use this abaility when the display tag is inside a conditional construct.
* Add the album art display tag to wps_debug.c.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15592 a1c6a512-1295-4272-9138-f99709370657
2007-11-12 01:31:42 +00:00
Barry Wardell
c495cdae59
FS#8046: H10 FM tuner support. Thanks to Przemyslaw Holubowski for doing the hard work in figuring out how to communicate with the tuner.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15578 a1c6a512-1295-4272-9138-f99709370657
2007-11-11 16:00:33 +00:00
Nicolas Pennequin
9d4bed7ff0
Album art support. Based on FS#3045, but heavily modified to adapt to MoB and for cleanness.
...
The cover pictures are loaded from external bitmaps. JPEG and embedded art are not supported. The pictures will only be drawn on the main display. There is no resizing but it is possible to specify the WPS bitmap size in the bitmap names (e.g. cover.100x100.bmp).
The bitmaps are stored in the main buffer and read directly from there. Currently, duplicate bitmaps will simply be present several times in the buffer, but this will be improved.
To enable for a target, #define HAVE_ALBUMART in its config file.
For more information, see the wiki page: http://www.rockbox.org/wiki/AlbumArt .
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15572 a1c6a512-1295-4272-9138-f99709370657
2007-11-11 12:29:37 +00:00
Nicolas Pennequin
ec6569ed22
Add read_bmp_fd and make the first parameter of read_bmp_file ("filename") const.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15553 a1c6a512-1295-4272-9138-f99709370657
2007-11-10 13:26:11 +00:00
Stéphane Doyon
d65f9f15f9
More voice for the radio: accept FS#6331.
...
In the radio screen, speak the mode (preset or scan) when switching mode.
When switching stations with the radio paused/muted, speak the current
preset (number, frequency if preset is default, or spell, depending
on talk_file setting). Also says the frequency if in scan mode.
Change the default preset created by autoscan to be an empty string; change
the preset menu callback to substitute the frequency when the preset name
is empty.
Add a voice callback for the preset menu.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15507 a1c6a512-1295-4272-9138-f99709370657
2007-11-07 02:14:28 +00:00
Steve Bavin
31a2f33eb8
Mop up some yellow.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15207 a1c6a512-1295-4272-9138-f99709370657
2007-10-19 15:43:43 +00:00
Steve Bavin
32a9575130
FS#7994 - Rename talk.c API, make talk_disable() affect all talking (not just menus), hopefully save some space.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15206 a1c6a512-1295-4272-9138-f99709370657
2007-10-19 15:31:42 +00:00
Jens Arnold
8b44601a7c
Disable highperf mode in the peakmeter for swcodec targets, as it makes no sense. Improves responsiveness a lot with a peakmeter-enabled wps on targets with slow lcd updates (e.g. G5). Added a comment why highperf mode is needed for MAS targets.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15140 a1c6a512-1295-4272-9138-f99709370657
2007-10-16 08:34:51 +00:00
Jens Arnold
9afdf99212
Add the vkeyboard line end beep to (swcodec) targets with non-modal keyboard. * Select modal keyboard and enable morse mode for iPod 1st/2nd gen.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15066 a1c6a512-1295-4272-9138-f99709370657
2007-10-10 06:19:54 +00:00
Jens Arnold
064de4ce4d
Slight code policing.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15065 a1c6a512-1295-4272-9138-f99709370657
2007-10-10 06:02:08 +00:00
Jens Arnold
100d343963
Fix red Ondio builds. Hwcodec targets can't beep that way, so disable that beep for them.* Port the other vkeyboard enhancements (fixed character spelling and edit mode announcement) to the charcell vkeyboard (Player).
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15064 a1c6a512-1295-4272-9138-f99709370657
2007-10-10 05:56:53 +00:00
Stéphane Doyon
1b89d588e1
Accessible keyboard: guard the beep with talk_menus_enabled()
...
rather than the beep setting from the playback settings.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15062 a1c6a512-1295-4272-9138-f99709370657
2007-10-10 03:57:42 +00:00
Stéphane Doyon
d529a3845b
Make the virtual keyboard easier to use for blind users.
...
From FS#6324
When moving up/down and landing on the edit line, say "edit". Otherwise
it gets quite confusing.
When moving left and right on the edit line, sound a beep when the left
or right end is reached.
Before, it would say nothing either when the cursor is over a blank or
a char it doesn't know how to spell. So if we're on a blank spot, say
"blank".
Pass the whole utf8 char to be spelled.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15060 a1c6a512-1295-4272-9138-f99709370657
2007-10-10 02:28:58 +00:00
Stéphane Doyon
0279c71a92
Voice the recording trigger settings screen.
...
From FS#6325, with a slight coding improvement.
Also take out a duplicated snprintf in there.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15059 a1c6a512-1295-4272-9138-f99709370657
2007-10-10 01:41:48 +00:00
Stéphane Doyon
5acf091046
Add a voice callback to dynamic menus, along side the text_callback.
...
From FS#7563.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15042 a1c6a512-1295-4272-9138-f99709370657
2007-10-09 03:48:56 +00:00