Commit graph

140 commits

Author SHA1 Message Date
Ryan Jackson
0812164ada Fixed track changing in REPEAT_ONE mode and playlists with only one track. Removed previous workaround for this bug.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7284 a1c6a512-1295-4272-9138-f99709370657
2005-08-05 23:51:48 +00:00
Miika Pekkarinen
637887838f Fixed a hang with backward skipping.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7269 a1c6a512-1295-4272-9138-f99709370657
2005-07-30 20:46:38 +00:00
Ryan Jackson
1476fecf72 All repeat modes now work correctly if there is only one track in the playlist. Fixed a track-changing bug in 'Move to Next Folder' mode that could cause Rockbox to crash.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7268 a1c6a512-1295-4272-9138-f99709370657
2005-07-30 19:36:06 +00:00
Miika Pekkarinen
05820cbc07 Now playlist ending and skipping to a next directory should work.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7267 a1c6a512-1295-4272-9138-f99709370657
2005-07-30 18:47:12 +00:00
Miika Pekkarinen
47c82f295b Fixed a problem that wps didn't exit at end of the playlist.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7266 a1c6a512-1295-4272-9138-f99709370657
2005-07-30 18:25:27 +00:00
Miika Pekkarinen
7e58bd7cb8 Correctly setting the last_index to prevent playback stuttering.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7264 a1c6a512-1295-4272-9138-f99709370657
2005-07-30 17:53:56 +00:00
Miika Pekkarinen
4633d01eaf Now removing right tracks from playlist.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7263 a1c6a512-1295-4272-9138-f99709370657
2005-07-30 17:41:26 +00:00
Miika Pekkarinen
fd7952e413 Fixed a hang on track changed. Automatically deleting invalid track
entries from current playlist.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7262 a1c6a512-1295-4272-9138-f99709370657
2005-07-30 17:00:06 +00:00
Ryan Jackson
b301b43825 Added comments, Replay Gain, and resume/bookmarks for FLAC.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7253 a1c6a512-1295-4272-9138-f99709370657
2005-07-28 18:43:33 +00:00
Ryan Jackson
795ce8b1a8 Changing tracks in REPEAT_ONE mode restarts the current track instead of crashing
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7232 a1c6a512-1295-4272-9138-f99709370657
2005-07-24 04:17:34 +00:00
Miika Pekkarinen
7fa9f603e2 Fixed a hang while selecting a new track and playback was paused. This
was probably my last commit within the next three weeks, see you around!


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7230 a1c6a512-1295-4272-9138-f99709370657
2005-07-23 16:09:50 +00:00
Miika Pekkarinen
ae5002d1da Fixed the backwards skipping problem.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7229 a1c6a512-1295-4272-9138-f99709370657
2005-07-23 08:48:10 +00:00
Miika Pekkarinen
e0d17510d9 Show a nice splash screen when restarting the playback.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7225 a1c6a512-1295-4272-9138-f99709370657
2005-07-22 16:57:08 +00:00
Miika Pekkarinen
90161c92dd It's now possible to select the crossfading mode: "Off, Crossfade,
Mix". If set to mix, no fading is applied but tracks are mixed up.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7224 a1c6a512-1295-4272-9138-f99709370657
2005-07-22 16:46:27 +00:00
Miika Pekkarinen
eab434c416 More accurate playback position calculation.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7218 a1c6a512-1295-4272-9138-f99709370657
2005-07-22 06:32:55 +00:00
Miika Pekkarinen
857ee67b6a Fixed the unnecessary compiler warning.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7215 a1c6a512-1295-4272-9138-f99709370657
2005-07-21 16:16:30 +00:00
Miika Pekkarinen
ab2163bdf5 Fixed the crossfade setting: Resuming stopped playback automatically
when changing values, setting crossfade amount correctly and pcm
drivers should not be re-initialized.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7214 a1c6a512-1295-4272-9138-f99709370657
2005-07-21 15:47:29 +00:00
Miika Pekkarinen
f090dc3829 Crossfade (and pcm buffer size) length is now configurable.
Implemented anti-skip buffer setting for iriver also. Settings block
bumped up, PLEASE SAVE YOUR SETTINGS BEFORE UPGRADING.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7210 a1c6a512-1295-4272-9138-f99709370657
2005-07-21 11:44:00 +00:00
Miika Pekkarinen
5755ffe60c Fixed the backwards skipping.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7207 a1c6a512-1295-4272-9138-f99709370657
2005-07-20 18:50:07 +00:00
Miika Pekkarinen
bd1131e748 Implemented mp3_pause_done() for software codecs to make wps correctly
wait for pause to complete when fading the volume.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7205 a1c6a512-1295-4272-9138-f99709370657
2005-07-20 01:58:27 +00:00
Ryan Jackson
300fb882be No longer crashes when resuming or on shutdown in car adapter mode
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7204 a1c6a512-1295-4272-9138-f99709370657
2005-07-19 22:01:47 +00:00
Miika Pekkarinen
d83b659fa7 Fixed track changing problems.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7201 a1c6a512-1295-4272-9138-f99709370657
2005-07-19 19:57:23 +00:00
Miika Pekkarinen
f5df9cd81c Track count is now correct.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7185 a1c6a512-1295-4272-9138-f99709370657
2005-07-18 06:10:53 +00:00
Miika Pekkarinen
e361749fe2 Fixed a problem that caused codec switching to fail on certain rare
conditions.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7184 a1c6a512-1295-4272-9138-f99709370657
2005-07-17 21:44:58 +00:00
Miika Pekkarinen
cd8bfeb8a3 Fixed the gapless playback.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7180 a1c6a512-1295-4272-9138-f99709370657
2005-07-17 15:35:17 +00:00
Magnus Holmgren
08761aaa52 Restructured DSP code for readability and speed. Simplified the API.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7174 a1c6a512-1295-4272-9138-f99709370657
2005-07-16 12:25:28 +00:00
Miika Pekkarinen
cda55bbd6f Correctly read the next track metadata information. Don't crash if
frequency is ever set to 0.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7171 a1c6a512-1295-4272-9138-f99709370657
2005-07-16 06:26:29 +00:00
Miika Pekkarinen
2e884cc85f Revert back the previous commit, there are some problems with id3
fields to be solved.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7167 a1c6a512-1295-4272-9138-f99709370657
2005-07-15 21:37:03 +00:00
Miika Pekkarinen
54395bbf3d Don't read metadata twice.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7163 a1c6a512-1295-4272-9138-f99709370657
2005-07-15 21:13:13 +00:00
Miika Pekkarinen
b6048c49ba Don't hang when trying to stop paused playback.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7159 a1c6a512-1295-4272-9138-f99709370657
2005-07-15 18:42:01 +00:00
Miika Pekkarinen
34a25a6a3b Fixed a problem that caused playback to stutter when changing tracks
fast.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7157 a1c6a512-1295-4272-9138-f99709370657
2005-07-15 16:42:01 +00:00
Miika Pekkarinen
2159811c66 Fixed a problem that cpu boost didn't always reset when stopping the
playback.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7153 a1c6a512-1295-4272-9138-f99709370657
2005-07-15 07:57:09 +00:00
Miika Pekkarinen
20b3897474 Separated buffering stuff from pcm_playback to pcmbuf. Renamed some
function calls (audiobuffer -> pcmbuf etc.).


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7131 a1c6a512-1295-4272-9138-f99709370657
2005-07-13 12:48:22 +00:00
Ryan Jackson
d191756286 Resume now starts playback at the point it was stopped, not 2-7 seconds later.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7125 a1c6a512-1295-4272-9138-f99709370657
2005-07-12 16:45:38 +00:00
Miika Pekkarinen
2f6781d616 Resetting the pause indicator when seeking songs.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7109 a1c6a512-1295-4272-9138-f99709370657
2005-07-11 20:43:02 +00:00
Linus Nielsen Feltzing
c4b7c671f9 Patch #1235763 by Ryan Jackson - Resume/bookmark support for Vorbis
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7098 a1c6a512-1295-4272-9138-f99709370657
2005-07-11 06:47:35 +00:00
Miika Pekkarinen
0d63cbba4b Fixed a problem with transition to next album which caused rockbox
virtually to crash.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7096 a1c6a512-1295-4272-9138-f99709370657
2005-07-10 20:37:36 +00:00
Miika Pekkarinen
1ed292ca5e Fixed an audio burst coming out when pausing a track with fading
enabled.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7095 a1c6a512-1295-4272-9138-f99709370657
2005-07-10 17:31:12 +00:00
Miika Pekkarinen
645a2e16ed Fixed a simulator crash while trying to play a song. Fixed crossfade
when selecting a new track to play. Most likely fixed a bug which
caused playback to stop on track change.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7094 a1c6a512-1295-4272-9138-f99709370657
2005-07-10 16:33:03 +00:00
Miika Pekkarinen
a9203b4d83 Updating wps info correctly when changing a track while buffering.
Fixed the delay while seeking.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7093 a1c6a512-1295-4272-9138-f99709370657
2005-07-10 08:54:19 +00:00
Miika Pekkarinen
527ce403ea The previous commit did not fix the metadata reading correctly. Now it
should have been fixed.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7092 a1c6a512-1295-4272-9138-f99709370657
2005-07-10 08:46:12 +00:00
Miika Pekkarinen
b288dda685 Fixed a problem that next track info was not always available after the
initial file buffering.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7091 a1c6a512-1295-4272-9138-f99709370657
2005-07-10 08:38:16 +00:00
Miika Pekkarinen
3e33f85f17 Track changing works now better (not still perfect).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7090 a1c6a512-1295-4272-9138-f99709370657
2005-07-10 06:58:02 +00:00
Miika Pekkarinen
5d9e0536ea Some playback fixes.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7076 a1c6a512-1295-4272-9138-f99709370657
2005-07-08 20:01:06 +00:00
Linus Nielsen Feltzing
df80798a30 Lame hack to strip ID3v1 tags from MP3 playback, so they can play back without gaps
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7054 a1c6a512-1295-4272-9138-f99709370657
2005-07-07 09:53:02 +00:00
Miika Pekkarinen
3eb962d13b PCM buffering fixes. Made a temporary workaround for playback glitch
bug (see the patch).


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7049 a1c6a512-1295-4272-9138-f99709370657
2005-07-07 07:15:05 +00:00
Linus Nielsen Feltzing
ffd207f4b0 Makes sure that the pause/resume/prev/next functions are executed in the audio thread
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7043 a1c6a512-1295-4272-9138-f99709370657
2005-07-06 19:40:17 +00:00
Miika Pekkarinen
22960c3f95 Waiting pcm buffer to run empty before stopping the last track.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7040 a1c6a512-1295-4272-9138-f99709370657
2005-07-06 15:44:59 +00:00
Miika Pekkarinen
5c2c991d14 Applied patch "[ 1232957 ] MP3 metadata fixes for software codec".
Thanks to Magnus Holmgren. Now metadata reading is better with
improved performance for mp3 files.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7030 a1c6a512-1295-4272-9138-f99709370657
2005-07-05 19:55:40 +00:00
Miika Pekkarinen
3e33a0f8ee More crossfade adjustments. Now crossfade should work shortly even if
the disk was not spinning while a new track was loaded from the disk.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7028 a1c6a512-1295-4272-9138-f99709370657
2005-07-05 15:51:59 +00:00