Add fallback to CONTEXT_STD and add explicit Play button cancel -
Play button is not present in standard context, so it won't do
anything if unknown actions are ignored.
tested on ipod simulator
Change-Id: Ic259fa97b6195ebbc66fcfae31265cc7aeefa421
This fixes a bug reported on IRC:
1. Set 'bookmark on stop' to 'ask'
2. Play a track from the file browser
3. Stop playback, yes/no screen briefly flashes then disappears.
The screen still handles input correctly but the prompt will not
be displayed on the LCD. Long story short, get_action() can cause
the skin engine to do a full redraw which cleared the screen and
erased the prompt.
There is a special event, GUI_EVENT_NEED_UI_UPDATE, which the list
code uses to avoid precisely this problem.
Hooking up a handler for this event and redrawing the yes/no prompt
fixes the bug.
Change-Id: If3c26655540c13b488b3a11bd46e1d60d4111469
These were deprecated by 1eb17dc9f4 back in 2013 just prior to the
3.13 release. We've had 3.14 and 3.15 since then and I guess nobody
will complain if we finally remove them (fingers crossed...)
Also fix a line which got missed when converting hardcoded numbers
to EQ_NUM_BANDS in that commit.
Change-Id: I79dd71f1f2810bf19bc135999868fafc5fee6e04
add a helper function to allow plugins to parse the parameter string
passed into plugins
support included for bool, char, string and numbers+decimals
Change-Id: I39f35c8bd3c21b83097a538c19f46d362c468fa4
'Bugfix' mono_bitmap_part reads ahead in the buffer,
if the height is <= char bit pixels other memory gets read
found with [Address Sanitizer]
also g#3332 since this is clearly a problem across the code
instead place the check for height < 8 in the lcd_mono_bitmap_part function
second try places the check above the negative y offset
this was causing glitches on the Q1 and likely other TS targets
since a negative y was added to height it made it < CHAR_BIT setting
stride = 0 even though the bitmap was >= CHAR_BIT high
Change-Id: I13bb8ab472c2ae61302a6de5d9e2c78243354460
The EQ enabled setting needs to call into the DSP core when it's
changed but this was only hooked into the EQ menu. The quickscreen
uses option_select_next_val() so those DSP hooks were not getting
called because the setting did not have any callback defined.
It seems this bug was introduced by 362f7a3220 removing the blanket
call to settings_apply(). Other settings might be affected too.
Change-Id: Idcce5809c525fa619e6bdf1be50c98a5df103fec
It's not yet working and because all storage is removable (and the OF
works fine) it's of limited utility aynway.
Change-Id: I8a6a59ac16503d0f4574c3934f473cac54e86858
* Power button is what forces entry into USB mode
(can't use the other buttons due to the long SADC warmup)
* Inching closer to working USB disk mode (starts then disconnects!
Change-Id: I45ff1c61f39e0e0c3615b38278f5c91b6ef2ed6c
share all the core icons with plugins
these are all small mono icons like usb plug icon or
play, fast forward, rewind icons
--include the icon_helper function
Change-Id: I385028815a4dd368515f491a9e19dee3d500252d
- Enable repeat for prev/next keys
- Provide a way to access the context menu using buttons
- Update the manual
Change-Id: I53a7474cc64f915851175aea0695229c581fd8a6
We want to load builtin filetypes and other config files even if
there is a problem loading viewers.config. A lot of menus expect
the builtin types to be there and don't work if they're missing.
Change-Id: Ie39c8b9ef184fe0d638bacbe18e5f2d22900bd81
* Fix a typo in a URL
* Note how to enter the OF from the bootloader
* Document how to perform a hard reset
Change-Id: I96d0d64cbd251573e1c5c55657ee5c5db510d9a6
* Rework the LCD initialization a bit
* Power off after 5 seconds if we hit a fatal error
* Turn on verbose output if PLAY is held down on powerup
* Minor code style cleanups
The goal is to not perform the LCD init unless it's needed; ie
only if we run into an error or enter USB mode.
Change-Id: I3f93e881ff55d104f453985ed452f35b433a7d99
* Explicitly clear the caches prior to launching the binary
* Ensure the function that launches the binary is in iram
* Re-sequenced some of the subsystem initializations
* Fixes for USB mode
Change-Id: Ie020b18586b2599edeb88529dd3d7337e33a5a6f
Fixes some names not showing in the manual.
Note that there's one name left not showing due to LaTeX unicode support
missing the characters.
Change-Id: I9f1d0d3d49b485be54c83486a23cf97c82d257c8
KOMAscript 3.28 changes \ifpdfoutput to \Ifpdfoutput. Add a check and
redefine the new command as the old one if it's missing since only the
name was changed. Not all Linux distros have a recent enough version
yet.
Change-Id: Ie709a1c85f10e1ddebb703ae50d3539f1aeee8bb
talk_value is just talk_value_decimal with 0 decimals
lets add the extended function instead
static inline int talk_val(long n, int unit, bool enqueue)
{
#define NODECIMALS 0
return rb->talk_value_decimal(n, unit, NODECIMALS, enqueue);
}
Change-Id: Iaba3d2f95785f2e1855e294ccf099a977bb6cb20
Compiling the plugins takes quite a long time and is unnecessary
if you're only working on the core code. Having an option is nicer
than having to edit the configure script by hand.
Change-Id: I401867355d897ce3fd899d9daf25ea9afcc380f0
It has only a couple GB of onboard flash storage with no storage
driver in Rockbox. It hasn't seen any meaningful development since
its initial commit, it's not on the build farm, and the bootloader
build is broken by other refactoring.
Change-Id: Idd9e3c46fac9b96f416ce444182f97a50770e747
Expands upon c067b344e8. The bug mentioned in that commit affects
touchscreens as well as touchpads, plus touchscreens were subject
to a few other issues because 'last->tick' was not always set.
Change-Id: I27eaa045ebf09555259fddbdf3a79828a55ae31f
I feel this is probably unlikely to be called with a NULL pointer
for cachep but being that we are already doing the check why not
guard file_cache_reset as well
Change-Id: I1a13767ef28a4129ae3513f7aa999fb6c1d6fad8
Similar to the native port, the hosted port benefits from
adding a -1 dc bias to the PCM data. This prevents almost
all clicking artifacts.
Change-Id: Ic6378716774b6d88df23c476e2ef54d49f33dc72
