From e59558277ee721000fd75fe6d891fb044165ab6e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rafa=C3=ABl=20Carr=C3=A9?= Date: Sat, 2 Jul 2011 02:49:15 +0000 Subject: [PATCH] bootloaders: cleanup - make printf buffer static and local to printf() - use '\0' instead of 0 for setting char - remove unused dummy functions git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30117 a1c6a512-1295-4272-9138-f99709370657 --- bootloader/common.c | 16 ++-------------- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/bootloader/common.c b/bootloader/common.c index 8fb7cdef36..207d74ae9c 100644 --- a/bootloader/common.c +++ b/bootloader/common.c @@ -57,8 +57,6 @@ int line = 0; int remote_line = 0; #endif -char printfbuf[256]; - void reset_screen(void) { lcd_clear_display(); @@ -71,6 +69,7 @@ void reset_screen(void) int printf(const char *format, ...) { + static char printfbuf[256]; int len; unsigned char *ptr; va_list ap; @@ -185,7 +184,7 @@ int load_firmware(unsigned char* buf, char* firmware, int buffer_size) if(rc < 4) return EREAD_MODEL_FAILED; - model[4] = 0; + model[4] = '\0'; printf("Model name: %s", model); printf("Loading %s", firmware); @@ -240,17 +239,6 @@ int load_raw_firmware(unsigned char* buf, char* firmware, int buffer_size) return len; } -/* These functions are present in the firmware library, but we reimplement - them here because the originals do a lot more than we want */ -int dbg_ports(void) -{ - return 0; -} - -void mpeg_stop(void) -{ -} - #ifdef ROCKBOX_HAS_LOGF /* Logf display helper for the bootloader */ #define LINES (LCD_HEIGHT/SYSFONT_HEIGHT)