From 5d048e04a0748a0fdc633ebdb4cdc22fa849f126 Mon Sep 17 00:00:00 2001 From: Amaury Pouly Date: Sat, 14 Jan 2017 18:11:56 +0100 Subject: [PATCH] zen/zenxfi: add remark about pin Clearly this pin does not control power so don't call it lcd_power. Change-Id: I9a6794e2606de99cb44dd3e7288b5cce5beb8d0d --- firmware/target/arm/imx233/creative-zen/lcd-zen.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/firmware/target/arm/imx233/creative-zen/lcd-zen.c b/firmware/target/arm/imx233/creative-zen/lcd-zen.c index d4beebf736..d21d26c0c3 100644 --- a/firmware/target/arm/imx233/creative-zen/lcd-zen.c +++ b/firmware/target/arm/imx233/creative-zen/lcd-zen.c @@ -149,13 +149,14 @@ static void spi_write_reg(uint8_t reg, uint16_t value) * LCD control */ -static void lcd_power(bool en) +static void lcd_something(bool en) { + /* I don't know what this pin does */ imx233_pinctrl_set_gpio(1, 8, en); mdelay(10); } -static void lcd_power_seq(void) +static void lcd_something_seq(void) { spi_write_reg(0x7, 0); mdelay(10); @@ -242,9 +243,9 @@ void lcd_enable(bool enable) imx233_lcdif_reset_lcd(true); mdelay(1); // "power" on - lcd_power(true); + lcd_something(true); // setup registers - lcd_power_seq(); + lcd_something_seq(); lcd_init_seq(); lcd_display_on_seq(); @@ -255,7 +256,7 @@ void lcd_enable(bool enable) { // power down lcd_display_off_seq(); - lcd_power(false); + lcd_something(false); // stop lcdif BF_CLR(LCDIF_CTRL, DOTCLK_MODE); /* stmp37xx errata: clearing DOTCLK_MODE won't clear RUN: wait until @@ -280,7 +281,7 @@ void lcd_init_device(void) { semaphore_init(&g_wait_sema, 1, 0); /* I'm not really sure this pin is related to power, it does not seem to do anything */ - imx233_pinctrl_acquire(1, 8, "lcd_power"); + imx233_pinctrl_acquire(1, 8, "lcd_something"); imx233_pinctrl_acquire(1, 9, "lcd_spi_sdo"); imx233_pinctrl_acquire(1, 10, "lcd_spi_scl"); imx233_pinctrl_acquire(1, 11, "lcd_spi_cs");