From 59b8c7816fde56a721dea6d25cf08d45e17e1ffd Mon Sep 17 00:00:00 2001 From: Thomas Jarosch Date: Thu, 25 Aug 2011 19:18:20 +0000 Subject: [PATCH] Fix off-by-one memory corruption in resistor plugin. I'm wondering if that also was the cause for the lines exactly next to it: --------------------------------- /* This cleans out the mysterious garbage that appears */ rb->lcd_clear_display(); --------------------------------- -> Atleast I see no garbage in the sim. Credit for this bug goes to "cppcheck". git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30345 a1c6a512-1295-4272-9138-f99709370657 --- apps/plugins/resistor.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/apps/plugins/resistor.c b/apps/plugins/resistor.c index a0bd94911a..06d3bf9d7a 100644 --- a/apps/plugins/resistor.c +++ b/apps/plugins/resistor.c @@ -801,8 +801,8 @@ static void resistance_to_color(void) enum color units_used = 0; char out_str[20]; - - for(i=0; i<=10; i++) { kbd_buffer[i] = 0; } + + memset(kbd_buffer,0,sizeof(kbd_buffer)); /* This cleans out the mysterious garbage that appears */ rb->lcd_clear_display(); rb->splash(HZ/2, "Resistance to Colour");