From 1f3360f0216dbf54bcd50547a759fa6e514c6e76 Mon Sep 17 00:00:00 2001 From: Brandon Low Date: Fri, 13 Oct 2006 20:48:23 +0000 Subject: [PATCH] Just take out some out-of-date TODOs from playback.c and put a big FIXME in pcmbuf.c git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11217 a1c6a512-1295-4272-9138-f99709370657 --- apps/pcmbuf.c | 9 ++++++++- apps/playback.c | 9 ++------- 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/apps/pcmbuf.c b/apps/pcmbuf.c index 6d2f68a238..964ebbc901 100644 --- a/apps/pcmbuf.c +++ b/apps/pcmbuf.c @@ -38,7 +38,7 @@ #include "thread.h" /* Keep watermark high for iPods at least (2s) */ -#define PCMBUF_WATERMARK (NATIVE_FREQUENCY * 8) +#define PCMBUF_WATERMARK (NATIVE_FREQUENCY * 4 * 2) /* Structure we can use to queue pcm chunks in memory to be played * by the driver code. */ @@ -203,6 +203,13 @@ process_new_buffer: *realsize = 0; *realstart = NULL; CALL_IF_EXISTS(pcmbuf_event_handler); + /* FIXME: We need to find another way to keep the CPU from + * being left boosted, because this is boosting in interrupt + * context. This is also not a good thing, because it will + * result in the CPU being deboosted if there is a legitimate + * buffer underrun (albeit only temporarily, because someone + * will reboost it soon, but it will make the skip longer + * than necessary. */ pcmbuf_boost(false); } } diff --git a/apps/playback.c b/apps/playback.c index 8ac669c172..8c480c46c7 100644 --- a/apps/playback.c +++ b/apps/playback.c @@ -17,19 +17,14 @@ * ****************************************************************************/ -/* TODO: Check for a possibly broken codepath on a rapid skip, stop event */ -/* TODO: same in reverse ^^ */ -/* TODO: Also play, stop ^^ */ /* TODO: Can use the track changed callback to detect end of track and seek * in the previous track until this happens */ -/* TODO: Pause should be handled in here, rather than PCMBUF so that voice can - * play whilst audio is paused */ /* Design: we have prev_ti already, have a conditional for what type of seek * to do on a seek request, if it is a previous track seek, skip previous, * and in the request_next_track callback set the offset up the same way that * starting from an offset works. */ -/* This is also necesary to prevent the problem with buffer overwriting on - * automatic track changes */ +/* TODO: Pause should be handled in here, rather than PCMBUF so that voice can + * play whilst audio is paused */ #include #include