Nyaaori/gamescope
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity

steamcompmgr: Avoid leaking title in get_win_title

Browse source
This commit is contained in:
Joshua Ashton 2023-01-11 22:43:19 +00:00
parent 45552dfdec
commit f2a4533cce
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/steamcompmgr.cpp
View file

@ -3202,6 +3202,8 @@ get_win_title(xwayland_ctx_t *ctx, win *w, Atom atom)
{ {
assert(atom == XA_WM_NAME || atom == ctx->atoms.netWMNameAtom); assert(atom == XA_WM_NAME || atom == ctx->atoms.netWMNameAtom);
// Allocates a title we are meant to free,
// let's re-use this allocation for w->title :)
XTextProperty tp; XTextProperty tp;
XGetTextProperty( ctx->dpy, w->id, &tp, atom ); XGetTextProperty( ctx->dpy, w->id, &tp, atom );
@ -3223,7 +3225,8 @@ get_win_title(xwayland_ctx_t *ctx, win *w, Atom atom)
free(w->title); free(w->title);
if (tp.nitems > 0) { if (tp.nitems > 0) {
w->title = strndup((char *)tp.value, tp.nitems); // Ride off the allocation from XGetTextProperty.
w->title = (char *)tp.value;
} else { } else {
w->title = NULL; w->title = NULL;
} }