drm: improve preferred flag comparison in compare_modes

Two preferred modes shouldn't happen, but this ensures a copy-paste
for another flag doesn't result in mis-sorted modes and it's more
consistent with the rest of the logic.
This commit is contained in:
Simon Ser 2022-07-29 09:25:50 +02:00
parent 90693b72cd
commit ce4699fc6d

View file

@ -319,10 +319,10 @@ static bool compare_modes( drmModeModeInfo mode1, drmModeModeInfo mode2 )
if (goodRefresh1 != goodRefresh2)
return goodRefresh1;
if (mode1.type & DRM_MODE_TYPE_PREFERRED)
return true;
if (mode2.type & DRM_MODE_TYPE_PREFERRED)
return false;
bool preferred1 = mode1.type & DRM_MODE_TYPE_PREFERRED;
bool preferred2 = mode2.type & DRM_MODE_TYPE_PREFERRED;
if (preferred1 != preferred2)
return preferred1;
int area1 = mode1.hdisplay * mode1.vdisplay;
int area2 = mode2.hdisplay * mode2.vdisplay;