Nyaaori/gamescope
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity

steamcompmgr: allocate cursor buffer on heap

Browse source 
This fixes a Clang failure, and ensures we don't blow up the stack on
big cursor sizes.

Closes: https://github.com/Plagman/gamescope/issues/140
This commit is contained in:
Simon Ser 2020-12-11 13:09:26 +01:00
parent 58be7270d6
commit 131514ecb8
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/steamcompmgr.cpp
View file

@ -841,12 +841,12 @@ bool MouseCursor::getTexture()
// Assume the cursor is fully translucent unless proven otherwise.
bool bNoCursor = true;
uint32_t cursorDataBuffer[m_width * m_height] = {0};
auto cursorBuffer = std::vector<uint32_t>(m_width * m_height);
for (int i = 0; i < image->height; i++) {
for (int j = 0; j < image->width; j++) {
cursorDataBuffer[i * m_width + j] = image->pixels[i * image->width + j];
cursorBuffer[i * m_width + j] = image->pixels[i * image->width + j];
if ( cursorDataBuffer[i * m_width + j] & 0x000000ff ) {
if ( cursorBuffer[i * m_width + j] & 0x000000ff ) {
bNoCursor = false;
}
}
@ -866,7 +866,7 @@ bool MouseCursor::getTexture()
// TODO: choose format & modifiers from cursor plane
m_texture = vulkan_create_texture_from_bits(m_width, m_height, VK_FORMAT_R8G8B8A8_UNORM,
cursorDataBuffer);
cursorBuffer.data());
assert(m_texture);
XFree(image);
m_dirty = false;