Feliday/Feliday-UI
5
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fixed unclickable button paddings

Browse source 
* Remove the wrapping <button> element that
  visually seems clickable but has no click
  handling (only its child link can be
  clicked)
* fixes #1193
This commit is contained in:
Florian Heft 2023-06-12 10:30:37 +02:00
parent d56addf7d6
commit 170949f34f
2 changed files with 25 additions and 29 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
src/shared/components/comment/comment-node.tsx
View file

@ -436,15 +436,13 @@ export class CommentNode extends Component<CommentNodeProps, CommentNodeState> {
<> <>
{!this.myComment && ( {!this.myComment && (
<> <>
<button className="btn btn-link btn-animate"> <Link
<Link className="btn btn-link btn-animate text-muted"
className="text-muted" to={`/create_private_message/${cv.creator.id}`}
to={`/create_private_message/${cv.creator.id}`} title={i18n.t("message").toLowerCase()}
title={i18n.t("message").toLowerCase()} >
> <Icon icon="mail" />
<Icon icon="mail" /> </Link>
</Link>
</button>
<button <button
className="btn btn-link btn-animate text-muted" className="btn btn-link btn-animate text-muted"
onClick={linkEvent( onClick={linkEvent(

38
src/shared/components/post/post-listing.tsx
View file

@ -649,29 +649,27 @@ export class PostListing extends Component<PostListingProps, PostListingState> {
get commentsButton() { get commentsButton() {
const post_view = this.props.post_view; const post_view = this.props.post_view;
return ( return (
<button className="btn btn-link text-muted py-0 pl-0"> <Link
<Link className="btn btn-link text-muted py-0 pl-0 text-muted"
className="text-muted" title={i18n.t("number_of_comments", {
title={i18n.t("number_of_comments", { count: Number(post_view.counts.comments),
formattedCount: Number(post_view.counts.comments),
})}
to={`/post/${post_view.post.id}?scrollToComments=true`}
>
<Icon icon="message-square" classes="mr-1" inline />
<span className="mr-2">
{i18n.t("number_of_comments", {
count: Number(post_view.counts.comments), count: Number(post_view.counts.comments),
formattedCount: Number(post_view.counts.comments), formattedCount: numToSI(post_view.counts.comments),
})} })}
to={`/post/${post_view.post.id}?scrollToComments=true`} </span>
> {this.unreadCount && (
<Icon icon="message-square" classes="mr-1" inline /> <span className="small text-warning">
<span className="mr-2"> ({this.unreadCount} {i18n.t("new")})
{i18n.t("number_of_comments", {
count: Number(post_view.counts.comments),
formattedCount: numToSI(post_view.counts.comments),
})}
</span> </span>
{this.unreadCount && ( )}
<span className="small text-warning"> </Link>
({this.unreadCount} {i18n.t("new")})
</span>
)}
</Link>
</button>
); );
} }